<div dir="ltr">Sorry maybe I didn't explain what I saw..(again sorry if this is known already and I'm stating the obvious to people who know better than me.) <div><br></div><div>The Revision contains rL in the repository field, as such the herald rule will add the LLVM project.and the llvm-commit subscriber whenever the revision is updated.<div><div><br></div><div>When the commit AutoCloses, it updates the Revision, as such if the revision still has the rL repository field then I believe the rule will fire again and add them. (post commit)</div><div><br></div><div><span style="color:rgb(116,119,125);font-family:"Segoe UI","Segoe UI Emoji","Segoe UI Symbol",Lato,"Helvetica Neue",Helvetica,Arial,sans-serif;font-size:13px;background-color:rgb(243,245,247)">This revision was automatically updated to reflect the committed changes.</span> <br></div><div><br></div><div><div class="gmail-phui-oi-name" style="font-size:13px;margin:0px;padding:8px 8px 0px;border:0px;white-space:nowrap;overflow:hidden;text-overflow:ellipsis;font-weight:bold;color:rgb(0,0,0);font-family:"Segoe UI","Segoe UI Emoji","Segoe UI Symbol",Lato,"Helvetica Neue",Helvetica,Arial,sans-serif"><span class="gmail-phui-oi-objname" style="cursor: text;">H270</span> <a href="https://reviews.llvm.org/H270" class="gmail-phui-oi-link" title="Tag SVN LLVM revisions as LLVM" style="color:rgb(19,108,178);text-decoration-line:none;display:inline">Tag SVN LLVM revisions as LLVM</a></div><div class="gmail-phui-oi-content" style="font-size:13px;margin:4px 8px 2px 0px;padding:0px;border:0px;overflow:hidden;color:rgb(0,0,0);font-family:"Segoe UI","Segoe UI Emoji","Segoe UI Symbol",Lato,"Helvetica Neue",Helvetica,Arial,sans-serif"><div class="gmail-phui-box gmail-mll gmail-mmb" style="margin:0px 0px 8px 16px;padding:0px;border:0px"><table class="gmail-phui-status-list-view" style="border-collapse:collapse;border-spacing:0px;font-size:inherit;width:1789px"><tbody><tr class="gmail-"><td class="gmail-phui-status-item-target" style="padding:1px 8px;border:0px;vertical-align:top;white-space:nowrap"><strong>Conditions</strong></td><td class="gmail-phui-status-item-note" style="padding:3px 4px;border:0px;vertical-align:top;width:1699px;color:rgb(116,119,125);line-height:14px"></td></tr><tr class="gmail-"><td class="gmail-phui-status-item-target" style="padding:1px 8px;border:0px;vertical-align:top;white-space:nowrap"><span class="gmail-visual-only gmail-phui-icon-view gmail-phui-font-fa gmail-fa-check gmail-green" style="display:inline-block;color:rgb(19,149,67);line-height:1;width:14px;height:14px;margin:2px 4px 2px 0px"></span>Passed</td><td class="gmail-phui-status-item-note" style="padding:3px 4px;border:0px;vertical-align:top;width:1699px;color:rgb(116,119,125);line-height:14px">Repository is any of <span class="gmail-condition-test-value">rCRT, rL, rLLD, rPLO, rT</span></td></tr><tr class="gmail-"><td class="gmail-phui-status-item-target" style="padding:1px 8px;border:0px;vertical-align:top;white-space:nowrap"><span class="gmail-visual-only gmail-phui-icon-view gmail-phui-font-fa gmail-fa-check gmail-green" style="display:inline-block;color:rgb(19,149,67);line-height:1;width:14px;height:14px;margin:2px 4px 2px 0px"></span>Passed</td><td class="gmail-phui-status-item-note" style="padding:3px 4px;border:0px;vertical-align:top;width:1699px;color:rgb(116,119,125);line-height:14px">Revision title does not contain <span class="gmail-condition-test-value">[private]</span></td></tr><tr class="gmail-"><td class="gmail-phui-status-item-target" style="padding:1px 8px;border:0px;vertical-align:top;white-space:nowrap"><span class="gmail-visual-only gmail-phui-icon-view gmail-phui-font-fa gmail-fa-check-circle gmail-green" style="display:inline-block;color:rgb(19,149,67);line-height:1;width:14px;height:14px;margin:2px 4px 2px 0px"></span><strong>Passed</strong></td><td class="gmail-phui-status-item-note" style="padding:3px 4px;border:0px;vertical-align:top;width:1699px;color:rgb(116,119,125);line-height:14px">Rule passed.</td></tr></tbody></table></div><div class="gmail-phui-box gmail-mll" style="margin:0px 0px 0px 16px;padding:0px;border:0px"><table class="gmail-phui-status-list-view" style="border-collapse:collapse;border-spacing:0px;font-size:inherit;width:1789px"><tbody><tr class="gmail-"><td class="gmail-phui-status-item-target" style="padding:1px 8px;border:0px;vertical-align:top;white-space:nowrap"><strong>Action: Add projects</strong></td><td class="gmail-phui-status-item-note" style="padding:3px 4px;border:0px;vertical-align:top;width:1640px;color:rgb(116,119,125);line-height:14px"></td></tr><tr class="gmail-"><td class="gmail-phui-status-item-target" style="padding:1px 8px;border:0px;vertical-align:top;white-space:nowrap"><span class="gmail-visual-only gmail-phui-icon-view gmail-phui-font-fa gmail-fa-briefcase gmail-green" style="display:inline-block;color:rgb(19,149,67);line-height:1;width:14px;height:14px;margin:2px 4px 2px 0px"></span>Added Projects</td><td class="gmail-phui-status-item-note" style="padding:3px 4px;border:0px;vertical-align:top;width:1640px;color:rgb(116,119,125);line-height:14px">Added a project: <span class="gmail-"><a href="https://reviews.llvm.org/tag/llvm/" class="gmail-phui-handle" style="color:rgb(70,76,92);text-decoration-line:none">LLVM</a></span>.</td></tr></tbody></table></div><div class="gmail-phui-box gmail-mll" style="margin:0px 0px 0px 16px;padding:0px;border:0px"><table class="gmail-phui-status-list-view" style="border-collapse:collapse;border-spacing:0px;font-size:inherit;width:1789px"><tbody><tr class="gmail-"><td class="gmail-phui-status-item-target" style="padding:1px 8px;border:0px;vertical-align:top;white-space:nowrap"><strong>Action: Add subscribers</strong></td><td class="gmail-phui-status-item-note" style="padding:3px 4px;border:0px;vertical-align:top;width:1620px;color:rgb(116,119,125);line-height:14px"></td></tr><tr class="gmail-"><td class="gmail-phui-status-item-target" style="padding:1px 8px;border:0px;vertical-align:top;white-space:nowrap"><span class="gmail-visual-only gmail-phui-icon-view gmail-phui-font-fa gmail-fa-envelope gmail-green" style="display:inline-block;color:rgb(19,149,67);line-height:1;width:14px;height:14px;margin:2px 4px 2px 0px"></span>Added Subscribers</td><td class="gmail-phui-status-item-note" style="padding:3px 4px;border:0px;vertical-align:top;width:1620px;color:rgb(116,119,125);line-height:14px">Added a subscriber: <span class="gmail-"><a href="https://reviews.llvm.org/p/llvm-commits/" class="gmail-phui-handle gmail-phui-link-person" style="color:rgb(70,76,92);text-decoration-line:none;white-space:nowrap">llvm-commits</a></span>.</td></tr></tbody></table></div></div></div><div><br></div><div>Its true I'm a little surprised that the Herald rule hadn't fired earlier and added the LLVM project and llvm-commit subscriber already, unless somehow it had, but they were removed manually, but I see no trace of that in the history.</div><div><br></div><div>Potentially you could extend the rule to say "Revision status is not any of Accepted", but I guess the whole point of that rule is to tell people watching rL that a commit for a revision marked as being part of rL has been changed</div><div><br></div><div>Unfortunately there isn't any connection between the Revision repository and the actual repo its committed to.</div><div><br></div><div>I do notice LLVM doesn't use the "Owners" application in Phabricator, this is an great way of ensuring code is automatically channeled to code owners/reviews for a particular area via the "Affected packages" in a hearld rule, and can be used to automate the adding of reviewers, blocking reviews, adding projects (but alas it doesn't allow the setting of the repository from what I can tell) </div><div><br></div><div>MyDeveloperDay (Paul)<br><div><div><br></div><div><div class="gmail-phui-oi-name" style="margin:0px;padding:8px 8px 0px;border:0px;white-space:nowrap;overflow:hidden;text-overflow:ellipsis;font-weight:bold;color:rgb(0,0,0);font-family:"Segoe UI","Segoe UI Emoji","Segoe UI Symbol",Lato,"Helvetica Neue",Helvetica,Arial,sans-serif;font-size:13px"><br></div><div class="gmail-phui-oi-content" style="margin:4px 8px 2px 0px;padding:0px;border:0px;overflow:hidden;color:rgb(0,0,0);font-family:"Segoe UI","Segoe UI Emoji","Segoe UI Symbol",Lato,"Helvetica Neue",Helvetica,Arial,sans-serif;font-size:13px"></div></div></div></div></div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Jun 3, 2019 at 5:21 PM <<a href="mailto:paul.robinson@sony.com">paul.robinson@sony.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div lang="EN-US">
<div class="gmail-m_-2552949525639212030WordSection1">
<p class="MsoNormal" style="margin-left:0.5in">As there is no mention of the repository being change the revisions feed (<a href="https://reviews.llvm.org/D62616" target="_blank">https://reviews.llvm.org/D62616</a>) I suspect it was created that way, and its only as the commit
fires that it gets added. (it might be clearer if a herald rule so these are added at review creation, although anyone then removing them will get them readded at commit if they still have the incorrect repository.)<u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"><u></u> <u></u></span></p>
<p class="MsoNormal"><a name="m_-2552949525639212030__MailEndCompose"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)">Note the highlighted part of this quote from the revision-closed email:<u></u><u></u></span></a></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-family:Arial,sans-serif;color:rgb(34,34,34);background:white">This revision was automatically updated to reflect the committed changes.</span><span style="font-family:Arial,sans-serif;color:rgb(34,34,34)"><br>
</span><span style="font-family:Arial,sans-serif;color:red;background:white">Closed by commit
</span><span style="font-family:Arial,sans-serif;color:rgb(34,34,34);background:white">rL362363: [CodeComplete] Add a bit more whitespace to completed patterns (authored by ibiryukov, committed by ).</span><span style="font-family:Arial,sans-serif;color:rgb(34,34,34)"><br>
</span><span style="font-family:Arial,sans-serif;color:red;background:white">Herald added a project: LLVM.</span><span style="font-family:Arial,sans-serif;color:red"><br>
<span style="background:white">Herald added a subscriber: llvm-commits</span></span><span style="font-family:Arial,sans-serif;color:rgb(34,34,34);background:white">.</span><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"><u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)">The LLVM project was added at the time Phabricator saw the closing commit, not when the revision was created.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)">If it had been added at the time the revision was created, all review emails would have gone to both lists. They did not.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)">--paulr<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"><u></u> <u></u></span></p>
<div style="border-top:none;border-right:none;border-bottom:none;border-left:1.5pt solid blue;padding:0in 0in 0in 4pt">
<div>
<div style="border-right:none;border-bottom:none;border-left:none;border-top:1pt solid rgb(181,196,223);padding:3pt 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10pt;font-family:Tahoma,sans-serif">From:</span></b><span style="font-size:10pt;font-family:Tahoma,sans-serif"> MyDeveloper Day [mailto:<a href="mailto:mydeveloperday@gmail.com" target="_blank">mydeveloperday@gmail.com</a>]
<br>
<b>Sent:</b> Monday, June 03, 2019 11:53 AM<br>
<b>To:</b> Robinson, Paul<br>
<b>Cc:</b> <a href="mailto:dlj@google.com" target="_blank">dlj@google.com</a>; llvm-dev; clang developer list; Aaron Ballman<br>
<b>Subject:</b> Re: [llvm-dev] FYI: LLVM Phabricactor notifications.<u></u><u></u></span></p>
</div>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div>
<p class="MsoNormal">PaulR<u></u><u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">(sorry again if this is known knowledge)<u></u><u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">> <span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)">There's no reason for Herald to be adding project LLVM/subscriber llvm-commits at the last second here.</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)">Its possible the rL (LLVM) had be added as the repository in the review on creation rather than rCFE, if thats the case then the herald rule "H270" is going
to fire because it see the repository in the review, so add LLVM project and llvm-commits as a subscriber automatically. It won't care that this has gone into rCFE and not rL (I mean it does go into rL via the cfe/trunk but I'm not sure if you want to notify
for that)</span><u></u><u></u></p>
</div>
</div>
</div>
<div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">As there is no mention of the repository being change the revisions feed (<a href="https://reviews.llvm.org/D62616" target="_blank">https://reviews.llvm.org/D62616</a>) I suspect it was created that way, and its only as the commit fires that it gets added.
(it might be clearer if a herald rule so these are added at review creation, although anyone then removing them will get them readded at commit if they still have the incorrect repository.)<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">MyDeveloperDay (Paul)<u></u><u></u></p>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote></div>