<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:"Segoe UI";
panose-1:2 11 5 2 4 2 4 2 2 3;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.gmail-phui-oi-objname
{mso-style-name:gmail-phui-oi-objname;}
span.gmail-visual-only
{mso-style-name:gmail-visual-only;}
span.gmail-condition-test-value
{mso-style-name:gmail-condition-test-value;}
span.gmail-
{mso-style-name:gmail-;}
span.EmailStyle22
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">The Revision won't have 'rL' in it, until after it has been committed, and the SVN revision number is assigned. That's why the particular herald rule doesn't
fire until the revision is closed.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">There is negative value in having changes to Clang (and LLDB, and maybe others) cc'd to llvm-commits. Those projects have their own mailing lists. Spamming
llvm-commits helps nobody.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Maybe the problem is that Clang and LLDB commits are somehow associated with 'rL' instead of some tag of their own. I don't know anything about how that was
all set up. All I know is that it's annoying and clutters up the mailing list.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">--paulr<o:p></o:p></span></p>
<p class="MsoNormal"><a name="_MailEndCompose"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></a></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> MyDeveloper Day [mailto:mydeveloperday@gmail.com]
<br>
<b>Sent:</b> Monday, June 03, 2019 1:08 PM<br>
<b>To:</b> Robinson, Paul<br>
<b>Cc:</b> David Jones; llvm-dev; clang developer list; Aaron Ballman<br>
<b>Subject:</b> Re: [llvm-dev] FYI: LLVM Phabricactor notifications.<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">Sorry maybe I didn't explain what I saw..(again sorry if this is known already and I'm stating the obvious to people who know better than me.) <o:p></o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">The Revision contains rL in the repository field, as such the herald rule will add the LLVM project.and the llvm-commit subscriber whenever the revision is updated.<o:p></o:p></p>
<div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">When the commit AutoCloses, it updates the Revision, as such if the revision still has the rL repository field then I believe the rule will fire again and add them. (post commit)<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Segoe UI","sans-serif";color:#74777D;background:#F3F5F7">This revision was automatically updated to reflect the committed changes.</span> <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<div>
<p class="MsoNormal"><span class="gmail-phui-oi-objname"><b><span style="font-size:10.0pt;font-family:"Segoe UI","sans-serif";color:black">H270</span></b></span><b><span style="font-size:10.0pt;font-family:"Segoe UI","sans-serif";color:black"> <a href="https://reviews.llvm.org/H270" title="Tag SVN LLVM revisions as LLVM"><span style="color:#136CB2">Tag
SVN LLVM revisions as LLVM</span></a><o:p></o:p></span></b></p>
</div>
<div style="margin-top:3.0pt;margin-right:6.0pt;margin-bottom:1.5pt;overflow:hidden">
<div style="margin-left:12.0pt;margin-bottom:6.0pt">
<table class="MsoNormalTable" border="0" cellspacing="0" cellpadding="0" width="1800" style="width:15.0in;border-collapse:collapse">
<tbody>
<tr>
<td nowrap="" valign="top" style="padding:.75pt 6.0pt .75pt 6.0pt">
<p class="MsoNormal"><strong>Conditions</strong><o:p></o:p></p>
</td>
<td width="1800" valign="top" style="width:15.0in;padding:2.25pt 3.0pt 2.25pt 3.0pt">
</td>
</tr>
<tr>
<td nowrap="" valign="top" style="padding:.75pt 6.0pt .75pt 6.0pt">
<p class="MsoNormal">Passed<o:p></o:p></p>
</td>
<td width="1800" valign="top" style="width:15.0in;padding:2.25pt 3.0pt 2.25pt 3.0pt">
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="color:#74777D">Repository is any of <span class="gmail-condition-test-value">rCRT, rL, rLLD, rPLO, rT</span><o:p></o:p></span></p>
</td>
</tr>
<tr>
<td nowrap="" valign="top" style="padding:.75pt 6.0pt .75pt 6.0pt">
<p class="MsoNormal">Passed<o:p></o:p></p>
</td>
<td width="1800" valign="top" style="width:15.0in;padding:2.25pt 3.0pt 2.25pt 3.0pt">
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="color:#74777D">Revision title does not contain <span class="gmail-condition-test-value">[private]</span><o:p></o:p></span></p>
</td>
</tr>
<tr>
<td nowrap="" valign="top" style="padding:.75pt 6.0pt .75pt 6.0pt">
<p class="MsoNormal"><strong>Passed</strong><o:p></o:p></p>
</td>
<td width="1800" valign="top" style="width:15.0in;padding:2.25pt 3.0pt 2.25pt 3.0pt">
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="color:#74777D">Rule passed.<o:p></o:p></span></p>
</td>
</tr>
</tbody>
</table>
</div>
<table class="MsoNormalTable" border="0" cellspacing="0" cellpadding="0" width="1800" style="width:15.0in;border-collapse:collapse">
<tbody>
<tr>
<td nowrap="" valign="top" style="padding:.75pt 6.0pt .75pt 6.0pt">
<p class="MsoNormal"><strong>Action: Add projects</strong><o:p></o:p></p>
</td>
<td width="1800" valign="top" style="width:15.0in;padding:2.25pt 3.0pt 2.25pt 3.0pt">
</td>
</tr>
<tr>
<td nowrap="" valign="top" style="padding:.75pt 6.0pt .75pt 6.0pt">
<p class="MsoNormal">Added Projects<o:p></o:p></p>
</td>
<td width="1800" valign="top" style="width:15.0in;padding:2.25pt 3.0pt 2.25pt 3.0pt">
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="color:#74777D">Added a project: <span class="gmail-"><a href="https://reviews.llvm.org/tag/llvm/"><span style="color:#464C5C">LLVM</span></a></span>.<o:p></o:p></span></p>
</td>
</tr>
</tbody>
</table>
<div style="margin-left:12.0pt">
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Segoe UI","sans-serif";color:black;display:none"><o:p> </o:p></span></p>
<table class="MsoNormalTable" border="0" cellspacing="0" cellpadding="0" width="1800" style="width:15.0in;border-collapse:collapse;border-spacing:0px;font-size:inherit">
<tbody>
<tr>
<td nowrap="" valign="top" style="padding:.75pt 6.0pt .75pt 6.0pt">
<p class="MsoNormal"><strong>Action: Add subscribers</strong><o:p></o:p></p>
</td>
<td width="1800" valign="top" style="width:15.0in;padding:2.25pt 3.0pt 2.25pt 3.0pt">
</td>
</tr>
<tr>
<td nowrap="" valign="top" style="padding:.75pt 6.0pt .75pt 6.0pt">
<p class="MsoNormal">Added Subscribers<o:p></o:p></p>
</td>
<td width="1800" valign="top" style="width:15.0in;padding:2.25pt 3.0pt 2.25pt 3.0pt">
<p class="MsoNormal" style="mso-line-height-alt:10.5pt"><span style="color:#74777D">Added a subscriber: <span class="gmail-"><a href="https://reviews.llvm.org/p/llvm-commits/"><span style="color:#464C5C">llvm-commits</span></a></span>.<o:p></o:p></span></p>
</td>
</tr>
</tbody>
</table>
</div>
</div>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Its true I'm a little surprised that the Herald rule hadn't fired earlier and added the LLVM project and llvm-commit subscriber already, unless somehow it had, but they were removed manually, but I see no trace of that in the history.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Potentially you could extend the rule to say "Revision status is not any of Accepted", but I guess the whole point of that rule is to tell people watching rL that a commit for a revision marked as being part of rL has been changed<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Unfortunately there isn't any connection between the Revision repository and the actual repo its committed to.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">I do notice LLVM doesn't use the "Owners" application in Phabricator, this is an great way of ensuring code is automatically channeled to code owners/reviews for a particular area via the "Affected packages" in a hearld rule, and can be
used to automate the adding of reviewers, blocking reviews, adding projects (but alas it doesn't allow the setting of the repository from what I can tell) <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">MyDeveloperDay (Paul)<o:p></o:p></p>
<div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<div>
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Segoe UI","sans-serif";color:black"><o:p> </o:p></span></b></p>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<p class="MsoNormal">On Mon, Jun 3, 2019 at 5:21 PM <<a href="mailto:paul.robinson@sony.com">paul.robinson@sony.com</a>> wrote:<o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:.5in">
As there is no mention of the repository being change the revisions feed (<a href="https://reviews.llvm.org/D62616" target="_blank">https://reviews.llvm.org/D62616</a>) I suspect it was created that way, and its only as the commit fires that it gets added.
(it might be clearer if a herald rule so these are added at review creation, although anyone then removing them will get them readded at commit if they still have the incorrect repository.)<o:p></o:p></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"> </span><o:p></o:p></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><a name="m_-2552949525639212030__MailEndCompose"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Note the highlighted part of this quote from the
revision-closed email:</span></a><o:p></o:p></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"> </span><o:p></o:p></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="font-family:"Arial","sans-serif";color:#222222;background:white">This revision was automatically updated to reflect the committed changes.</span><span style="font-family:"Arial","sans-serif";color:#222222"><br>
</span><span style="font-family:"Arial","sans-serif";color:red;background:white">Closed by commit
</span><span style="font-family:"Arial","sans-serif";color:#222222;background:white">rL362363: [CodeComplete] Add a bit more whitespace to completed patterns (authored by ibiryukov, committed by ).</span><span style="font-family:"Arial","sans-serif";color:#222222"><br>
</span><span style="font-family:"Arial","sans-serif";color:red;background:white">Herald added a project: LLVM.</span><span style="font-family:"Arial","sans-serif";color:red"><br>
<span style="background:white">Herald added a subscriber: llvm-commits</span></span><span style="font-family:"Arial","sans-serif";color:#222222;background:white">.</span><o:p></o:p></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"> </span><o:p></o:p></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">The LLVM project was added at the time Phabricator saw the closing commit, not when the revision
was created.</span><o:p></o:p></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">If it had been added at the time the revision was created, all review emails would have gone to both
lists. They did not.</span><o:p></o:p></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">--paulr</span><o:p></o:p></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"> </span><o:p></o:p></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> MyDeveloper Day [mailto:<a href="mailto:mydeveloperday@gmail.com" target="_blank">mydeveloperday@gmail.com</a>]
<br>
<b>Sent:</b> Monday, June 03, 2019 11:53 AM<br>
<b>To:</b> Robinson, Paul<br>
<b>Cc:</b> <a href="mailto:dlj@google.com" target="_blank">dlj@google.com</a>; llvm-dev; clang developer list; Aaron Ballman<br>
<b>Subject:</b> Re: [llvm-dev] FYI: LLVM Phabricactor notifications.</span><o:p></o:p></p>
</div>
</div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p>
<div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">PaulR<o:p></o:p></p>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">(sorry again if this is known knowledge)<o:p></o:p></p>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">> <span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">There's no reason for Herald to be adding project LLVM/subscriber llvm-commits at the last second
here.</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Its possible the rL (LLVM) had be added as the repository in the review on creation rather than rCFE,
if thats the case then the herald rule "H270" is going to fire because it see the repository in the review, so add LLVM project and llvm-commits as a subscriber automatically. It won't care that this has gone into rCFE and not rL (I mean it does go into rL
via the cfe/trunk but I'm not sure if you want to notify for that)</span><o:p></o:p></p>
</div>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">As there is no mention of the repository being change the revisions feed (<a href="https://reviews.llvm.org/D62616" target="_blank">https://reviews.llvm.org/D62616</a>) I suspect
it was created that way, and its only as the commit fires that it gets added. (it might be clearer if a herald rule so these are added at review creation, although anyone then removing them will get them readded at commit if they still have the incorrect
repository.)<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">MyDeveloperDay (Paul)<o:p></o:p></p>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
</div>
</div>
</div>
</body>
</html>