<div dir="ltr">We should be able to control the noise of these, but I also wonder whether we can switch to github reviews as part of the git move :)<div>(we just lost our long time phab maintainer on the team)<br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, May 31, 2019 at 12:44 AM Shoaib Meenai via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">I believe (and I believe it was James who pointed this out on IRC) that Phabricator pulls in all refs, and GitHub stores PR commits under refs/pull.<br>
<br>
On 5/30/19, 3:37 PM, "llvm-dev on behalf of Tom Stellard via llvm-dev" <<a href="mailto:llvm-dev-bounces@lists.llvm.org" target="_blank">llvm-dev-bounces@lists.llvm.org</a> on behalf of <a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>> wrote:<br>
<br>
On 05/30/2019 10:04 AM, Sachkov, Alexey via llvm-dev wrote:<br>
> +llvm-dev<br>
> <br>
> <br>
> <br>
> *From:* cfe-dev [mailto:<a href="mailto:cfe-dev-bounces@lists.llvm.org" target="_blank">cfe-dev-bounces@lists.llvm.org</a>] *On Behalf Of *Bader, Alexey via cfe-dev<br>
> *Sent:* Thursday, May 30, 2019 7:31 PM<br>
> *To:* clang-dev developer list <<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>><br>
> *Subject:* [cfe-dev] FYI: LLVM Phabricactor notifications.<br>
> *Importance:* Low<br>
> <br>
> <br>
> <br>
> Hi,<br>
> <br>
> <br>
> <br>
> I think some of contributors to the Clang received a notifications about some commits done in the past.<br>
> <br>
> I wanted to share my thoughts on why it might has happened.<br>
> <br>
> <br>
> <br>
> I think the commits from this PR <a href="https://github.com/llvm/llvm-project/pull/13were" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/pull/13were</a> pulled by Phabricator (probably with aim to review GitHub pull requests in <a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=AD-hZ9rLcmVgzhl1TFTAvKbX-nrgHD75y9sqN5zTEsg&s=KaCscc77Z-fBuYo2dCuykCeHg35yKQXRwp6uVuIsPos&e=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=AD-hZ9rLcmVgzhl1TFTAvKbX-nrgHD75y9sqN5zTEsg&s=KaCscc77Z-fBuYo2dCuykCeHg35yKQXRwp6uVuIsPos&e=</a> environment).<br>
> <br>
> <br>
> <br>
> The PR has 2000+ commit, most of which are some old commits from the master branch, and when Phabricator pulled the commits from PR, it sent a notification to the commit author (or committer).<br>
> <br>
> <br>
> <br>
> Probably we can do something to avoid this situation in the future.<br>
> <br>
> <br>
<br>
+ Manuel, Chandler<br>
<br>
Any idea what happened here? Is phabricator setup to automatically import<br>
pull requests? <br>
<br>
-Tom<br>
<br>
> <br>
> Sorry for the inconvenience.<br>
> <br>
> <br>
> <br>
> Alexey<br>
> <br>
> <br>
> <br>
> <br>
> --------------------------------------------------------------------<br>
> Joint Stock Company Intel A/O<br>
> Registered legal address: Krylatsky Hills Business Park,<br>
> 17 Krylatskaya Str., Bldg 4, Moscow 121614,<br>
> Russian Federation<br>
> <br>
> This e-mail and any attachments may contain confidential material for<br>
> the sole use of the intended recipient(s). Any review or distribution<br>
> by others is strictly prohibited. If you are not the intended<br>
> recipient, please contact the sender and delete all copies.<br>
> <br>
> <br>
> <br>
> _______________________________________________<br>
> LLVM Developers mailing list<br>
> <a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
> <a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_llvm-2Ddev&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=AD-hZ9rLcmVgzhl1TFTAvKbX-nrgHD75y9sqN5zTEsg&s=42V9lvDIvDXSSvzhNIJLw7ddZMt54c2yNRxFpSMppEg&e=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_llvm-2Ddev&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=AD-hZ9rLcmVgzhl1TFTAvKbX-nrgHD75y9sqN5zTEsg&s=42V9lvDIvDXSSvzhNIJLw7ddZMt54c2yNRxFpSMppEg&e=</a><br>
> <br>
<br>
_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
<a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_llvm-2Ddev&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=AD-hZ9rLcmVgzhl1TFTAvKbX-nrgHD75y9sqN5zTEsg&s=42V9lvDIvDXSSvzhNIJLw7ddZMt54c2yNRxFpSMppEg&e=" rel="noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_llvm-2Ddev&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=AD-hZ9rLcmVgzhl1TFTAvKbX-nrgHD75y9sqN5zTEsg&s=42V9lvDIvDXSSvzhNIJLw7ddZMt54c2yNRxFpSMppEg&e=</a><br>
<br>
<br>
_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
</blockquote></div></div></div>