<div dir="ltr">I tweaked the notifications yesterday, hopefully we don't see more spam storms.<div><br></div><div>For filtering git refs: this is something that has changed substantially in Phabricator over the past couple of months, but I think I've managed to restrict notifications to only "master." (Although, again, this has changed a lot... getting this right depends on my own archaeological skills for digging through old revisions of the Phab documentation.)</div><div><div><br></div><div><br></div><div>There are some complicating factors in deciding what the notifications should actually be doing... one major source of complexity stems from the fact that we re-import most commits multiple times. This makes it hard to reason about how different notifications will fire, and which source will actually autoclose differential revisions.</div><div></div></div><div><br></div><div>The current state is that most commits should notify the committer twice: once for the Subversion repo (repo callign rL), and once for git master (rG). I think this may actually be the best state while we're living in both worlds: the SVN commit is the source of truth, but a lot of folks care about re-syncing from Git, so that also seems like something folks will want. Of course, this is a transitional pain point, and there's not going to be a single configuration that can satisfy every possible thing folks would want.</div><div><br></div><div>One particular change: I've disabled notifications for the duplicate Subversion meta-repos... so, for example, a commit to Clang will still get 2 notifications (rL and rG). Before yesterday, this should have sent 3: one each for rL, rG, and rC. Projects not in the monorepo will get notifications for rL only.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, May 31, 2019 at 2:15 AM Manuel Klimek via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, May 31, 2019 at 10:53 AM MyDeveloper Day <<a href="mailto:mydeveloperday@gmail.com" target="_blank">mydeveloperday@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><div dir="auto">I actually run a in-house Phabricator instance with 400+ users and multiple git repo including custom extension developments </div></div><div dir="auto"><br></div><div dir="auto">I also follow the Phabricator development quite closely because we upgrade every couple of weeks</div><div dir="auto"><br></div><div dir="auto">I’d be more than happy to help maintain the phab instance for LLVM</div></blockquote><div><br></div><div>Congrats. You're now an admin :)</div><div>(and thanks!!)</div><div><br></div><div>I'll figure out who easy it is to give access to our GCE to external folks, given everything on it is OSS stuff.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto"><br></div><div dir="auto">MyDeveloperDay</div><div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, 31 May 2019 at 09:19, Manuel Klimek via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, May 31, 2019 at 10:11 AM Aaron Ballman <<a href="mailto:aaron.ballman@gmail.com" target="_blank">aaron.ballman@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, May 31, 2019, 10:02 AM Roman Lebedev via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Fri, May 31, 2019 at 10:55 AM Manuel Klimek via llvm-dev<br>
<<a href="mailto:llvm-dev@lists.llvm.org" rel="noreferrer" target="_blank">llvm-dev@lists.llvm.org</a>> wrote:<br>
><br>
> We should be able to control the noise of these<br>
<br>
>, but I also wonder whether we can switch to github reviews as part of the git move :)<br>
(Provocative offtopic. (I personally hope that never ever happens.))<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">Strong +1 to not switching away from phab.</div></div></blockquote><div><br></div><div>Aaron, do you have admin on phab yet? If yes, would you mind to config the notifications?</div><div>(honestly, part of my comment was trying to figure out who wants it so badly that they'd be willing to help with maintenance - I have admin bits to hand out :)</div></div></div><div dir="ltr"><div class="gmail_quote"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto"><div dir="auto"><br></div><div dir="auto">~Aaron</div><div dir="auto"><br></div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
> (we just lost our long time phab maintainer on the team)<br>
<br>
> On Fri, May 31, 2019 at 12:44 AM Shoaib Meenai via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" rel="noreferrer" target="_blank">llvm-dev@lists.llvm.org</a>> wrote:<br>
>><br>
>> I believe (and I believe it was James who pointed this out on IRC) that Phabricator pulls in all refs, and GitHub stores PR commits under refs/pull.<br>
>><br>
>> On 5/30/19, 3:37 PM, "llvm-dev on behalf of Tom Stellard via llvm-dev" <<a href="mailto:llvm-dev-bounces@lists.llvm.org" rel="noreferrer" target="_blank">llvm-dev-bounces@lists.llvm.org</a> on behalf of <a href="mailto:llvm-dev@lists.llvm.org" rel="noreferrer" target="_blank">llvm-dev@lists.llvm.org</a>> wrote:<br>
>><br>
>> On 05/30/2019 10:04 AM, Sachkov, Alexey via llvm-dev wrote:<br>
>> > +llvm-dev<br>
>> ><br>
>> ><br>
>> ><br>
>> > *From:* cfe-dev [mailto:<a href="mailto:cfe-dev-bounces@lists.llvm.org" rel="noreferrer" target="_blank">cfe-dev-bounces@lists.llvm.org</a>] *On Behalf Of *Bader, Alexey via cfe-dev<br>
>> > *Sent:* Thursday, May 30, 2019 7:31 PM<br>
>> > *To:* clang-dev developer list <<a href="mailto:cfe-dev@lists.llvm.org" rel="noreferrer" target="_blank">cfe-dev@lists.llvm.org</a>><br>
>> > *Subject:* [cfe-dev] FYI: LLVM Phabricactor notifications.<br>
>> > *Importance:* Low<br>
>> ><br>
>> ><br>
>> ><br>
>> > Hi,<br>
>> ><br>
>> ><br>
>> ><br>
>> > I think some of contributors to the Clang received a notifications about some commits done in the past.<br>
>> ><br>
>> > I wanted to share my thoughts on why it might has happened.<br>
>> ><br>
>> ><br>
>> ><br>
>> > I think the commits from this PR <a href="https://github.com/llvm/llvm-project/pull/13were" rel="noreferrer noreferrer" target="_blank">https://github.com/llvm/llvm-project/pull/13were</a> pulled by Phabricator (probably with aim to review GitHub pull requests in <a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=AD-hZ9rLcmVgzhl1TFTAvKbX-nrgHD75y9sqN5zTEsg&s=KaCscc77Z-fBuYo2dCuykCeHg35yKQXRwp6uVuIsPos&e=" rel="noreferrer noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=AD-hZ9rLcmVgzhl1TFTAvKbX-nrgHD75y9sqN5zTEsg&s=KaCscc77Z-fBuYo2dCuykCeHg35yKQXRwp6uVuIsPos&e=</a> environment).<br>
>> ><br>
>> ><br>
>> ><br>
>> > The PR has 2000+ commit, most of which are some old commits from the master branch, and when Phabricator pulled the commits from PR, it sent a notification to the commit author (or committer).<br>
>> ><br>
>> ><br>
>> ><br>
>> > Probably we can do something to avoid this situation in the future.<br>
>> ><br>
>> ><br>
>><br>
>> + Manuel, Chandler<br>
>><br>
>> Any idea what happened here? Is phabricator setup to automatically import<br>
>> pull requests?<br>
>><br>
>> -Tom<br>
>><br>
>> ><br>
>> > Sorry for the inconvenience.<br>
>> ><br>
>> ><br>
>> ><br>
>> > Alexey<br>
>> ><br>
>> ><br>
>> ><br>
>> ><br>
>> > --------------------------------------------------------------------<br>
>> > Joint Stock Company Intel A/O<br>
>> > Registered legal address: Krylatsky Hills Business Park,<br>
>> > <a href="https://www.google.com/maps/search/17+Krylatskaya+Str.,+Bldg+4,+Moscow+121614,+%0D%0A+%C2%A0+%C2%A0+%C2%A0+Russian+Federation?entry=gmail&source=g" target="_blank">17 Krylatskaya Str., Bldg 4, Moscow 121614,</a><br><a href="https://www.google.com/maps/search/17+Krylatskaya+Str.,+Bldg+4,+Moscow+121614,+%0D%0A+%C2%A0+%C2%A0+%C2%A0+Russian+Federation?entry=gmail&source=g" target="_blank">
</a>>><a href="https://www.google.com/maps/search/17+Krylatskaya+Str.,+Bldg+4,+Moscow+121614,+%0D%0A+%C2%A0+%C2%A0+%C2%A0+Russian+Federation?entry=gmail&source=g" target="_blank"> </a>> <a href="https://www.google.com/maps/search/17+Krylatskaya+Str.,+Bldg+4,+Moscow+121614,+%0D%0A+%C2%A0+%C2%A0+%C2%A0+Russian+Federation?entry=gmail&source=g" target="_blank">Russian Federation</a><br>
>> ><br>
>> > This e-mail and any attachments may contain confidential material for<br>
>> > the sole use of the intended recipient(s). Any review or distribution<br>
>> > by others is strictly prohibited. If you are not the intended<br>
>> > recipient, please contact the sender and delete all copies.<br>
>> ><br>
>> ><br>
>> ><br>
>> > _______________________________________________<br>
>> > LLVM Developers mailing list<br>
>> > <a href="mailto:llvm-dev@lists.llvm.org" rel="noreferrer" target="_blank">llvm-dev@lists.llvm.org</a><br>
>> > <a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_llvm-2Ddev&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=AD-hZ9rLcmVgzhl1TFTAvKbX-nrgHD75y9sqN5zTEsg&s=42V9lvDIvDXSSvzhNIJLw7ddZMt54c2yNRxFpSMppEg&e=" rel="noreferrer noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_llvm-2Ddev&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=AD-hZ9rLcmVgzhl1TFTAvKbX-nrgHD75y9sqN5zTEsg&s=42V9lvDIvDXSSvzhNIJLw7ddZMt54c2yNRxFpSMppEg&e=</a><br>
>> ><br>
>><br>
>> _______________________________________________<br>
>> LLVM Developers mailing list<br>
>> <a href="mailto:llvm-dev@lists.llvm.org" rel="noreferrer" target="_blank">llvm-dev@lists.llvm.org</a><br>
>> <a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_llvm-2Ddev&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=AD-hZ9rLcmVgzhl1TFTAvKbX-nrgHD75y9sqN5zTEsg&s=42V9lvDIvDXSSvzhNIJLw7ddZMt54c2yNRxFpSMppEg&e=" rel="noreferrer noreferrer" target="_blank">https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_llvm-2Ddev&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=AD-hZ9rLcmVgzhl1TFTAvKbX-nrgHD75y9sqN5zTEsg&s=42V9lvDIvDXSSvzhNIJLw7ddZMt54c2yNRxFpSMppEg&e=</a><br>
>><br>
>><br>
>> _______________________________________________<br>
>> LLVM Developers mailing list<br>
>> <a href="mailto:llvm-dev@lists.llvm.org" rel="noreferrer" target="_blank">llvm-dev@lists.llvm.org</a><br>
>> <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
><br>
> _______________________________________________<br>
> LLVM Developers mailing list<br>
> <a href="mailto:llvm-dev@lists.llvm.org" rel="noreferrer" target="_blank">llvm-dev@lists.llvm.org</a><br>
> <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" rel="noreferrer" target="_blank">llvm-dev@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
</blockquote></div></div></div>
</blockquote></div></div>
_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
</blockquote></div></div>
</blockquote></div></div>
_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
</blockquote></div>