<div dir="auto"><span style="font-family:sans-serif;font-size:12.8px">+1 on not adding the new API</span></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, May 4, 2019, 11:51 AM David Blaikie via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">+1, if we're voting. I don't think it adds to the readability of code<br>
for me personally.<br>
<br>
On Sat, May 4, 2019 at 11:47 AM Chandler Carruth via llvm-dev<br>
<<a href="mailto:llvm-dev@lists.llvm.org" target="_blank" rel="noreferrer">llvm-dev@lists.llvm.org</a>> wrote:<br>
><br>
> On Mon, Apr 29, 2019, 02:37 David Chisnall via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank" rel="noreferrer">llvm-dev@lists.llvm.org</a>> wrote:<br>
>><br>
>> On 22/04/2019 15:15, Don Hinton via llvm-dev wrote:<br>
>> > Although there were a few no votes, it looks like there's a consensus<br>
>> > for adding a `isa_and_nonnull` type operator. While there were some who<br>
>> > preferred `isa_nonnull`, it wasn't overwhelming, and since<br>
>> > `isa_and_nonnull` is already committed, I'm going to leave it as<br>
>> > `isa_and_nonnull` for the time being.<br>
>><br>
>> Maybe I missed something, but it looked to me as if the consensus was<br>
>> that `isa_and_some_words<T>(foo)` imposed a higher cognitive load on the<br>
>> reader than `foo && isa<T>(foo)`, as well as being more to type in most<br>
>> cases, so wasn't worth adding.<br>
><br>
><br>
> FWIW, I agree with this and Bogner: this doesn't seem like an improvement worth the cost.<br>
><br>
>><br>
>> David<br>
>> _______________________________________________<br>
>> LLVM Developers mailing list<br>
>> <a href="mailto:llvm-dev@lists.llvm.org" target="_blank" rel="noreferrer">llvm-dev@lists.llvm.org</a><br>
>> <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
><br>
> _______________________________________________<br>
> LLVM Developers mailing list<br>
> <a href="mailto:llvm-dev@lists.llvm.org" target="_blank" rel="noreferrer">llvm-dev@lists.llvm.org</a><br>
> <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank" rel="noreferrer">llvm-dev@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
</blockquote></div>