<div dir="ltr">Patch LGTM, please commit it. :)</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, May 3, 2019 at 4:45 PM Craig Topper via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><div>Ok that's exactly the problem I had. The script expects that to return a directory name. But its just echoing back the argument because it doesn't recognize it. I assume it must be some difference in versions of git. I've been hacking around it with this</div><div><br></div><div><div>diff --git a/llvm/utils/git-svn/git-llvm b/llvm/utils/git-svn/git-llvm</div><div>index 0afa836..28a0a9b 100755</div><div>--- a/llvm/utils/git-svn/git-llvm</div><div>+++ b/llvm/utils/git-svn/git-llvm</div><div>@@ -392,6 +392,11 @@ def cmd_push(args):</div><div><br></div><div> # We need a staging area for SVN, let's hide it in the .git directory.</div><div> dot_git_dir = git('rev-parse', '--git-common-dir')</div><div>+ # Not all versions of git support --git-common-dir and just print the</div><div>+ # unknown command back. If this happens, fall back to --git-dir</div><div>+ if dot_git_dir == '--git-common-dir':</div><div>+ dot_git_dir = git('rev-parse', '--git-dir')</div><div>+</div><div> svn_root = os.path.join(dot_git_dir, 'llvm-upstream-svn')</div><div> svn_init(svn_root)</div></div><div><br></div><br clear="all"><div><div dir="ltr" class="gmail-m_8853407284080913612gmail_signature">~Craig</div></div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, May 3, 2019 at 12:56 PM Cameron McInally <<a href="mailto:cameron.mcinally@nyu.edu" target="_blank">cameron.mcinally@nyu.edu</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div>llvm-project/llvm> git rev-parse --git-common-dir</div><div>--git-common-dir</div><div>llvm-project/llvm><br></div></div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, May 3, 2019 at 3:48 PM Craig Topper <<a href="mailto:craig.topper@gmail.com" target="_blank">craig.topper@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>I might have seen this issue. What does "git rev-parse --git-common-dir" return for you?</div><br clear="all"><div><div dir="ltr" class="gmail-m_8853407284080913612gmail-m_-1070081310326280627gmail-m_-5427559255498885145gmail_signature">~Craig</div></div><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, May 3, 2019 at 12:35 PM Cameron McInally via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div>Hey,</div><div><br></div><div>First time using LLVM's git repo. Does 'git llvm push' take a really long time to work? I've tried to push a couple of times now and receive a message like:</div><div><br></div><div><scrubbed> llvm-project/llvm> git llvm push</div><div>Pushing 1 commit:</div><div> 2159c44 Update PatternMatcher for FNeg</div><div><br></div><div>Committed 2159c44 to svn.</div><div><scrubbed> llvm-project/llvm><br></div><div><br></div><div>The svn repo never seems to update though. Any ideas?</div></div></div></div>
_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
<a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_llvm-2Ddev&d=DwMFaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=O_4M49EtSpZ_-BQYeigzGv0P4__noMcSu2RYEjS1vKs&m=dRYQouxPmqxI-Gmg0oI9YDMppte-m8OkTB7n5xrNQtg&s=mTiQJ33-XQ-BSpS5RkqKYg2aqVHl8WE5KHIeXWVfslc&e=" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
</blockquote></div>
</blockquote></div>
</blockquote></div>
_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
</blockquote></div>