<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hi,<div class=""><br class=""></div><div class="">I triggered a build failure on a Windows-sanitizer by making the sanity checking in `ASAN_INTERCEPT_FUNC` a bit stricter.</div><div class="">My best guess is that the type of the defined interceptor is not compatible (in C++ typing terms) with the “real” function.</div><div class=""><br class=""></div><div class="">This seems to be the case for the following 2 functions:</div><div class=""><br class=""></div><div class="">CreateThread “no conversion”:</div><div class=""><div class=""><font face="Courier New" class="">From: 'DWORD (__cdecl *)(void * , __sanitizer::uptr, DWORD (__cdecl *)(void *), void *, DWORD, void * )'</font></div><div class=""><font face="Courier New" class="">To : 'HANDLE (__cdecl *)(LPSECURITY_ATTRIBUTES, SIZE_T , LPTHREAD_START_ROUTINE , LPVOID, DWORD, LPDWORD)'</font></div><div class=""><font face="Courier New" class=""><br class=""></font></div><div class="">__C_specific_handler:</div><div class=""><font face="Courier New" class="">From: 'int (__cdecl *)(void * , void *, void * , void * )'</font></div><div class=""><font face="Courier New" class="">To: 'EXCEPTION_DISPOSITION (__cdecl *)(_EXCEPTION_RECORD *, void *, _CONTEXT *, _DISPATCHER_CONTEXT *)'</font></div><div class=""><br class=""></div></div><div class=""><br class=""></div><div class="">Can someone on the Windows side take a quick look and revert my temporary fix?</div><div class=""><br class=""></div><div class="">Thanks!</div><div class="">Julian</div><div class=""><br class=""></div><div class=""><br class=""></div><div class="">Bot failure:</div><div class=""><a href="http://lab.llvm.org:8011/builders/sanitizer-windows/builds/45049/steps/stage%201%20build/logs/stdio" class="">http://lab.llvm.org:8011/builders/sanitizer-windows/builds/45049/steps/stage%201%20build/logs/stdio</a></div><div class=""><br class=""></div><div class="">My temporary fix:</div><div class=""><a href="https://github.com/llvm/llvm-project/commit/93c05f097a969666d48d67b8a658d5bc7e164478" class="">https://github.com/llvm/llvm-project/commit/93c05f097a969666d48d67b8a658d5bc7e164478</a></div><div class=""><br class=""></div><div class=""><br class=""></div><div class=""><div class=""><br class=""></div></div></body></html>