<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0in;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:Consolas;}
span.m6275910883927179878gmail-stx-line
{mso-style-name:m_6275910883927179878gmail-stx-line;}
span.EmailStyle20
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">For ignore-undefined-symbols.s, the simplest fix ought to be to have the llvm-mc RUN line take the source from <stdin>:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Courier New";color:#1F497D"># RUN: llvm-mc –filetype=obj –triple=x86_64-pc-linux %s –o %t.o –g<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">becomes<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Courier New";color:#1F497D"># RUN: llvm-mc –filetype=obj –triple=x86_64-pc-linux</span><b><span style="font-size:11.0pt;font-family:"Courier New";color:red"> <</span></b><span style="font-size:11.0pt;font-family:"Courier New";color:red">
</span><span style="font-size:11.0pt;font-family:"Courier New";color:#1F497D">%s –o %t.o –g<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">But in this case, llvm-symbolizer still prints the file as $CWD/<stdin> which seems like its own separate bug.<o:p></o:p></span></p>
<p class="MsoNormal"><a name="_MailEndCompose"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">--paulr<o:p></o:p></span></a></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> llvm-dev [mailto:llvm-dev-bounces@lists.llvm.org]
<b>On Behalf Of </b>Jordan Rupprecht via llvm-dev<br>
<b>Sent:</b> Friday, March 29, 2019 1:13 PM<br>
<b>To:</b> Csaba Raduly<br>
<b>Cc:</b> llvm-dev<br>
<b>Subject:</b> Re: [llvm-dev] Test failure due to file path<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">True, it could probably skip the filename printed at the beginning of readobj with something like this:<o:p></o:p></p>
<div>
<pre style="outline:none" id="m_6275910883927179878gmail-c1"><span class="m6275910883927179878gmail-stx-line"><span style="font-size:13.5pt;color:black">#REGEX1: Symbols [#REGEX1-NOT: foobaz<o:p></o:p></span></span></pre>
<pre><span class="m6275910883927179878gmail-stx-line"><span style="font-size:13.5pt;color:black">#REGEX1-NOT: bar<o:p></o:p></span></span></pre>
<pre><span class="m6275910883927179878gmail-stx-line"><span style="font-size:13.5pt;color:black">#REGEX1-NOT: rebar<o:p></o:p></span></span></pre>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<p class="MsoNormal">Mind contributing a patch? :)<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<p class="MsoNormal">On Fri, Mar 29, 2019 at 9:53 AM Csaba Raduly via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>> wrote:<o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal">Hi all,<br>
<br>
The following tests fail because my username (csabaraduly) contains "bar" :<br>
<br>
********************<br>
FAIL: LLVM :: tools/llvm-objcopy/ELF/regex.test (47099 of 50832)<br>
******************** TEST 'LLVM :: tools/llvm-objcopy/ELF/regex.test'<br>
FAILED ********************<br>
Script:<br>
--<br>
: 'RUN: at line 1';<br>
/home/csabaraduly/wk/LLVM-git/__build_release_99/bin/yaml2obj<br>
/home/csabaraduly/wk/LLVM-git/llvm/test/tools/llvm-objcopy/ELF/regex.test<br>
> /home/csabaraduly/wk/LLVM-git/__build_release_99/test/tools/llvm-objcopy/ELF/Output/regex.test.tmp<br>
: 'RUN: at line 4';<br>
/home/csabaraduly/wk/LLVM-git/__build_release_99/bin/llvm-objcopy<br>
--discard-all --regex -K 'ba'<br>
/home/csabaraduly/wk/LLVM-git/__build_release_99/test/tools/llvm-objcopy/ELF/Output/regex.test.tmp<br>
/home/csabaraduly/wk/LLVM-git/__build_release_99/test/tools/llvm-objcopy/ELF/Output/regex.test.tmp2<br>
: 'RUN: at line 5';<br>
/home/csabaraduly/wk/LLVM-git/__build_release_99/bin/llvm-readobj<br>
--symbols /home/csabaraduly/wk/LLVM-git/__build_release_99/test/tools/llvm-objcopy/ELF/Output/regex.test.tmp2<br>
| /home/csabaraduly/wk/LLVM-git/__build_release_99/bin/FileCheck<br>
/home/csabaraduly/wk/LLVM-git/llvm/test/tools/llvm-objcopy/ELF/regex.test<br>
--check-prefix=REGEX1<br>
: 'RUN: at line 8';<br>
/home/csabaraduly/wk/LLVM-git/__build_release_99/bin/llvm-objcopy<br>
--discard-all --regex -K 'ba.*'<br>
/home/csabaraduly/wk/LLVM-git/__build_release_99/test/tools/llvm-objcopy/ELF/Output/regex.test.tmp<br>
/home/csabaraduly/wk/LLVM-git/__build_release_99/test/tools/llvm-objcopy/ELF/Output/regex.test.tmp3<br>
: 'RUN: at line 9';<br>
/home/csabaraduly/wk/LLVM-git/__build_release_99/bin/llvm-readobj<br>
--symbols /home/csabaraduly/wk/LLVM-git/__build_release_99/test/tools/llvm-objcopy/ELF/Output/regex.test.tmp3<br>
| /home/csabaraduly/wk/LLVM-git/__build_release_99/bin/FileCheck<br>
/home/csabaraduly/wk/LLVM-git/llvm/test/tools/llvm-objcopy/ELF/regex.test<br>
--check-prefix=REGEX2<br>
: 'RUN: at line 12';<br>
/home/csabaraduly/wk/LLVM-git/__build_release_99/bin/llvm-objcopy<br>
--discard-all --regex -K '.*ba.*'<br>
/home/csabaraduly/wk/LLVM-git/__build_release_99/test/tools/llvm-objcopy/ELF/Output/regex.test.tmp<br>
/home/csabaraduly/wk/LLVM-git/__build_release_99/test/tools/llvm-objcopy/ELF/Output/regex.test.tmp4<br>
: 'RUN: at line 13';<br>
/home/csabaraduly/wk/LLVM-git/__build_release_99/bin/llvm-readobj<br>
--symbols /home/csabaraduly/wk/LLVM-git/__build_release_99/test/tools/llvm-objcopy/ELF/Output/regex.test.tmp4<br>
| /home/csabaraduly/wk/LLVM-git/__build_release_99/bin/FileCheck<br>
/home/csabaraduly/wk/LLVM-git/llvm/test/tools/llvm-objcopy/ELF/regex.test<br>
--check-prefix=REGEX3<br>
: 'RUN: at line 16';<br>
/home/csabaraduly/wk/LLVM-git/__build_release_99/bin/llvm-objcopy<br>
--discard-all --regex -K '^([a-z]+)*ba.*$'<br>
/home/csabaraduly/wk/LLVM-git/__build_release_99/test/tools/llvm-objcopy/ELF/Output/regex.test.tmp<br>
/home/csabaraduly/wk/LLVM-git/__build_release_99/test/tools/llvm-objcopy/ELF/Output/regex.test.tmp5<br>
: 'RUN: at line 17'; cmp<br>
/home/csabaraduly/wk/LLVM-git/__build_release_99/test/tools/llvm-objcopy/ELF/Output/regex.test.tmp4<br>
/home/csabaraduly/wk/LLVM-git/__build_release_99/test/tools/llvm-objcopy/ELF/Output/regex.test.tmp5<br>
--<br>
Exit Code: 1<br>
<br>
Command Output (stderr):<br>
--<br>
/home/csabaraduly/wk/LLVM-git/llvm/test/tools/llvm-objcopy/ELF/regex.test:51:14:<br>
error: REGEX1-NOT: excluded string found in input<br>
#REGEX1-NOT: bar<br>
^<br>
<stdin>:2:16: note: found here<br>
File: /home/csabaraduly/wk/LLVM-git/__build_release_99/test/tools/llvm-objcopy/ELF/Output/regex.test.tmp2<br>
^~~<br>
<br>
<br>
<br>
<br>
********************<br>
FAIL: LLVM :: tools/llvm-symbolizer/ignore-undefined-symbols.s (47626 of 50832)<br>
******************** TEST 'LLVM ::<br>
tools/llvm-symbolizer/ignore-undefined-symbols.s' FAILED<br>
********************<br>
Script:<br>
--<br>
: 'RUN: at line 2';<br>
/home/csabaraduly/wk/LLVM-git/__build_release_99/bin/llvm-mc<br>
--filetype=obj --triple=x86_64-pc-linux<br>
/home/csabaraduly/wk/LLVM-git/llvm/test/tools/llvm-symbolizer/ignore-undefined-symbols.s<br>
-o /home/csabaraduly/wk/LLVM-git/__build_release_99/test/tools/llvm-symbolizer/Output/ignore-undefined-symbols.s.tmp.o<br>
-g<br>
: 'RUN: at line 3';<br>
/home/csabaraduly/wk/LLVM-git/__build_release_99/bin/llvm-symbolizer<br>
--obj=/home/csabaraduly/wk/LLVM-git/__build_release_99/test/tools/llvm-symbolizer/Output/ignore-undefined-symbols.s.tmp.o<br>
0 | /home/csabaraduly/wk/LLVM-git/__build_release_99/bin/FileCheck<br>
/home/csabaraduly/wk/LLVM-git/llvm/test/tools/llvm-symbolizer/ignore-undefined-symbols.s<br>
--implicit-check-not=bar<br>
--<br>
Exit Code: 1<br>
<br>
Command Output (stderr):<br>
--<br>
command line:1:22: error: CHECK-NOT: excluded string found in input<br>
-implicit-check-not='bar'<br>
^<br>
<stdin>:2:10: note: found here<br>
/home/csabaraduly/wk/LLVM-git/llvm/test/tools/llvm-symbolizer/ignore-undefined-symbols.s:12:0<br>
^~~<br>
<br>
Maybe "bar" should be replaced with something less likely to appear<br>
accidentally in a file path, e.g. rumpelstiltskin :)<br>
<br>
Csaba<br>
-- <br>
You can get very substantial performance improvements<br>
by not doing the right thing. - Scott Meyers, An Effective C++11/14 Sampler<br>
So if you're looking for a completely portable, 100% standards-conformat way<br>
to get the wrong information: this is what you want. - Scott Meyers (C++TDaWYK)<br>
_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><o:p></o:p></p>
</blockquote>
</div>
</div>
</div>
</body>
</html>