<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Hi,<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Feb 26, 2019, at 3:20 AM, Ralf Jung via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">Hi Shoaib,<br class=""><br class=""><blockquote type="cite" class="">You added the old account for Eli (eli.friedman); I went ahead and switched it<br class="">to the newer account (efriedma). You can tell it's an old account because if you<br class="">go to <a href="https://reviews.llvm.org/p/eli.friedman/" class="">https://reviews.llvm.org/p/eli.friedman/</a> (which can be accessed by e.g.<br class="">clicking the eli.friedman in your reviewers list), the last activity is from<br class="">2016, whereas <a href="https://reviews.llvm.org/p/efriedma/" class="">https://reviews.llvm.org/p/efriedma/</a> has recent activity.<br class="">Hopefully that gets you some activity.<br class=""></blockquote><br class="">Thanks a lot! That seems like an easy trap to run into. Is there a way to not<br class="">suggest the old accounts (in the drop-down menu) when adding reviewers?<br class=""><br class=""><blockquote type="cite" class="">It's also customary to add llvm-commits<br class="">as a subscriber instead of a reviewer, but that shouldn't make too much of a<br class="">difference.<br class=""></blockquote><br class="">Thanks, I'll try to remember this for next time.<br class="">I did this based on the following text in [the<br class="">docs](<a href="https://llvm.org/docs/Phabricator.html#phabricator-request-review-web" class="">https://llvm.org/docs/Phabricator.html#phabricator-request-review-web</a>):<br class=""><br class=""><blockquote type="cite" class="">Add reviewers (see below for advice). (If you set the Repository field correctly, llvm-commits or cfe-commits will be subscribed automatically; otherwise, you will have to manually subscribe them.)<br class=""></blockquote><br class="">I was not aware of there being separate notions of "reviewers" and<br class="">"subscribers", so with this being in the "Add reviewers" not I thought "to<br class="">subscribe" meant "to add as a reviewer". Actually from what I recall,<br class="">llvm-commits had been added automatically (but I might misremember).<br class="">(I hope this kind of feedback helps to improve the documentation.)<br class=""></div></div></blockquote></div><br class=""><div class="">There’s <a href="https://llvm.org/docs/Contributing.html" class="">https://llvm.org/docs/Contributing.html</a> which would ideally contain all relevant info, but it might be hard to discover. Did you have a look at that page?</div><div class=""><br class=""></div><div class="">Cheers,</div><div class="">Florian</div></body></html>