<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style>
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal">Hi Ralf,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">You added the old account for Eli (eli.friedman); I went ahead and switched it to the newer account (efriedma). You can tell it's an old account because if you go to
<a href="https://reviews.llvm.org/p/eli.friedman/">https://reviews.llvm.org/p/eli.friedman/</a> (which can be accessed by e.g. clicking the eli.friedman in your reviewers list), the last activity is from 2016, whereas
<a href="https://reviews.llvm.org/p/efriedma/">https://reviews.llvm.org/p/efriedma/</a> has recent activity. Hopefully that gets you some activity. It's also customary to add llvm-commits as a subscriber instead of a reviewer, but that shouldn't make too much
of a difference.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">The standard procedure is also to ping reviews weekly, which helps get review activity in most cases.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal" style="margin-left:.5in"><b><span style="font-size:12.0pt;color:black">From:
</span></b><span style="font-size:12.0pt;color:black">llvm-dev <llvm-dev-bounces@lists.llvm.org> on behalf of Ralf Jung via llvm-dev <llvm-dev@lists.llvm.org><br>
<b>Reply-To: </b>Ralf Jung <post@ralfj.de><br>
<b>Date: </b>Monday, February 25, 2019 at 9:03 AM<br>
<b>To: </b>llvm-dev <llvm-dev@lists.llvm.org><br>
<b>Subject: </b>[llvm-dev] How to get a review for a patch?<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">Hi all,<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">I submitted a small documentation patch [1] three weeks ago. This is my first<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">patch submitted against LLVM, so I was extra careful to follow the instructions<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">(turns out this is quite a bit more complicated than the pull-request-based<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">workflow). So far, I got no reaction at all to my patch. Does that mean I did<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">something wrong, like picking the wrong reviewer? Should I pick another one?<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">Obviously I don't know the code organization nor any of the people involved, so<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">I don't feel I can meaningfully judge who might be able to review this patch.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">[1]: <a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D57600&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=geYJV3f7Jpb0hmOUToiU6RGGPLWOQ7wWwah_AlGL2_4&s=G82iq_IAHTCK264gxt8V7oXf20Ppt7zmAzr53wWGpks&e=">
https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D57600&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=geYJV3f7Jpb0hmOUToiU6RGGPLWOQ7wWwah_AlGL2_4&s=G82iq_IAHTCK264gxt8V7oXf20Ppt7zmAzr53wWGpks&e=</a><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">Kind regards,<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">Ralf<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">_______________________________________________<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in">LLVM Developers mailing list<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><a href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_llvm-2Ddev&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=geYJV3f7Jpb0hmOUToiU6RGGPLWOQ7wWwah_AlGL2_4&s=zn_t2nciTI6584SuUNb5yuFVbzfaJ1qrHco7ELwMRxI&e=">https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_llvm-2Ddev&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=geYJV3f7Jpb0hmOUToiU6RGGPLWOQ7wWwah_AlGL2_4&s=zn_t2nciTI6584SuUNb5yuFVbzfaJ1qrHco7ELwMRxI&e=</a><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><o:p> </o:p></p>
</div>
</div>
</body>
</html>