<div dir="ltr"><div>Just to mention that this fixed the issue I was seeing, thanks. +1 on sorting out thecross-compile step to propagate flags. I could imagine there being other flags that we are discarding and shouldn't be.</div><div><br></div><div>Now to find time to update both my Linux and Windows toolchains...<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, 7 Feb 2019 at 21:07, JF Bastien via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="overflow-wrap: break-word;"><br><div><blockquote type="cite"><div>On Feb 7, 2019, at 12:59 PM, Shoaib Meenai <<a href="mailto:smeenai@fb.com" target="_blank">smeenai@fb.com</a>> wrote:</div><br class="gmail-m_737620211166219289Apple-interchange-newline"><div><div class="gmail-m_737620211166219289WordSection1" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><div style="margin:0in 0in 0.0001pt;font-size:11pt;font-family:Calibri,sans-serif">This was easy enough to fix, so I did so in r353463.</div></div></div></blockquote><div><br></div><div>Thanks, I agree this fixes an immediate issue but it still doesn’t fix the root cause: it sounds like this cross-compile setup loses flags that it shouldn’t be losing.</div><div><br></div><br><blockquote type="cite"><div><div class="gmail-m_737620211166219289WordSection1" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><div style="border-style:solid none none;border-top:1pt solid rgb(181,196,223);padding:3pt 0in 0in"><div style="margin:0in 0in 0.0001pt;font-size:11pt;font-family:Calibri,sans-serif"><b><span style="font-size:12pt">From:<span class="gmail-m_737620211166219289Apple-converted-space"> </span></span></b><span style="font-size:12pt">llvm-dev <<a href="mailto:llvm-dev-bounces@lists.llvm.org" target="_blank">llvm-dev-bounces@lists.llvm.org</a>> on behalf of JF Bastien via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>><br><b>Reply-To:<span class="gmail-m_737620211166219289Apple-converted-space"> </span></b>JF Bastien <<a href="mailto:jfbastien@apple.com" target="_blank">jfbastien@apple.com</a>><br><b>Date:<span class="gmail-m_737620211166219289Apple-converted-space"> </span></b>Thursday, February 7, 2019 at 12:30 PM<br><b>To:<span class="gmail-m_737620211166219289Apple-converted-space"> </span></b>"<a href="mailto:paul.robinson@sony.com" target="_blank">paul.robinson@sony.com</a>" <<a href="mailto:paul.robinson@sony.com" target="_blank">paul.robinson@sony.com</a>><br><b>Cc:<span class="gmail-m_737620211166219289Apple-converted-space"> </span></b>"<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>" <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>><br><b>Subject:<span class="gmail-m_737620211166219289Apple-converted-space"> </span></b>Re: [llvm-dev] [RFC] migrating past C++11<u></u><u></u></span></div></div><div><div style="margin:0in 0in 0.0001pt;font-size:11pt;font-family:Calibri,sans-serif"><u></u> <u></u></div></div><div style="margin:0in 0in 0.0001pt;font-size:11pt;font-family:Calibri,sans-serif"><u></u> <u></u></div><div><div style="margin:0in 0in 0.0001pt;font-size:11pt;font-family:Calibri,sans-serif"><br><br><u></u><u></u></div><blockquote style="margin-top:5pt;margin-bottom:5pt"><div><div style="margin:0in 0in 0.0001pt;font-size:11pt;font-family:Calibri,sans-serif">On Feb 7, 2019, at 11:01 AM,<span class="gmail-m_737620211166219289Apple-converted-space"> </span><a href="mailto:paul.robinson@sony.com" style="color:purple;text-decoration:underline" target="_blank">paul.robinson@sony.com</a><span class="gmail-m_737620211166219289Apple-converted-space"> </span>wrote:<u></u><u></u></div></div><div style="margin:0in 0in 0.0001pt;font-size:11pt;font-family:Calibri,sans-serif"><u></u> <u></u></div><div><div style="margin-left:0.5in"><div style="margin:0in 0in 0.0001pt;font-size:11pt;font-family:Calibri,sans-serif"><span style="color:rgb(31,73,125)">It seems the CMake changes have landed; but the docs are still a bit out of date?</span><span style="font-size:12pt;font-family:"Times New Roman",serif"><u></u><u></u></span></div></div><div style="margin-left:0.5in"><div style="margin:0in 0in 0.0001pt;font-size:11pt;font-family:Calibri,sans-serif"><span style="color:rgb(31,73,125)">CMake.html talks about LLVM_FORCE_USE_OLD_TOOLCHAIN but not LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN.</span><span style="font-size:12pt;font-family:"Times New Roman",serif"><u></u><u></u></span></div></div><div><div style="margin:0in 0in 0.0001pt;font-size:11pt;font-family:Calibri,sans-serif"><span style="font-size:12pt;font-family:"Times New Roman",serif"> <u></u><u></u></span></div></div><div style="margin-left:0.5in"><div style="margin:0in 0in 0.0001pt;font-size:11pt;font-family:Calibri,sans-serif"><span style="font-size:12pt;font-family:"Times New Roman",serif">I’m. Not sure how one updates the website’s docs, I had assumed the RST files would automatically get rebuilt and pushed? Agreed we want it fixed, but I don’t think it’s good reason to revert since the error message is pretty clear.<u></u><u></u></span></div></div><div><div style="margin:0in 0in 0.0001pt;font-size:11pt;font-family:Calibri,sans-serif"><span style="color:rgb(31,73,125)"> </span><span style="font-size:12pt;font-family:"Times New Roman",serif"><u></u><u></u></span></div></div><div><div style="margin:0in 0in 0.0001pt;font-size:11pt;font-family:Calibri,sans-serif"><span style="color:rgb(31,73,125)">Huh. I also thought the website was kept up to date automagically, which is why I looked at the website not the source; but the source does have the new option. Never mind…</span><span style="font-size:12pt;font-family:"Times New Roman",serif"><u></u><u></u></span></div></div><div><div style="margin:0in 0in 0.0001pt;font-size:11pt;font-family:Calibri,sans-serif"><span style="color:rgb(31,73,125)"> </span><span style="font-size:12pt;font-family:"Times New Roman",serif"><u></u><u></u></span></div></div><div style="margin-left:0.5in"><div style="margin:0in 0in 0.0001pt;font-size:11pt;font-family:Calibri,sans-serif"><span style="color:rgb(31,73,125)">Also, it looks like LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN is not propagated down to the NATIVE configuration when you set LLVM_OPTIMIZED_TABLEGEN. If that's going to be a permanent deficiency, it should be mentioned in the docs as well.</span><span style="font-size:12pt;font-family:"Times New Roman",serif"><u></u><u></u></span></div></div><div><div style="margin:0in 0in 0.0001pt;font-size:11pt;font-family:Calibri,sans-serif"><span style="font-size:12pt;font-family:"Times New Roman",serif"> <u></u><u></u></span></div></div><div style="margin-left:0.5in"><div style="margin:0in 0in 0.0001pt;font-size:11pt;font-family:Calibri,sans-serif"><span style="font-size:12pt;font-family:"Times New Roman",serif">Someone mentioned MSVC was having issues that way? <a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_rL353374-23624722&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=jXkuL7NOOygyZEXTmkYhOIbDwj1UhwVNfH8WnSmowIA&s=UT6L9JA4kVtR0MRecFgpu3lQ6GkA1YKsZmhJshQ0Ynw&e=" style="color:purple;text-decoration:underline" target="_blank"><span style="color:purple">https://reviews.llvm.org/rL353374#624722</span></a><u></u><u></u></span></div></div><div style="margin-left:0.5in"><div style="margin:0in 0in 0.0001pt;font-size:11pt;font-family:Calibri,sans-serif"><span style="font-size:12pt;font-family:"Times New Roman",serif">That seems like general badness in the way that configuration is set up, no? It should probably get fixed separately<u></u><u></u></span></div></div><div><div style="margin:0in 0in 0.0001pt;font-size:11pt;font-family:Calibri,sans-serif"><span style="color:rgb(31,73,125)"> </span><span style="font-size:12pt;font-family:"Times New Roman",serif"><u></u><u></u></span></div></div><div><div style="margin:0in 0in 0.0001pt;font-size:11pt;font-family:Calibri,sans-serif"><span style="color:rgb(31,73,125)">"Somebody else ought to get around to fixing that someday so why bother documenting something that might eventually change" does not seem like a very robust argument. I've answered a pile of questions from newcomers lately, I would prefer that people not add new reasons for the documentation to lie about how things work currently. Or more accurately, don't work, because you can't currently use both those options at once.</span><span style="font-size:12pt;font-family:"Times New Roman",serif"><u></u><u></u></span></div></div><div><div style="margin:0in 0in 0.0001pt;font-size:11pt;font-family:Calibri,sans-serif"><span style="color:rgb(31,73,125)"> </span><span style="font-size:12pt;font-family:"Times New Roman",serif"><u></u><u></u></span></div></div><div><div style="margin:0in 0in 0.0001pt;font-size:11pt;font-family:Calibri,sans-serif"><span style="color:rgb(31,73,125)">If someone does change how the optimized-tablegen feature works (or eliminates it entirely), surely they would be able to update the documentation accordingly?</span><span style="font-size:12pt;font-family:"Times New Roman",serif"><u></u><u></u></span></div></div><div><div style="margin:0in 0in 0.0001pt;font-size:11pt;font-family:Calibri,sans-serif"><span style="color:rgb(31,73,125)">So, please fix.</span><span style="font-size:12pt;font-family:"Times New Roman",serif"><u></u><u></u></span></div></div></div></blockquote><div style="margin:0in 0in 0.0001pt;font-size:11pt;font-family:Calibri,sans-serif"><u></u> <u></u></div></div><div><div style="margin:0in 0in 0.0001pt;font-size:11pt;font-family:Calibri,sans-serif">Can you clarify what you’re asking for exactly, and who you’re asking it from?</div></div></div></div></blockquote></div><br></div>_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
</blockquote></div>