<div dir="auto"><div>Hooray! Thanks for perservering!<br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Feb 7, 2019, 1:28 PM JF Bastien via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space"><div>Indeed this has finally stuck, with just <font face="Comic Sans MS"><span style="font-style:normal">clang-with-lto-ubuntu</span></font> broken at the moment. I’m inclined to leave it checked in, and try to get it into the LLVM 8 branch as well.</div><div><br></div><br><div><blockquote type="cite"><div>On Feb 7, 2019, at 9:18 AM, <a href="mailto:paul.robinson@sony.com" target="_blank" rel="noreferrer">paul.robinson@sony.com</a> wrote:</div><br class="m_-8615274920672454141Apple-interchange-newline"><div><div class="m_-8615274920672454141WordSection1" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><div style="margin:0in 0in 0.0001pt;font-size:12pt;font-family:"Times New Roman",serif"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)">It seems the CMake changes have landed; but the docs are still a bit out of date?<u></u><u></u></span></div><div style="margin:0in 0in 0.0001pt;font-size:12pt;font-family:"Times New Roman",serif"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)">CMake.html talks about LLVM_FORCE_USE_OLD_TOOLCHAIN but not LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN.</span></div></div></div></blockquote><div><br></div><div>I’m. Not sure how one updates the website’s docs, I had assumed the RST files would automatically get rebuilt and pushed? Agreed we want it fixed, but I don’t think it’s good reason to revert since the error message is pretty clear.</div><div><br></div><div><br></div><blockquote type="cite"><div class="m_-8615274920672454141WordSection1" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><div style="margin:0in 0in 0.0001pt;font-size:12pt;font-family:"Times New Roman",serif"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)">Also, it looks like LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN is not propagated down to the NATIVE configuration when you set LLVM_OPTIMIZED_TABLEGEN.  If that's going to be a permanent deficiency, it should be mentioned in the docs as well.</span></div></div></blockquote><div><br></div><div>Someone mentioned MSVC was having issues that way? <a href="https://reviews.llvm.org/rL353374#624722" target="_blank" rel="noreferrer">https://reviews.llvm.org/rL353374#624722</a></div><div>That seems like general badness in the way that configuration is set up, no? It should probably get fixed separately.</div><div><br></div><br><blockquote type="cite"><div class="m_-8615274920672454141WordSection1" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><div style="margin:0in 0in 0.0001pt;font-size:12pt;font-family:"Times New Roman",serif"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"><u></u><u></u></span></div><div style="margin:0in 0in 0.0001pt;font-size:12pt;font-family:"Times New Roman",serif"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)">Thanks,<u></u><u></u></span></div><div style="margin:0in 0in 0.0001pt;font-size:12pt;font-family:"Times New Roman",serif"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)">--paulr<u></u><u></u></span></div><div style="margin:0in 0in 0.0001pt;font-size:12pt;font-family:"Times New Roman",serif"><a name="m_-8615274920672454141__MailEndCompose" rel="noreferrer"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"><u></u> <u></u></span></a></div><div style="border-style:none none none solid;border-left-width:1.5pt;border-left-color:blue;padding:0in 0in 0in 4pt"><div><div style="border-style:solid none none;border-top-width:1pt;border-top-color:rgb(181,196,223);padding:3pt 0in 0in"><div style="margin:0in 0in 0.0001pt;font-size:12pt;font-family:"Times New Roman",serif"><b><span style="font-size:10pt;font-family:Tahoma,sans-serif">From:</span></b><span style="font-size:10pt;font-family:Tahoma,sans-serif"><span class="m_-8615274920672454141Apple-converted-space"> </span>llvm-dev [<a href="mailto:llvm-dev-bounces@lists.llvm.org" target="_blank" rel="noreferrer">mailto:llvm-dev-bounces@lists.llvm.org</a>]<span class="m_-8615274920672454141Apple-converted-space"> </span><b>On Behalf Of<span class="m_-8615274920672454141Apple-converted-space"> </span></b>JF Bastien via llvm-dev<br><b>Sent:</b><span class="m_-8615274920672454141Apple-converted-space"> </span>Saturday, February 02, 2019 1:04 AM<br><b>To:</b><span class="m_-8615274920672454141Apple-converted-space"> </span>via llvm-dev<br><b>Subject:</b><span class="m_-8615274920672454141Apple-converted-space"> </span>Re: [llvm-dev] [RFC] migrating past C++11<u></u><u></u></span></div></div></div><div style="margin:0in 0in 0.0001pt;font-size:12pt;font-family:"Times New Roman",serif"><u></u> <u></u></div><div style="margin:0in 0in 0.0001pt;font-size:12pt;font-family:"Times New Roman",serif">After a few attempts I think we’re in sight of success: we only have the two following bots remaining with old versions of libstdc++ and new versions of clang:<u></u><u></u></div><div><blockquote style="margin-left:30pt;margin-right:0in"><div style="margin:0in 0in 0.0001pt;font-size:12pt;font-family:"Times New Roman",serif"><u></u> <u></u></div><div><div><div style="margin:0in 0in 0.0001pt;font-size:12pt;font-family:"Times New Roman",serif">polly-amd64-linux<u></u><u></u></div></div></div><div><div><div style="margin:0in 0in 0.0001pt;font-size:12pt;font-family:"Times New Roman",serif">polly-arm-linux<u></u><u></u></div></div></div></blockquote><div><div><div style="margin:0in 0in 0.0001pt;font-size:12pt;font-family:"Times New Roman",serif"><u></u> <u></u></div></div><div><div style="margin:0in 0in 0.0001pt;font-size:12pt;font-family:"Times New Roman",serif">Once fixed the toolchain bump should stick.<u></u><u></u></div></div><div><div style="margin:0in 0in 0.0001pt;font-size:12pt;font-family:"Times New Roman",serif"><br><br><u></u><u></u></div><div><div style="margin:0in 0in 0.0001pt;font-size:12pt;font-family:"Times New Roman",serif">On Jan 31, 2019, at 2:07 PM, JF Bastien via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" style="color:purple;text-decoration:underline" target="_blank" rel="noreferrer">llvm-dev@lists.llvm.org</a>> wrote:<u></u><u></u></div></div><div style="margin:0in 0in 0.0001pt;font-size:12pt;font-family:"Times New Roman",serif"><u></u> <u></u></div><div><div><div style="margin:0in 0in 0.0001pt;font-size:12pt;font-family:"Times New Roman",serif"><span style="font-size:9pt;font-family:Helvetica,sans-serif"><br><br><br><u></u><u></u></span></div><div><div style="margin:0in 0in 0.0001pt;font-size:12pt;font-family:"Times New Roman",serif"><span style="font-size:9pt;font-family:Helvetica,sans-serif">On Jan 31, 2019, at 2:03 PM, Alex Bradbury <<a href="mailto:asb@asbradbury.org" style="color:purple;text-decoration:underline" target="_blank" rel="noreferrer">asb@asbradbury.org</a>> wrote:<u></u><u></u></span></div></div><div style="margin:0in 0in 0.0001pt;font-size:12pt;font-family:"Times New Roman",serif"><span style="font-size:9pt;font-family:Helvetica,sans-serif"><u></u> <u></u></span></div><div><div><div style="margin:0in 0in 0.0001pt;font-size:12pt;font-family:"Times New Roman",serif"><span style="font-size:9pt;font-family:Helvetica,sans-serif">On Tue, 29 Jan 2019 at 21:05, JF Bastien via llvm-dev<br><<a href="mailto:llvm-dev@lists.llvm.org" style="color:purple;text-decoration:underline" target="_blank" rel="noreferrer">llvm-dev@lists.llvm.org</a>> wrote:<br><br><u></u><u></u></span></div><div style="margin:0in 0in 0.0001pt;font-size:12pt;font-family:"Times New Roman",serif"><span style="font-size:9pt;font-family:Helvetica,sans-serif"><br>The patch is about ready to land, which means any older compiler will soft-error (which you can turn off with LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN). I think we should then cherry-pick the patch to the LLVM 8 branch.<br><br>The last remaining issue are the buildbots. I audited *all* bots in<span class="m_-8615274920672454141apple-converted-space"> </span><a href="http://lab.llvm.org:8011/buildslaves" style="color:purple;text-decoration:underline" target="_blank" rel="noreferrer">http://lab.llvm.org:8011/buildslaves</a><span class="m_-8615274920672454141apple-converted-space"> </span>(there's so many!). Some of them are down, I therefore have no idea what they run. Here are the bots that will definitely break, with their maintainers:<br><br>Galina Kistanova <<a href="mailto:gkistanova@gmail.com" style="color:purple;text-decoration:underline" target="_blank" rel="noreferrer">gkistanova@gmail.com</a>><br>am1i-slv1 -- gcc (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4<br>as-bldslv4 -- Microsoft (R) Visual Studio (R) 2015 (14.0)<br>ps4-buildslave2 -- Microsoft (R) Visual Studio (R) 2015 (14.0)<br><br>Hexagon QA <<a href="mailto:llvm.buildmaster@quicinc.com" style="color:purple;text-decoration:underline" target="_blank" rel="noreferrer">llvm.buildmaster@quicinc.com</a>><br>hexagon-build-02 -- gcc (Ubuntu 4.9.2-10ubuntu13) 4.9.2<br>hexagon-build-03 -- gcc (Ubuntu 4.9.2-10ubuntu13) 4.9.2<br><br>Vitaly Buka <<a href="mailto:vitalybuka@google.com" style="color:purple;text-decoration:underline" target="_blank" rel="noreferrer">vitalybuka@google.com</a>><br>sanitizer-buildbot6 -- gcc (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4<br><br>Reid Kleckner <<a href="mailto:rnk@google.com" style="color:purple;text-decoration:underline" target="_blank" rel="noreferrer">rnk@google.com</a>><br>sanitizer-windows -- Microsoft (R) Visual Studio (R) 2015 (14.0)<br><br>Ilia Taraban <<a href="mailto:mstester.llvm@gmail.com" style="color:purple;text-decoration:underline" target="_blank" rel="noreferrer">mstester.llvm@gmail.com</a>><br>windows7-buildbot -- Microsoft (R) Visual Studio (R) 2015 (14.0)<br><br><br>The maintainers have 3 options:<br><br>1. Pass LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN to their bot, suffer breakage later.<br>2. Update the bot to a newer compiler version.<br>3. Entirely turn down the bot.<br><br>I’ve emailed the maintainers and some have already responded. Once all bots are in a good state I’ll commit the patch (unless someone else chimes in with new information).<u></u><u></u></span></div><div style="margin:0in 0in 0.0001pt;font-size:12pt;font-family:"Times New Roman",serif"><span style="font-size:9pt;font-family:Helvetica,sans-serif"><br>Did anyone pick option 1)? If I understand correctly, we probably want<br>to ensure that at least some bots do this, so we can ensure an old<br>compiler + LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN build actually remains<br>functional up until the point support for the old compiler is actually<br>removed.<u></u><u></u></span></div></div></div><div><div style="margin:0in 0in 0.0001pt;font-size:12pt;font-family:"Times New Roman",serif"><span style="font-size:9pt;font-family:Helvetica,sans-serif"><u></u> <u></u></span></div></div><div><div style="margin:0in 0in 0.0001pt;font-size:12pt;font-family:"Times New Roman",serif"><span style="font-size:9pt;font-family:Helvetica,sans-serif">Reid asked me to do so for sanitizer-windows:<u></u><u></u></span></div></div></div><blockquote style="margin-left:30pt;margin-right:0in;font-variant-caps:normal;text-align:start;word-spacing:0px"><div><div><div style="margin:0in 0in 0.0001pt;font-size:12pt;font-family:"Times New Roman",serif"><span style="font-size:9pt;font-family:Helvetica,sans-serif"><a href="https://reviews.llvm.org/D57525" style="color:purple;text-decoration:underline" target="_blank" rel="noreferrer">https://reviews.llvm.org/D57525</a><u></u><u></u></span></div></div></div></blockquote><div><div><div style="margin:0in 0in 0.0001pt;font-size:12pt;font-family:"Times New Roman",serif"><span style="font-size:9pt;font-family:Helvetica,sans-serif"><u></u> <u></u></span></div></div><div><div style="margin:0in 0in 0.0001pt;font-size:12pt;font-family:"Times New Roman",serif"><span style="font-size:9pt;font-family:Helvetica,sans-serif">Ideally yes we’d have bots covering all eventualities, but this is but one of many holes in our coverage. On the upside, that hole is disappearing in a few months :)<u></u><u></u></span></div></div><div><div style="margin:0in 0in 0.0001pt;font-size:12pt;font-family:"Times New Roman",serif"><span style="font-size:9pt;font-family:Helvetica,sans-serif"><u></u> <u></u></span></div></div><div style="margin:0in 0in 0.0001pt;font-size:12pt;font-family:"Times New Roman",serif"><span style="font-size:9pt;font-family:Helvetica,sans-serif"><br><br><u></u><u></u></span></div><div><div><div style="margin:0in 0in 0.0001pt;font-size:12pt;font-family:"Times New Roman",serif"><span style="font-size:9pt;font-family:Helvetica,sans-serif">Best,<br><br>Alex<u></u><u></u></span></div></div></div></div><div style="margin:0in 0in 0.0001pt;font-size:12pt;font-family:"Times New Roman",serif"><span style="font-size:9pt;font-family:Helvetica,sans-serif"><br>_______________________________________________<br>LLVM Developers mailing list<br></span><a href="mailto:llvm-dev@lists.llvm.org" style="color:purple;text-decoration:underline" target="_blank" rel="noreferrer"><span style="font-size:9pt;font-family:Helvetica,sans-serif">llvm-dev@lists.llvm.org</span></a><span style="font-size:9pt;font-family:Helvetica,sans-serif"><br></span><a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" style="color:purple;text-decoration:underline" target="_blank" rel="noreferrer"><span style="font-size:9pt;font-family:Helvetica,sans-serif">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</span></a></div></div></div></div></div></div></div></blockquote></div><br></div>_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank" rel="noreferrer">llvm-dev@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
</blockquote></div></div></div>