<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Jan 31, 2019, at 2:03 PM, Alex Bradbury <<a href="mailto:asb@asbradbury.org" class="">asb@asbradbury.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">On Tue, 29 Jan 2019 at 21:05, JF Bastien via llvm-dev<br class=""><<a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a>> wrote:<br class=""><blockquote type="cite" class=""><br class="">The patch is about ready to land, which means any older compiler will soft-error (which you can turn off with LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN). I think we should then cherry-pick the patch to the LLVM 8 branch.<br class=""><br class="">The last remaining issue are the buildbots. I audited *all* bots in <a href="http://lab.llvm.org:8011/buildslaves" class="">http://lab.llvm.org:8011/buildslaves</a> (there's so many!). Some of them are down, I therefore have no idea what they run. Here are the bots that will definitely break, with their maintainers:<br class=""><br class="">Galina Kistanova <<a href="mailto:gkistanova@gmail.com" class="">gkistanova@gmail.com</a>><br class="">am1i-slv1 -- gcc (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4<br class="">as-bldslv4 -- Microsoft (R) Visual Studio (R) 2015 (14.0)<br class="">ps4-buildslave2 -- Microsoft (R) Visual Studio (R) 2015 (14.0)<br class=""><br class="">Hexagon QA <<a href="mailto:llvm.buildmaster@quicinc.com" class="">llvm.buildmaster@quicinc.com</a>><br class="">hexagon-build-02 -- gcc (Ubuntu 4.9.2-10ubuntu13) 4.9.2<br class="">hexagon-build-03 -- gcc (Ubuntu 4.9.2-10ubuntu13) 4.9.2<br class=""><br class="">Vitaly Buka <<a href="mailto:vitalybuka@google.com" class="">vitalybuka@google.com</a>><br class="">sanitizer-buildbot6 -- gcc (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4<br class=""><br class="">Reid Kleckner <<a href="mailto:rnk@google.com" class="">rnk@google.com</a>><br class="">sanitizer-windows -- Microsoft (R) Visual Studio (R) 2015 (14.0)<br class=""><br class="">Ilia Taraban <<a href="mailto:mstester.llvm@gmail.com" class="">mstester.llvm@gmail.com</a>><br class="">windows7-buildbot -- Microsoft (R) Visual Studio (R) 2015 (14.0)<br class=""><br class=""><br class="">The maintainers have 3 options:<br class=""><br class="">1. Pass LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN to their bot, suffer breakage later.<br class="">2. Update the bot to a newer compiler version.<br class="">3. Entirely turn down the bot.<br class=""><br class="">I’ve emailed the maintainers and some have already responded. Once all bots are in a good state I’ll commit the patch (unless someone else chimes in with new information).<br class=""></blockquote><br class="">Did anyone pick option 1)? If I understand correctly, we probably want<br class="">to ensure that at least some bots do this, so we can ensure an old<br class="">compiler + LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN build actually remains<br class="">functional up until the point support for the old compiler is actually<br class="">removed.<br class=""></div></div></blockquote><div><br class=""></div><div>Reid asked me to do so for sanitizer-windows:</div></div><blockquote style="margin: 0 0 0 40px; border: none; padding: 0px;" class=""><div><div><a href="https://reviews.llvm.org/D57525" class="">https://reviews.llvm.org/D57525</a></div></div></blockquote><div><div><br class=""></div><div>Ideally yes we’d have bots covering all eventualities, but this is but one of many holes in our coverage. On the upside, that hole is disappearing in a few months :)</div><div><br class=""></div><br class=""><blockquote type="cite" class=""><div class=""><div class="">Best,<br class=""><br class="">Alex<br class=""></div></div></blockquote></div><br class=""></body></html>