<div dir="ltr"><a class="gmail_plusreply" id="plusReplyChip-0" href="mailto:eugenis@google.com" tabindex="-1">+Evgenii Stepanov</a> <br></div><br><div class="gmail_quote"><div dir="ltr">On Wed, Jan 2, 2019 at 10:42 AM David Greene via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">After updating from trunk today, I am seeing this failure in hwasan:<br>
<br>
FAIL: HWAddressSanitizer-x86_64 :: TestCases/sizes.cpp (19011 of 49508)<br>
******************** TEST 'HWAddressSanitizer-x86_64 :: TestCases/sizes.cpp' FAILED ********************<br>
<snip><br>
Command Output (stderr):<br>
--<br>
+ : 'RUN: at line 1'<br>
+ /build/./bin/clang --driver-mode=g++ -fsanitize=hwaddress -mllvm -hwasan-generate-tags-with-calls -m64 -gline-tables-only /compiler-rt/test/hwasan/TestCases/sizes.cpp -lstdc++ -o /build/projects/compiler-rt/test/hwasan/X86_64/TestCases/Output/sizes.cpp.tmp<br>
/install/binutils/x86_64/bin/ld.gold: warning: Cannot export local symbol '__hwasan_thread_enter'<br>
/install/binutils/x86_64/bin/ld.gold: warning: Cannot export local symbol '__hwasan_thread_exit'<br>
/install/binutils/x86_64/bin/ld.gold: warning: Cannot export local symbol '__hwasan_tls'<br>
/tmp/lit_tmp_GtMlYc/sizes-acae44.o:sizes.cpp:function main: error: undefined reference to '__hwasan_memset'<br>
/tmp/lit_tmp_GtMlYc/sizes-acae44.o:sizes.cpp:function main: error: undefined reference to '__hwasan_memset'<br>
clang-8: error: linker command failed with exit code 1 (use -v to see invocation)<br>
<br>
I looked through the buildbots and I don't see anything that runs hwasan<br>
tests.<br>
<br>
As far as I can tell, the hwasan tests are only run as part of check-all<br>
when compiler-rt is included in a top-level LLVM build or as part of<br>
check-hwasan.  No clang or llvm builder include compiler-rt AFAICT, so<br>
check-all doesn't test it.  I don't see check-hwasan in this builder, or<br>
any of the other sanitizer builders I checked:<br>
<br>
<a href="http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/18677" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/18677</a><br>
<br>
Is there a hole in our testing?<br>
<br>
Anyone else seeing this failure?  Any idea of the cause?<br>
"hwasan_memset" doesn't appear anywhere in compiler-rt's history, but it<br>
shows up in LLVM:<br>
<br>
commit 631b5bc6125d979804e3e563935a93e2577e617c<br>
Author: Eugene Leviant <<a href="mailto:eleviant@accesssoftek.com" target="_blank">eleviant@accesssoftek.com</a>><br>
Date:   Thu Dec 20 09:04:33 2018 +0000<br>
<br>
    [HWASAN] Add support for memory intrinsics<br>
<br>
    Differential revision: <a href="https://reviews.llvm.org/D55117" rel="noreferrer" target="_blank">https://reviews.llvm.org/D55117</a><br>
<br>
<br>
    git-svn-id: <a href="https://llvm.org/svn/llvm-project/llvm/trunk@349728" rel="noreferrer" target="_blank">https://llvm.org/svn/llvm-project/llvm/trunk@349728</a> 91177308-0d34-0410-b5e6-96231b3b80d8<br>
<br>
This commit turned on memory intrinsic instrumentation by default and is<br>
the culprit, I'm guessing:<br>
<br>
commit 73121b2cc825d26b849e5c6fa04c690a6a35fb6e<br>
Author: Eugene Leviant <<a href="mailto:eleviant@accesssoftek.com" target="_blank">eleviant@accesssoftek.com</a>><br>
Date:   Mon Dec 24 16:02:48 2018 +0000<br>
<br>
    [HWASAN] Instrument memorty intrinsics by default<br>
<br>
    Differential revision: <a href="https://reviews.llvm.org/D55926" rel="noreferrer" target="_blank">https://reviews.llvm.org/D55926</a><br>
<br>
<br>
    git-svn-id: <a href="https://llvm.org/svn/llvm-project/llvm/trunk@350055" rel="noreferrer" target="_blank">https://llvm.org/svn/llvm-project/llvm/trunk@350055</a> 91177308-0d34-0410-b5e6-96231b3b80d8<br>
<br>
                           -David<br>
_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
</blockquote></div>