<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>+1 to having both modes, well, if you find a case which is
correct for the as-cast traversing one at least. <br>
</p>
<p>The default should probably be the non-as-cast traversing one for
correctness.</p>
<p>Philip</p>
<p><br>
</p>
<div class="moz-cite-prefix">On 12/14/18 9:04 AM, Doerfert, Johannes
Rudolf via llvm-dev wrote:<br>
</div>
<blockquote type="cite"
cite="mid:20181214170412.GB16697@arch-linux-jd">
<pre class="moz-quote-pre" wrap="">On 12/14, Matt Arsenault via llvm-dev wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">On Dec 14, 2018, at 2:44 PM, Finkel, Hal J. <a class="moz-txt-link-rfc2396E" href="mailto:hfinkel@anl.gov"><hfinkel@anl.gov></a> wrote:
Do you have an opinion on which should be the default?
-Hal
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
Not particularly. The current name sounds to me like it would strip
any casts it possibly can. Maybe most uses should now be converted to
a newly named stripTrivialPointerCasts?
-Matt
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
I can certainly introduce a new stripTrivialPointerCasts() function that
will keep the bit pattern while stripping casts. Wrt to the options I
pointed out earlier (see below), this would then be 2). Afterwards, we
might want to go through all the stripPointerCasts() users to make sure
they do not actually want to call stripTrivialPointerCasts() instead.
1) Make stripPointerCasts not look through address space casts. A new
function (or parameter) would then be introduced to do the same thing
_and_ peel of address space casts.
2) Keep looking through address space casts in stripPointerCasts. A new
function (or parameter) would then be introduced to do the same but with
the guarantee that the bit pattern is preserved.
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">_______________________________________________
LLVM Developers mailing list
<a class="moz-txt-link-abbreviated" href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a>
<a class="moz-txt-link-freetext" href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a>
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
LLVM Developers mailing list
<a class="moz-txt-link-abbreviated" href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a>
<a class="moz-txt-link-freetext" href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a>
</pre>
</blockquote>
</body>
</html>