<div dir="ltr"><div dir="ltr"><div dir="ltr"><div>I was originally using a dashboard similar to the one Sam created that included a panel with my subscription. Because that was a little too dense I've switched to using the default one and have a separate dashboard for subscriptions. I think it should be accessible to everyone: <a href="https://reviews.llvm.org/dashboard/view/28/">https://reviews.llvm.org/dashboard/view/28/</a></div><div><br></div><div>I added it as a menu item so it shows up as "Subscribed" under my activity in the left column. </div><div><br></div><div>Cheers,</div><div>Jonas</div><br><div class="gmail_quote"><div dir="ltr">On Mon, Dec 3, 2018 at 11:05 AM via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">
<div lang="EN-US">
<div class="gmail-m_2835460083381495211WordSection1">
<p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)">I have to say, thanks for this. I discovered I'm a reviewer on a couple of things…<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)">Is there a way to get "all open reviews that I'm subscribed to" (as opposed to, listed as a reviewer)?<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)">Thanks,<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)">--paulr<u></u><u></u></span></p>
<p class="MsoNormal"><a name="m_2835460083381495211__MailEndCompose"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"><u></u> <u></u></span></a></p>
<div style="border-style:none none none solid;border-left-width:1.5pt;border-left-color:blue;padding:0in 0in 0in 4pt">
<div>
<div style="border-style:solid none none;border-top-width:1pt;border-top-color:rgb(181,196,223);padding:3pt 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10pt;font-family:Tahoma,sans-serif">From:</span></b><span style="font-size:10pt;font-family:Tahoma,sans-serif"> llvm-dev [mailto:<a href="mailto:llvm-dev-bounces@lists.llvm.org" target="_blank">llvm-dev-bounces@lists.llvm.org</a>]
<b>On Behalf Of </b>Sam McCall via llvm-dev<br>
<b>Sent:</b> Tuesday, November 27, 2018 1:11 PM<br>
<b>To:</b> Michael Spencer<br>
<b>Cc:</b> LLVM Dev<br>
<b>Subject:</b> Re: [llvm-dev] Phabricator default view<u></u><u></u></span></p>
</div>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">Ah, I tried switching the default, and it doesn't work as I expected.<u></u><u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">The "My activity" view isn't shown in the menu for logged-out users, but it's still selected as the homepage, so
<a href="http://reviews.llvm.org" target="_blank">reviews.llvm.org</a> is an error page.<u></u><u></u></p>
</div>
</div>
<div>
<p class="MsoNormal">This seems like a blocker, I'll file a bug against phabricator.<u></u><u></u></p>
</div>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div>
<p class="MsoNormal">On Tue, Nov 27, 2018 at 2:38 AM Michael Spencer <<a href="mailto:bigcheesegs@gmail.com" target="_blank">bigcheesegs@gmail.com</a>> wrote:<u></u><u></u></p>
</div>
<blockquote style="border-style:none none none solid;border-left-width:1pt;border-left-color:rgb(204,204,204);padding:0in 0in 0in 6pt;margin-left:4.8pt;margin-right:0in">
<div>
<div>
<div>
<p class="MsoNormal">On Fri, Nov 23, 2018 at 5:59 AM Sam McCall via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>> wrote:<u></u><u></u></p>
</div>
</div>
<div>
<blockquote style="border-style:none none none solid;border-left-width:1pt;border-left-color:rgb(204,204,204);padding:0in 0in 0in 6pt;margin-left:4.8pt;margin-right:0in">
<div>
<div>
<div>
<p class="MsoNormal">Hi weary warriors of code reviewing,<u></u><u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">The default homepage in phabricator leaves some things to be desired IMO:<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"> - having changes sorted by *creation time* rather than *update time* is a fun way to lose track of things<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"> - the LLVM-wide activity feed seems not that useful (though fun)<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"> - as soon as a change lands, it becomes fairly hard to find<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Fortunately phabricator is pretty customizable. I've added a couple of views to the main menu:<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"> - My activity: <a href="https://reviews.llvm.org/home/menu/view/133/" target="_blank">https://reviews.llvm.org/home/menu/view/133/</a> is (active reviews, recent commits) x (i'm reviewer, i'm author). Only visible when logged in.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"> - All commits: <a href="https://reviews.llvm.org/home/menu/view/135/" target="_blank">https://reviews.llvm.org/home/menu/view/135/</a> is the firehose<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">I'd like to make "my activity" the default view for logged-in users, and "all commits" the default when logged out. (This is done by removing "home" from the menu).<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">These aren't optimal for any particular person (e.g. I'd like to see all clangd changes), and people should consider creating a custom dashboard if you use phabricator heavily. But I think they're reasonable defaults and a step up from
what we have now.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Let me know what you think, especially if you prefer the status quo for some specific reason.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">If people are generally positive, I'll change this next week. We can easily roll back.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Cheers, Sam<u></u><u></u></p>
</div>
</div>
</div>
</div>
</blockquote>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">I agree this is a much better default view for logged in users.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">- Michael Spencer <u></u><u></u></p>
</div>
</div>
</div>
</blockquote>
</div>
</div>
</div>
</div>
_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
</blockquote></div></div></div></div>