<div dir="ltr">Great! Thanks everyone for the input, I'm going to start splitting up the patch. I'll send out the non-mechanical parts separately.</div><br><div class="gmail_quote"><div dir="ltr">On Wed, Oct 31, 2018 at 10:03 PM Chris Lattner <<a href="mailto:sabre@nondot.org">sabre@nondot.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space">On Oct 31, 2018, at 2:24 PM, Reid Kleckner <<a href="mailto:rnk@google.com" target="_blank">rnk@google.com</a>> wrote:<div><blockquote type="cite"><div><div style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none">Alex Kornienko proposed enabling this warning back in 2012 here:<br></div><div style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><a href="http://lists.llvm.org/pipermail/llvm-dev/2012-July/051386.html" target="_blank">http://lists.llvm.org/pipermail/llvm-dev/2012-July/051386.html</a></div><div style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><br></div><div style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none">At the time, Chris Lattner said he didn't feel it was worth annotating</div><div style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none">all of LLVM and Clang with a new macro to enable this warning.</div></div></blockquote><br></div><div>FWIW, I formally withdraw my objection, go for it! :-)</div><div><br></div><div>-Chris</div><div><br></div></div></blockquote></div>