<div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div class="gmail_quote"><div dir="ltr">On Tue, Oct 23, 2018 at 10:07 AM NAKAMURA Takumi <<a href="mailto:geek4civic@gmail.com">geek4civic@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>James,</div><div><br></div><div>I have checked through your repo.</div><div>I don't find any major issues, at least on trunk, for guys to play on.</div><br class="gmail-m_301049115927069189inbox-inbox-Apple-interchange-newline"><div>A couple of minor concerns.<br></div><div>Note, I gave up inspecting commits older than r37632.</div><div>I just grafted from it.</div><div>I haven't checked branches yet. I think branches may be rewound easily.</div><div><br></div><div><br></div><div>1) Consistency of empty commits</div><div><br></div><div>I didn't conclude how they are handled. Almost all of them are svn-specific,</div><div>for example, to change props or to remove dirs.</div><div>I wonder they are partial.</div><div><br></div><div>FYI, I found almost all commits that touched particular subrepo.</div><div>For example, r1, creating repos. I miss it!</div></div></blockquote><div><br></div><div>It looks like what's happening is that svn2git is excluding commits containing only directory additions and changes of directory properties. E.g. r313601 was excluded. It doesn't exclude a commit consisting only of deletions of empty directories, however, so e.g. r342803 was kept.</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>My preference is "all or nothing" :)</div></div></blockquote><div><br></div><div>Yes, I think it's probably best to preserve the empty directory add+modify commits. I'll fix this...</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>I guess this issue would depend on svn2git.</div><div>I gave up using svn2git.</div><div><br></div><div><br></div><div>2) Glitches of authors who have changed their name</div><div><br></div><div>I found too many commits that have incompatible author filed.</div><div>I heard from you, you have sought through commits, mailing lists.</div><div>But I don't think all of glitches would be intentional.</div></div></blockquote><div><br></div><div>Indeed -- oops! I managed to insert an off-by-one error into the author mapping function, so there's a mismatch at every revision where the mapping changes. Fixing that...</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>Could you recheck? I have checked that my master repo can recreate</div></div></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>just identical commits against individual <a href="http://llvm.org/git" target="_blank">llvm.org/git</a>.</div><div><br></div><div>I could gather such glitches, or send you my authors.txt.</div><div><br></div><div><br></div><div>I think the migration may be done more carefully, at least span of weeks.</div><div>I wonder why guys are too urgent.</div></div></blockquote><div><br></div><div>I'm going to keep iterating, as long as these sorts of issues are being actively looked for and discovered. People are also anxious to get started with the next steps, which depend on a finalized repo, so I'm just hoping that doesn't go on for too long, but I'm happy as long as we're making active progress towards that goal!</div><div><br></div><div>Thanks for all your great help in checking things out so far!!</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>ps. I realized git-fast-export was really useful for this case. :p</div></div></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><br></div><div><br></div><div>Takumi</div><div><br></div><br><div class="gmail_quote"><div dir="ltr">On Fri, Oct 12, 2018 at 7:28 AM James Y Knight via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div>TLDR: <a href="https://github.com/llvm-git-prototype/" target="_blank">https://github.com/llvm-git-prototype/</a> exists as a read-only mirror of SVN, and is being updated continuously with a script running on an llvm-project AWS VM.</div><div><br>Let me know what you think.</div><div><br></div><div>I had meant to get this prototype finalized 6 months ago, and I must apologize for the delay. I hope this is close to final for what we want our git repository to look like, and that we can move forward with the remainder of the work to convert to git.<br></div><div><br></div><div><div>At this point, there's no guarantee that the repository won't be rebuilt from scratch with new hashes, if some problem is discovered which requires changing something way back in history. But I hope we're now close to being able to declare a conversion final -- and let people start depending on the hashes being stable.<br></div><br class="gmail-m_301049115927069189m_4971074960088007369gmail-Apple-interchange-newline"></div><div>This conversion uses the "flat monorepo" layout, like the previous existing git monorepo, and as discussed previously. The process generating it is different, which allows a more faithful conversion, including branches. I've also converted a bunch of the auxiliary repositories.</div><div><br></div><div>I would request that other people help take charge of the remainder of the work. Most importantly -- making a plan for implementing the *rest* of the migration. We have <a href="https://llvm.org/docs/Proposals/GitHubMove.html" target="_blank">https://llvm.org/docs/Proposals/GitHubMove.html</a>, but I think it'll need significant fleshing out and updating. I'm happy to assist with the rest of the migration, but I'd like to _not_ be primarily responsible for other parts beyond svn->git repository conversion.</div><div><br></div><div>Some things that could be discussed in such a plan:</div><div> * Verifying that this conversion is good, what we want, and declaring it final (at which point the hashes can be relied upon not to change).</div><div> * Any particular steps wanted here?</div><div> * Converting buildbots to use git.<br></div><div> * Phabricator changes?</div><div> * How do email notifications get sent for commits?</div><div> * Gathering github accounts for all committers, adding them to a github team.<br></div><div><div> * Deciding upon and announcing a timeline for switching over.</div></div><div> * Proposing, implementing, and testing new workflows for direct git usage:</div><div> * Github pull requests instead of (or in addition to?) phabricator?<br></div><div><div> * Github Protected Branch configuration options?<br></div><div> * E.g. -- direct pushing to git without any restriction, or, require that pull requests be created first?</div></div><div> * Automated Pre-commit testing? Do we setup CI (e.g. <a href="http://travis-ci.org" target="_blank">travis-ci.org</a>) to do some testing on pull requests, to reduce avoidable tree breakages?</div><div> * Any other github configuration options that need to be decided upon?</div><div> * ....other things I forgot about at the moment...<br></div><div> * Timeline for switchover.</div><div><br></div><div><br></div><div><br></div><div>Anyways, what's been done _so far_ is a full SVN->Git repository conversion. This conversion:</div><div> * Places the SVN revision number into the commit message, as "llvm-svn=1234"</div><div><br></div><div> * Automatically preserves all branches from the SVN repository (it merges the branches named /$project/branches/$name into a single "$name" branch, attempting, as much as possible, to make the branch-creation commits not look insane).</div><div><br></div><div> * Attempts to convert the svn branches in the "tags" subdir into annotated git tags pointing to the proper commit on the parent branch, where feasible. Sometimes this is impossible, since the "tags" have had modifications after their creation. (They're just branches in SVN, so you can do that, although you shouldn't). If so, they're preserved as a branch named "svntag/$name", instead.</div><div><br></div><div> * Preserves the svn id -> email mapping that was in-use at the time of each SVN commit, as far as is known.</div><div><br></div><div> * Fixes a bunch of -- but not all -- the CVS->SVN conversion errors (due, e.g., to files being renamed directly in the CVS repository).</div><div><br></div><div><br></div><div><br></div><div>Most of the SVN directories are migrated into sub-directories inside the main "llvm" mono-repository:<br></div><div><div> * cfe (renamed to clang in the conversion)</div><div> * clang-tools-extra</div><div> * compiler-rt</div><div> * debuginfo-tests</div><div> * dragonegg (also "gcc-plugin", the original name)</div><div> * libclc</div><div> * libcxx</div><div> * libcxxabi</div><div> * libunwind</div><div> * lld</div><div> * lldb</div><div> * llgo</div><div> * llvm</div><div> * openmp</div><div> * parallel-libs</div><div> * polly</div><div> * pstl<br></div><div> * stacker (deleted after r40406)</div><div>(Additionally, files added to the "monorepo-root/trunk" directory in SVN end up at the root of this repository).</div><div><br></div><div>Some SVN projects are still active, but not part of the LLVM codebase. These get migrated to their own separate git repositories:</div><div> * lnt</div><div> * test-suite</div><div> * www</div><div> * www-pubs</div><div> * www-releases ## TODO. Not done yet as it requires the use of git-lfs, due to large files.</div><div> * zorg</div><div><br></div><div>A couple inactive projects which are somewhat related to the LLVM codebase, migrated to separate repos:</div><div> * poolalloc</div><div> * safecode</div><div><br></div><div>Legacy projects that are not particularly interesting, migrated to a single separate git repository named "archive":</div><div> * clang-tests # Copy of GCC 4.2 testsuite, modified to work with clang</div><div> * clang-tests-external # Copy of GDB testsuite</div><div> * llvm-gcc-4.0 # GCC 4.0, modified for llvm</div><div> * llvm-gcc-4.2 # GCC 4.2, modified for llvm</div><div> * llvm-gcc-4-2 # (merge with above)</div><div> * java</div><div> * vmkit</div><div> * nightly-test-server</div><div> * llbrowse # An LLVM bitcode GUI browser</div><div> * television # A different LLVM GUI browser; shows effects of transforms, etc</div><div> * website # 2007-era snapshot of website, not actually maintained here.</div><div><div> * core, llvm-top, sample, support, hlvm # from the "HLVM" refactoring attempt.</div></div><div><br></div><div>Projects _not_ migrated from SVN in this conversion, since they're elsewhere already:</div><div> * giri # Never actually developed here; actually <a href="https://github.com/liuml07/giri" target="_blank">https://github.com/liuml07/giri</a></div><div> * klee # Already migrated to github with history; <a href="https://github.com/klee/klee" target="_blank">https://github.com/klee/klee</a></div><div class="gmail-m_301049115927069189m_4971074960088007369gmail-yj6qo"></div><br class="gmail-m_301049115927069189m_4971074960088007369gmail-Apple-interchange-newline"></div></div></div></div>
_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
</blockquote></div></div>
</blockquote></div></div></div></div></div></div></div></div>