<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><meta http-equiv="Content-Type" content="text/html; charset=us-ascii" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div class=""><br class=""><blockquote type="cite" class=""><div class="">On Oct 18, 2018, at 08:01, James Y Knight <<a href="mailto:jyknight@google.com" class="">jyknight@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div dir="ltr" class=""><div dir="ltr" class=""><div dir="ltr" class=""><div dir="ltr" class=""><div dir="ltr" class=""><div dir="ltr" class=""><div dir="ltr" class=""><div class="gmail_quote"><div dir="ltr" class="">On Thu, Oct 18, 2018 at 12:22 AM Duncan P. N. Exon Smith <<a href="mailto:dexonsmith@apple.com" class="">dexonsmith@apple.com</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="overflow-wrap: break-word;" class="">I did a sanity check of tree hashes and found something suspicious.<div class=""><br class=""></div><div class="">Background: I cloned the prototype as remote "github/llvm-git-prototype" and then added the existing Git mirror as "<a href="http://llvm.org/llvm" target="_blank" class="">llvm.org/llvm</a>":</div><div class=""><br class=""></div><div class=""><div class="">I did a couple of tree object spot checks. At ToT the tree objects match, both giving the tree 8cf37e491e61:</div></div></div></blockquote><div class=""><br class=""></div><div class="">Great, thanks for the verification!</div><div class=""> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="overflow-wrap: break-word;" class=""><div class=""><div class=""><div class=""><div class=""></div><div class="">But then I looked at r3210, and the tree objects don't match:</div></div></div></div></div></blockquote><div class=""> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="overflow-wrap: break-word;" class=""><div class=""><div class=""><div class=""><div class="">Picking another two arbitrary revisions: the tree objects for r43210 match, but not those for r3333.</div></div></div></div></div></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="overflow-wrap: break-word;" class=""><div class=""><div class=""><div class=""><div class=""></div></div></div></div></div></blockquote><div class=""> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="overflow-wrap: break-word;" class=""><div class=""><div class=""><div class=""><div class="">Do you know what would cause the trees to diverge? Could there be a correctness issue here?</div></div></div></div></div></blockquote><div class=""><br class=""></div><div class="">Indeed! There are intentional divergences from the existing git conversion -- and from the SVN repository -- before SVN r37801. Before that revision, I've fixed up some of the history where it was screwed up due to CVS shenanigans. (r37801 was the first commit actually done in SVN) I completely neglected to mention this to you last night, sorry -- I blame lack of sleep. </div><div class=""><br class=""></div><div class="">What you _will_ find, is that the repository now matches what was actually supposed to be in it, down through llvm release 1.4. This was achieved by moving files back to their original locations, at the appropriate points in history. </div></div></div></div></div></div></div></div></div></div></div></blockquote><br class=""></div><div class="">Okay, that clarifies it. It's a relatively small (and early) part of history so I'm not worried about the potential bloat from this either. Thanks for the explanation!</div><br class=""></div></body></html>