<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
On 09/27/2018 12:25 PM, Philip Pfaffe wrote:<br>
<blockquote type="cite"
cite="mid:CAHe691FGq-V3rC701svDMYSUo9HkzhdDn9pkXp6Vd+zDEWu1nA@mail.gmail.com">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<div dir="ltr">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">`opt <
%s -passed='asan' -asan-module -S`<br>
</blockquote>
<div>asan-module is another ModulePass, not a commandline
option. You can't mix that like this.</div>
</div>
</div>
</blockquote>
I'm inclined to consider this as a deficiency of our command line
interface.<br>
We really should be giving some noise about newpm's -passes
overriding any legacy-pass options.<br>
<br>
Especially since these legacy-pass options sometimes are hard to
distinguish from non-pass options.<br>
<br>
regards,<br>
Fedor.<br>
<br>
<blockquote type="cite"
cite="mid:CAHe691FGq-V3rC701svDMYSUo9HkzhdDn9pkXp6Vd+zDEWu1nA@mail.gmail.com">
<div dir="ltr">
<div class="gmail_quote">
<div><br>
</div>
<div>Cheers,</div>
<div>Philip</div>
<div><br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
doesn't produce the same IR as<br>
<br>
`opt < %s -asan -asan-module -S`<br>
<br>
More specifically, the only thing missing seems to be the<br>
`asan.module_ctor` that should get added to the global ctors
list.<br>
What I'm not sure of is if I'm missing something when I made
the new<br>
pass or it's something in the pipeline regarding which
passes run<br>
first between both PMs. I could just make an
AddressSanitizerModule<br>
pass for the new PM, but feel like this should still work
even if<br>
AddressSanitizer is added in the new PM and
AddressSanitizerModule is<br>
added in legacy.<br>
<br>
- Leo<br>
</blockquote>
</div>
</div>
</blockquote>
<br>
</body>
</html>