<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Hi Anton,<div class=""><br class=""></div><div class="">Thanks for the tip. I’ve moved some common code from the patch:</div><div class=""><br class=""></div><div class=""><a href="https://reviews.llvm.org/D50784" class="">https://reviews.llvm.org/D50784</a></div><div class=""><a href="https://reviews.llvm.org/D50856" class="">https://reviews.llvm.org/D50856</a></div><div class=""><a href="https://reviews.llvm.org/D50858" class="">https://reviews.llvm.org/D50858</a></div><div class=""><br class=""></div><div class="">but the backend itself is still quite large. Anything more I can do to simplify reviewing?<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On 15 Aug 2018, at 09:33, Anton Korobeynikov <<a href="mailto:anton@korobeynikov.info" class="">anton@korobeynikov.info</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">Hi Artyom,<br class=""><br class="">I made a very brief run over the patch and indeed it is quite large :)<br class=""><br class="">Will it be possible to split it to enable better review? For example<br class="">I'm seeing you're having some generic codegenerator / TableGen<br class="">changes. Will it be possible to separate them out and provide<br class="">rationale for them? Going further, probably triple and ELF-related<br class="">changes could be also separated out.<br class=""><br class=""><br class="">On Tue, Aug 14, 2018 at 9:32 PM, Gmail-m4yers via llvm-dev<br class=""><<a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a>> wrote:<br class=""><blockquote type="cite" class="">Hello friends,<br class=""><br class="">A couple years back I’ve started a M68K codegen port of LLVM, and then<br class="">suspended it for the lack of free time. Now I finally got some time and<br class="">willing to continue working on it. To keep up with LLVM changes I'd like to<br class="">merge it upstream.<br class=""><br class="">There is already patch for it: <a href="https://reviews.llvm.org/D50314" class="">https://reviews.llvm.org/D50314</a>, but then I<br class="">was reminded that adding a new backend is not a small thing. So, at this<br class="">point I require an advice, help or both on how to proceed, and since the<br class="">patch is quite big I am not sure that a single person would willingly spend<br class="">time reviewing it entirely.<br class=""><br class="">Kind regards,<br class="">Artyom<br class=""><br class="">_______________________________________________<br class="">LLVM Developers mailing list<br class=""><a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a><br class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev<br class=""><br class=""></blockquote><br class=""><br class=""><br class="">-- <br class="">With best regards, Anton Korobeynikov<br class="">Department of Statistical Modelling, Saint Petersburg State University<br class=""></div></div></blockquote></div><br class=""></div></body></html>