<div dir="ltr"><div>Will this patch make it into LLD 7.0.0 release?<br><br></div>It's currently the only patch that zig's LLD fork has on top of upstream.<br></div><br><div class="gmail_quote"><div dir="ltr">On Tue, Jul 31, 2018 at 12:49 AM Carlo Kok <<a href="mailto:ck@remobjects.com">ck@remobjects.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><u></u>
<div><div>When I wrote the test, it failed lld (assertion) in debug mode. I can't get it to fail for non debug but afaik the test system should fail on lld asserts?<br></div>
<div><br></div>
<div><br></div>
<div>On Mon, Jul 30, 2018, at 23:06, Rui Ueyama wrote:<br></div>
<blockquote type="cite"><div dir="ltr"><div>Sorry, I was thinking to review the test but didn't.<br></div>
<div><br></div>
<div>Is this test complete? It does invoke lld, but it didn't verify its output.<br></div>
</div>
<div><br></div>
<div><div dir="ltr">On Mon, Jul 30, 2018 at 2:03 PM Andrew Kelley <<a href="mailto:superjoe30@gmail.com" target="_blank">superjoe30@gmail.com</a>> wrote:<br></div>
<blockquote style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>Ping Rui. Is there anything else that needs to be done on this patch?<br></div>
<div><div><div><br></div>
<div><div>On Tue, Jul 17, 2018 at 6:58 AM, Carlo Kok via llvm-dev <span dir="ltr"><<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>></span> wrote:<br></div>
<blockquote style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div>Got it. <br></div>
<div><br></div>
<div>Attached are both the testcase & the fix. <br></div>
<div><br></div>
<div><div><div><br></div>
<div>On Tue, Jul 17, 2018, at 12:06, Carlo Kok via llvm-dev wrote:<br></div>
<div>> On Wed, Jul 11, 2018, at 16:45, Davide Italiano wrote:<br></div>
<div>> > On Tue, Jul 10, 2018 at 10:12 PM Carlo Kok via llvm-dev<br></div>
<div>> > <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>> wrote:<br></div>
<div>> > ><br></div>
<div>> > > That sounds quite reasaonable; how does one usually go about doing that? a repro zip that hits both asserts?<br></div>
<div>> > ><br></div>
<div>> > <br></div>
<div>> > You can take inspiration from anything in lld/test, but basically<br></div>
<div>> > either an assembly source (or multiple) passed through llvm-mc and<br></div>
<div>> > then lld, or a YAML file passed to yaml2obj (and then lld). >From what<br></div>
<div>> > I see the Mach-O backend prefers YAML-style testing, but I don't think<br></div>
<div>> > that's a strict requirement.<br></div>
<div>> <br></div>
<div>> Doesn't look like the test system works on windows? <br></div>
<div>> <br></div>
<div>> <br></div>
<div>> C:\p\llvm\llvm\tools\lld\test>python c:\p\llvm\llvm-bin32\relwithdebinfo<br></div>
<div>> \bin\llvm-lit.py darwin\darwin-asserts-in-x86_64.ll<br></div>
<div>> llvm-lit.py: C:/p/llvm/llvm\utils\lit\lit\TestingConfig.py:101: fatal: <br></div>
<div>> unable to parse config file 'C:\\p\\llvm\\llvm\\tools\\lld\\test\<br></div>
<div>> \<a href="http://lit.cfg.py" target="_blank">lit.cfg.py</a>', traceback: Traceback (most recent call last):<br></div>
<div>> File "C:/p/llvm/llvm\utils\lit\lit\TestingConfig.py", line 88, in <br></div>
<div>> load_from_path<br></div>
<div>> exec(compile(data, path, 'exec'), cfg_globals, None)<br></div>
<div>> File "C:\p\llvm\llvm\tools\lld\test\<a href="http://lit.cfg.py" target="_blank">lit.cfg.py</a>", line 23, in <module><br></div>
<div>> config.test_format = lit.formats.ShTest(not <br></div>
<div>> llvm_config.use_lit_shell)<br></div>
<div>> AttributeError: 'NoneType' object has no attribute 'use_lit_shell'<br></div>
<div>> <br></div>
</div>
</div>
<div><span>> _______________________________________________<br> > LLVM Developers mailing list<br> > <a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br> > <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br> </span>> Email had 1 attachment:</div>
<div>> + darwin-asserts-in-x86_64.ll<br></div>
<div>> 5k (application/octet-stream)<br></div>
<div><br></div>
<div>_______________________________________________<br></div>
<div>LLVM Developers mailing list<br></div>
<div><a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br></div>
<div><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br></div>
<div><br></div>
</blockquote></div>
</div>
</div>
</div>
</blockquote></div>
</blockquote><div><br></div>
</div>
</blockquote></div>