<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">I had similar gripes with unit testing machine function stuff. I personally would have preferred to create more tests based on a tool like llc rather than pushing more on the unit test side. Anyway I tried to push <a href="https://reviews.llvm.org/D48850" class="">https://reviews.llvm.org/D48850</a> in order to extend llc to be more amenable in the situations we want to test, but it ultimately wasn't accepted.<div class=""><br class=""></div><div class="">- Matthias</div><div class=""><div class=""><div class=""><div class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Jul 2, 2018, at 2:35 PM, Aditya Nandakumar via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html; charset=utf-8" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><div class="">When writing MachineFunction unit tests, I find it quite tedious to verify correctness in C++. I would like to use FileCheck in UnitTests because FileCheck is extremely convenient/robust to verify correctness. In order to do so, I moved most of FileCheck’s implementation into a header (Support/FileCheck.h) and updated FileCheck.cpp to use this.</div><div class=""><br class=""></div><div class="">I ran into this while writing some target agnostic Legalization code in GISel where it’s not possible or extremely inconvenient to use llc.</div><div class="">What do others think of this? I would think there might be non GISel uses for FileCheck in unit tests, but I’m not sure.</div><div class=""><br class=""></div><div class="">Here’s a quick patch for this (<a href="https://reviews.llvm.org/D48850" class="">https://reviews.llvm.org/D48850</a>)</div><div class=""><br class=""></div><div class="">Thanks</div><div class="">Aditya</div><div class=""><br class=""></div></div>_______________________________________________<br class="">LLVM Developers mailing list<br class=""><a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a><br class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev<br class=""></div></blockquote></div><br class=""></div></div></div></div></body></html>