<div dir="ltr">(apologies if you get this twice -- airplane internet isn't much good)<div><br></div><div>I mostly want to make two high level points:</div><div><br></div><div>1) I agree w/ George that relying on assertions to enable debug counters seems acceptable. I understand that the name isn't ... super obvious. But on the flip side, they should only used for debugging the compiler, not for functionality, and in that sense the name makes sense and erasing them when assertions are disabled also makes sense.</div><div><br></div><div>2) I'd really suggest not trying to couple fine grained (in-pass) debug counters with opt-bisect like functionality of pass bisection. I think those are best represented with independent counters. Layers on top of this can move between them for bisection if useful, but I think conflating them would add complexity. I especially think it is useful to first get the basic pass bisection in place for the new PM rather than trying to buildng something new and more fancy. That said, I'm very happy if they still are using the shared debug counters infrastructure.</div></div><br><div class="gmail_quote"><div dir="ltr">On Thu, Jun 14, 2018 at 9:23 PM David A. Greene via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">George Burgess IV <<a href="mailto:george.burgess.iv@gmail.com" target="_blank">george.burgess.iv@gmail.com</a>> writes:<br>
<br>
> It seems reasonable to me to require that assertions are on when you're<br>
> trying to debug the compiler. Not so much to require that the compiler<br>
> itself has been built with `-O0` :)<br>
<br>
Thanks for explaining things. It's a little weird, name-wise, to use<br>
ENABLE_ASSERTIONS to get debug counters but I can see how it would make<br>
sense.<br>
<br>
-David<br>
_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
</blockquote></div>