<div dir="ltr"><div class="gmail_quote"><div>We had already talked about this, so unsurprisingly I'm generally in favor of the direction. Some comments below.</div><div dir="ltr"><br></div><div dir="ltr">On Thu, Jun 7, 2018 at 2:00 AM Fedor Sergeev <<a href="mailto:fedor.sergeev@azul.com">fedor.sergeev@azul.com</a>> wrote:</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
- access through LLVM Context (allows to control life-time and scope <br>
in multi-context execution)<br>
- wrap it into an analysis for easier access from pass managers<br></blockquote><div><br></div><div>Why not simply make it an analysis, and leave LLVM context out?</div><div><br></div><div>Because this is very pass specific, I think it would be substantially cleaner for it to be more specifically based in the pass infrastructure.</div><div><br></div><div>I also think that this can be more cleanly designed by focusing on the new PM. The legacy PM has reasonable solutions for these problems already, and I think the desgin can be made somewhat simpler if we don't have to support both in some way.</div><div><br></div><div>My hope would be that there are two basic "layers" to this. Along side a particular PassManager, we would have an analysis that instruments the running passes. This would just expose the basic API to track and control pass behavior and none of the "business logic".</div><div><br></div><div>Then I would hope that the Passes library can build an instance of this analysis with callbacks (or a type parameter that gets type erased internally) which handles all the business logic.</div><div><br></div><div>I think this will also address the layering issues around IR units because I think that the generic code can use templates to generically lower the IR unit down to something that can be cleanly handled by the Passes library. I think it is generally fine for this layer to rapidly lose strong typing or only have limited typed facilities because this is about instrumenting things and shouldn't be having interesting (non-debug) behavioral effects.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
Details:<br>
1. introduce llvm::PassInstrumentation<br>
<br>
This is the main interface that handles the customization and <br>
provides instrumentation calls<br>
<br>
- resides in IR<br>
- is accessible through LLVMContext::getPassInstrumentation()<br>
(with context owning this object).<br>
<br>
2. every single point of Pass execution in the (new) PassManager(s) <br>
will query<br>
this analysis and run instrumentation call specific to a <br>
particular point.<br>
<br>
Instrumentation points:<br>
<br>
bool BeforePass (PassID, PassExecutionCounter);<br>
void AfterPass (PassID, PassExecutionCounter);<br>
<br>
Run before/after a particular pass execution<br>
BeforePass instrumentation call returns true if this <br>
execution is allowed to run.<br>
<br>
'PassID'<br>
certain unique identifier for a pass (pass name?).<br>
<br>
'PassExecutionCounter'<br>
a number that uniquely identifies this particular pass <br>
execution<br>
in current pipeline, as tracked by Pass Manager.<br>
<br>
void StartPipeline()<br>
void EndPipeline()<br>
<br>
Run at the start/end of a pass pipeline execution.<br>
(useful for initialization/finalization purposes)<br>
<br>
<br>
3. custom callbacks are registered with <br>
PassInstrumentation::register* interfaces<br>
<br>
A sequence of registered callbacks is called at each <br>
instrumentation point as appropriate.<br>
<br>
4. introduce llvm::ExecutionCounter to track execution of passes<br>
<br>
(akin to DebugCounter, yet enabled in Release mode as well?)<br>
<br>
Note: it is somewhat nontrivial to uniquely track pass executions <br>
with counters in new pass<br>
manager as its pipeline schedule can be dynamic. Ideas are welcome <br>
on how to efficiently<br>
implement unique execution tracking that does not break in <br>
presence of fixed-point iteration<br>
passes like RepeatedPass/DevirtSCCRepeatedPass<br>
<br>
Also, the intent is for execution counters to be able provide <br>
thread-safety in multi-threaded<br>
pipeline execution (though no work planned for it yet).<br>
<br>
5. introduce a new analysis llvm::PassInstrumentationAnalysis<br>
<br>
This is a convenience wrapper to provide an access to <br>
PassInstrumentation via analysis framework.<br>
If using analysis is not convenient (?legacy) then <br>
PassInstrumentation can be queried<br>
directly from LLVMContext.<br>
<br>
<br>
Additional goals<br>
================<br>
<br>
- layering problem<br>
Currently OptBisect/OptPassGate has layering issue - interface <br>
dependencies on all the "IR units",<br>
even those that are analyses - Loop, CallGraphSCC.<br>
<br>
Generic PassInstrumentation facilitiy allows to inject arbitrary <br>
call-backs in run-time,<br>
removing any compile-time interface dependencies on internals of <br>
those callbacks,<br>
effectively solving this layering issue.<br>
<br>
- life-time/scope control for multi-context execution<br>
<br>
Currently there are issues with multi-context execution of, say, <br>
-time-passes which store<br>
their data in global maps.<br>
<br>
With LLVMContext owning PassInstrumentation there should be no <br>
problem with multi-context execution<br>
(callbacks can be made owning the instrumentation data).<br>
<br>
Open Questions<br>
==============<br>
<br>
- whats the best way to handle ownership of PassInstrumentation<br>
<br>
Any problems with owning by LLVMContext?<br>
Something similar to TargetLibraryInfo (owned by <br>
TargetLibraryAnalysis/TargetLibraryInfoWrapperPass)?<br>
<br>
- using PassInstrumentationAnalysis or directly querying LLVMContext<br>
<br>
PassInstrumentationAnalysis appeared to be a nice idea, only until <br>
I tried querying it<br>
in new pass manager framework, and amount of hooplas to jump over <br>
makes me shiver a bit...<br>
<br>
Querying LLVMContext is plain and straightforward, but we do not <br>
have a generic way to access LLVMContext<br>
from a PassManager template (need to introduce generic <br>
IRUnit::getContext?)<br>
<br>
Implementation<br>
==============<br>
<br>
PassInstrumentationAnalysis proof-of-concept unfinished prototype <br>
implementation:<br>
(Heavily under construction, do not enter without wearing a hard hat...)<br>
<br>
<a href="https://reviews.llvm.org/D47858" rel="noreferrer" target="_blank">https://reviews.llvm.org/D47858</a><br>
<br>
</blockquote></div></div>