<div dir="ltr"><div>On Tue, Jun 5, 2018 at 8:52 AM <<a href="mailto:paul.robinson@sony.com">paul.robinson@sony.com</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-US" link="blue" vlink="purple">
<div class="m_-6868624217434768180WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">There are some already, I have been caught out by that before on compiler changes; maybe one could have LLD added to their list of projects.</span></p></div></div></blockquote><div><br></div><div>That sounds like a very good plan!</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div lang="EN-US" link="blue" vlink="purple"><div class="m_-6868624217434768180WordSection1"><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u><u></u></span></p>
<p class="MsoNormal"><a name="m_-6868624217434768180__MailEndCompose"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">--paulr<u></u><u></u></span></a></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> llvm-dev [mailto:<a href="mailto:llvm-dev-bounces@lists.llvm.org" target="_blank">llvm-dev-bounces@lists.llvm.org</a>]
<b>On Behalf Of </b>Rui Ueyama via llvm-dev<br>
<b>Sent:</b> Tuesday, June 05, 2018 11:48 AM<br>
<b>To:</b> Peter Smith<br>
<b>Cc:</b> llvm-dev; <a href="mailto:joelkevinjones@gmail.com" target="_blank">joelkevinjones@gmail.com</a><br>
<b>Subject:</b> Re: [llvm-dev] [LLD] Lack of REQUIRES causing test failures when not building with x86 support<u></u><u></u></span></p>
</div>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div>
<p class="MsoNormal">In order to catch a missing "REQUIRES: x86", it might be a good idea to set up a build bot without the x86 support.<u></u><u></u></p>
</div>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div>
<p class="MsoNormal">On Mon, Jun 4, 2018 at 8:53 AM Peter Smith via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>> wrote:<u></u><u></u></p>
</div>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal">Hello Joel,<br>
<br>
I don't think that there is a cunning plan with REQUIRES. I seem to<br>
remember that there was some debate over the testing strategy and<br>
platforms, but unfortunately I can't quickly find a link to it. In<br>
summary:<br>
- Much of the functionality of LLD is target independent, for example<br>
linker script support.<br>
- To write a test needs us to pick a target for these types of test<br>
and X86 was chosen as this was the most likely target to be compiled<br>
into build machines, for example the Arm and AArch64 buildbots include<br>
the X86 backend.<br>
<br>
I think that the missing 117 "REQUIRES" are an oversight, or<br>
historical artefact, and I think patches would be welcome to add them<br>
back in; a bot that doesn't build in the X86 backend is probably<br>
needed to keep this maintained as it is easy to forget the REQUIRES.<br>
However I think that if the goal is to test the majority of the<br>
functionality of LLD it would be wise to compile in support for X86 as<br>
much of the generic functionality will go untested.<br>
<br>
Peter<br>
<br>
On 4 June 2018 at 15:49, Joel Jones via llvm-dev<br>
<<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>> wrote:<br>
> If I build lld without x86 support (i.e. with "cmake -DLLVM_TARGETS_TO_BUILD=AArch64”) there are 117 tests that fail “make check-lld”. Upon examination, all are x86 related.<br>
><br>
> There are multiple (884) tests that have “REQUIRES:.*x86” in the tests directory. Was there a cunning plan regarding the use of REQUIRES that I couldn’t discern?<br>
><br>
> It seems that either 117 “REQUIRES” need to be added or 884 need to be removed.<br>
><br>
> Joel Jones<br>
> _______________________________________________<br>
> LLVM Developers mailing list<br>
> <a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" target="_blank">
http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><u></u><u></u></p>
</blockquote>
</div>
</div>
</div>
</div>
</blockquote></div></div>