<div dir="ltr">Sorry, operator error. I can reproduce now. Interestingly, this does not reproduce using gold, and they utilize the same underlying LTO API. Let me dig a little using save-temps and see where they diverge.<br><div>Teresa</div></div><br><div class="gmail_quote"><div dir="ltr">On Wed, May 9, 2018 at 9:28 AM Pirama Arumuga Nainar <<a href="mailto:pirama@google.com">pirama@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">LLD revision is r331862. To add, I had initially tried it on r328903, which also reproduced the issue.</div><br><div class="gmail_quote"><div dir="ltr">On Wed, May 9, 2018 at 9:26 AM Pirama Arumuga Nainar <<a href="mailto:pirama@google.com" target="_blank">pirama@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Teresa,<div><br></div><div>Thanks for looking into this. I hadn't initially tried ToT, but it reproduces in ToT as well when I tried.</div><div><br></div><div><pre id="m_-6213466112148886259m_5408140560637564606gmail-hterm:copy-to-clipboard-source" style="font-size:13px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;color:rgb(0,0,0)">$ ./clang --version
</pre><pre id="m_-6213466112148886259m_5408140560637564606gmail-hterm:copy-to-clipboard-source" style="color:rgb(0,0,0);font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;word-spacing:0px;text-decoration-style:initial;text-decoration-color:initial">clang version 7.0.0 (trunk 331879) (llvm/trunk 331888)
Target: x86_64-unknown-linux-gnu
Thread model: posix
InstalledDir: /ssd2/pirama/llvm-upstream/llvm-release/bin/.</pre><pre id="m_-6213466112148886259m_5408140560637564606gmail-hterm:copy-to-clipboard-source" style="color:rgb(0,0,0);font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;word-spacing:0px;text-decoration-style:initial;text-decoration-color:initial">$ ./ld.lld --version
LLD 7.0.0 (<a href="https://git.llvm.org/git/lld.git" target="_blank">https://git.llvm.org/git/lld.git</a> dc4977e104c7f33758ac6119d1528aafcd8a94dc) (compatible with GNU linkers)</pre></div></div><br><div class="gmail_quote"><div dir="ltr">On Wed, May 9, 2018 at 6:44 AM Teresa Johnson <<a href="mailto:tejohnson@google.com" target="_blank">tejohnson@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Wed, May 9, 2018 at 6:43 AM Teresa Johnson <<a href="mailto:tejohnson@google.com" target="_blank">tejohnson@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Pirama,<br><div><br></div><div>I can't reproduce with either lld or gold, using a compiler built from head. What version is your clang?</div></div></blockquote><div>(and your lld)</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><br></div><div>Thanks,</div><div>Teresa</div></div><br><div class="gmail_quote"><div dir="ltr">On Tue, May 8, 2018 at 7:50 PM Pirama Arumuga Nainar via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">The duplicate symbol errors are for <span style="color:rgb(34,34,34);font-family:sans-serif;font-size:13px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">__llvm_profile_filename and <span style="color:rgb(34,34,34);font-family:sans-serif;font-size:13px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">__llvm_profile_raw_version. IIUC, these are supposed to be weak symbols but Thin LTO seems to break this in some way. </span></span>This does't happen with gold or no LTO or full LTO.<div><br></div><div>$ cat > a.c</div><div><div>extern int foo();</div><div><br></div><div>int main() {</div><div> return foo();</div><div>}</div></div><div><br></div><div>$ cat > b.c</div><div><div>int foo() {</div><div> return 0;</div><div>}</div></div><div><br>$ clang a.c -fprofile-generate -flto=thin -c</div><div>$ clang b.c -fprofile-generate -flto=thin -c</div><div>$ clang a.o b.o -fprofile-generate -flto=thin -fuse-ld=lld</div><div>ld.lld: error: duplicate symbol: __llvm_profile_filename</div><div>>>> defined at a.c</div><div>>>> lto.tmp:(__llvm_profile_filename)</div><div>>>> defined at b.c</div><div>>>> lto.tmp:(.rodata.__llvm_profile_filename+0x0)</div><div><br></div><div>ld.lld: error: duplicate symbol: __llvm_profile_raw_version</div><div>>>> defined at a.c</div><div>>>> lto.tmp:(__llvm_profile_raw_version)</div><div>>>> defined at b.c</div><div>>>> lto.tmp:(.rodata.__llvm_profile_raw_version+0x0)</div><div>clang-7: error: linker command failed with exit code 1 (use -v to see invocation)</div><div>Makefile:10: recipe for target 'a.out' failed</div><div>make: *** [a.out] Error 1</div></div>
_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="m_-6213466112148886259m_5408140560637564606m_6765173187228408672m_-1099755374332112270gmail_signature" data-smartmail="gmail_signature"><span style="font-family:Times;font-size:medium"><table cellspacing="0" cellpadding="0"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small"><td style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Teresa Johnson |</td><td style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td><td style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tejohnson@google.com" target="_blank">tejohnson@google.com</a> |</td><td style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"> 408-460-2413</td></tr></tbody></table></span></div></blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="m_-6213466112148886259m_5408140560637564606m_6765173187228408672gmail_signature" data-smartmail="gmail_signature"><span style="font-family:Times;font-size:medium"><table cellspacing="0" cellpadding="0"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small"><td style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Teresa Johnson |</td><td style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td><td style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tejohnson@google.com" target="_blank">tejohnson@google.com</a> |</td><td style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"> 408-460-2413</td></tr></tbody></table></span></div></div>
</blockquote></div></blockquote></div>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><span style="font-family:Times;font-size:medium"><table cellspacing="0" cellpadding="0"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small"><td style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Teresa Johnson |</td><td style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td><td style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tejohnson@google.com" target="_blank">tejohnson@google.com</a> |</td><td style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"> 408-460-2413</td></tr></tbody></table></span></div>