<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">It's probably worth going into a little
more detail... a lot of people read llvmdev, and most of them
won't click the link or follow the whole discussion.<br>
<br>
The transform in question is replacing "fputc(...)" with
"fputc_unlocked(...)" when we can prove the FILE* doesn't escape.
The question is whether it's safe for the compiler to emit a call
to fputc_unlocked() on Linux, given it's a non-standard
extension. The bit I'm most worried about is some user defining a
function named fputc_unlocked; it isn't a reserved name according
to the C standard, so there's no way to ensure we're actually
calling the glibc fputc_unlocked.<br>
<br>
Suggestions welcome.<br>
<br>
-Eli<br>
<br>
On 5/8/2018 4:59 PM, Dávid Bolvanský via llvm-dev wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CAOrgDVPiRyqUh8ZD+BtqWBXq-9byF17TNGwg6vzFEbO5bbj5wg@mail.gmail.com">
<div dir="ltr">Hello,
<div><br>
</div>
<div>Please check this patch:</div>
<div><a href="https://reviews.llvm.org/D45736"
moz-do-not-send="true">https://reviews.llvm.org/D45736</a><br>
</div>
<div><br>
</div>
<div>as Eli noted, other opinions are highly welcomed..</div>
<div><br>
</div>
<div>Thanks</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
LLVM Developers mailing list
<a class="moz-txt-link-abbreviated" href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a>
<a class="moz-txt-link-freetext" href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a>
</pre>
</blockquote>
<p><br>
</p>
<pre class="moz-signature" cols="72">--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project</pre>
</body>
</html>