<div dir="ltr">DebugInfoCodeView is nto strictly a consumer, it is also a producer.</div><br><div class="gmail_quote"><div dir="ltr">On Wed, Mar 21, 2018 at 1:29 PM <<a href="mailto:paul.robinson@sony.com">paul.robinson@sony.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-US" link="blue" vlink="purple">
<div class="m_1496139230352083910WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Intuitively I'd think MC and DebugInfo should be independent. MC is a producer, DebugInfo is a consumer. What's common is the definition of the structures
they operate on, which doesn't properly belong to either one.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">--paulr<u></u><u></u></span></p>
<p class="MsoNormal"><a name="m_1496139230352083910__MailEndCompose"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></a></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> llvm-dev [mailto:<a href="mailto:llvm-dev-bounces@lists.llvm.org" target="_blank">llvm-dev-bounces@lists.llvm.org</a>]
<b>On Behalf Of </b>David Blaikie via llvm-dev<br>
<b>Sent:</b> Wednesday, March 21, 2018 11:52 AM<br>
<b>To:</b> Zachary Turner<br>
<b>Cc:</b> llvm-dev<br>
<b>Subject:</b> Re: [llvm-dev] CodeView layering<u></u><u></u></span></p>
</div>
</div></div></div></div><div lang="EN-US" link="blue" vlink="purple"><div class="m_1496139230352083910WordSection1"><div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">Someone internally's been dabbling with turning on some of Google's build system's stricter header checking modes - and they caught these (you can check the internal code review 184305506 for the original where I'm pulling things out from).<br>
<br>
& yeah, fair question about the modules builds - I don't fully understand what they catch and don't catch. I suspect it's a matter of whether the headers themselves form a cycle - whereas the Google build system's a bit more structured - knowing about libraries
and explicit dependencies between them.<br>
<br>
& I didn't look closely to see if, as I said, MC could depend on DebugInfoCodeView - probably weird/awkward/not what we want (I'm guessing?) but the modules buildbots don't have explicit dependencies, they just fail when they find a cycle. So they can implicitly
support all sorts of weird dependencies we might not've expected/planned, so long as it's not an actual cycle (& only within the headers - so the modules system might be like "oh, sure, MC can depend on DebugInfoCodeView" but the library dependency might be
the exact opposite (some MC .cpp file could call into DebugInfoCodeView & the modules build wouldn't fail - it knows nothing about .cpp modularity/grouping, just headers))<u></u><u></u></p>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div>
<p class="MsoNormal">On Wed, Mar 21, 2018 at 11:42 AM Zachary Turner <<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>> wrote:<u></u><u></u></p>
</div>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<div>
<p class="MsoNormal">Yes, some of the headers and stuff that are just raw structure definitions and enums could probably be sunk into BinaryFormat..<u></u><u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">How'd you find this? Curious why it hasn't been breaking in modules builds for a long time.<u></u><u></u></p>
</div>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div>
<p class="MsoNormal">On Wed, Mar 21, 2018 at 11:31 AM David Blaikie <<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>> wrote:<u></u><u></u></p>
</div>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt">I'm looking at fixing some layering violations in LLVM & came across a few in the CodeView handling, specifically:<br>
<br>
lib/MC/MCCodeView includes several llvm/DebugInfo/CodeView headers<br>
I guess MC could be made dependent on DebugInfoCodeView? But probably these things should be sunk into BinaryFormat as is the case for DWARF features used by MC?<u></u><u></u></p>
<div>
<p class="MsoNormal">include/llvm/Object/COFF.h includes include/llvm/DebugInfo/CodeView/CVDebugRecord.h<br>
Also seems like this could/should/needs to be sunk into BinaryFormat?<br>
<br>
I'm open to ideas & happy to do the work, or help in any way that might be useful.<br>
<br>
Thanks,<br>
- Dave<u></u><u></u></p>
</div>
</div>
</blockquote>
</div>
</blockquote>
</div>
</div></div></div></blockquote></div>