<div dir="ltr">Ha, that's a good timing!<div><br></div><div>Thank you for comments, I'll address them on phabricator.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Feb 28, 2018 at 5:06 AM, Florian Hahn <span dir="ltr"><<a href="mailto:florian.hahn@arm.com" target="_blank">florian.hahn@arm.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<span class=""><br>
<br>
On 27/02/2018 16:32, Daniel Berlin via llvm-dev wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I think you realized this now, but to be clear:<br>
More likely, you've found some bugs.<br>
Unfortunately, not all of these utilities have good unit tests (though they should!).<br>
<br>
This would not be the first set of bugs people have found wrt to very start/end of blocks, or bb == predbb issues.<br>
<br>
</blockquote>
<br></span>
Coincidentally I stumbled over a similar issue with bb == predbb in DuplicateInstructionsInSplitBe<wbr>tween too and put up a patch trying to fix it <a href="https://reviews.llvm.org/D43822" rel="noreferrer" target="_blank">https://reviews.llvm.org/D4382<wbr>2</a><br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">
<br>
On Sat, Feb 24, 2018 at 12:58 PM, Fedor Indutny via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a> <mailto:<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.or<wbr>g</a>>> wrote:<br>
<br>
    Update:<br>
<br>
    I was able to make progress on it today ( See<br></span>
    <a href="https://reviews.llvm.org/D43729" rel="noreferrer" target="_blank">https://reviews.llvm.org/D4372<wbr>9</a> <<a href="https://reviews.llvm.org/D43729" rel="noreferrer" target="_blank">https://reviews.llvm.org/D437<wbr>29</a>> ).<br>
    Apparently my problems were:<br>
<br>
</blockquote>
<br>
Great, thanks for putting up a patch for that. It made good progress already and I left a few more comments directly over there.<br>
<br>
<br>
<br>
Cheers,<br>
Florian<br>
</blockquote></div><br></div>