<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Jan 3, 2018, at 9:40 AM, Adrian Prantl via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br class="Apple-interchange-newline"><br class=""><blockquote type="cite" class=""><div class="">On Jan 2, 2018, at 11:31 AM, Christoph Kindl via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="" style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;"><div class="">Hi,</div><div class=""><br class=""></div><div class=""><blockquote type="cite" class="">Date: Sat, 30 Dec 2017 09:59:56 -0600<br class="">From: Krzysztof Parzyszek via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a>><br class="">To: <a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a><br class="">Subject: Re: [llvm-dev] Submitting patches for LLVM -- llvm-commits<br class=""><span class="Apple-tab-span" style="white-space: pre;"> </span>vs. Phabricator?<br class=""><br class="">Hi,<br class="">The current practice is to upload a patch to phabricator and add <br class="">llvm-commits as a subscriber. This will send an email to the mailing <br class="">list. You can (and should) add some reviewers too.<br class=""><br class="">-Krzysztof</blockquote></div><br class=""><div class=""><blockquote type="cite" class=""><div class="">On 31 Dec 2017, at 04:49, Shoaib Meenai wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="WordSection1" style="page: WordSection1; font-variant-caps: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: rgb(255, 255, 255);"><div class="" style="margin: 0in 0in 0.0001pt;">Yup, Phabricator is generally preferred for patches.<o:p class=""></o:p></div><div class="" style="margin: 0in 0in 0.0001pt;"><o:p class=""> </o:p></div><div class="" style="margin: 0in 0in 0.0001pt;">Additionally, are you subscribed to the mailing list? I can't find where I read it now, but I believe your messages are held for moderation if you aren't subscribed. You can subscribe at <a href="http://lists.llvm.org/mailman/listinfo/llvm-commits" class="" style="color: purple; text-decoration: underline;">http://lists.llvm.org/mailman/listinfo/llvm-commits</a><span class="Apple-converted-space"> </span>if needed.</div></div></div></blockquote><div class=""><br class=""></div><div class="">Thanks guys! This is my first attempt to submit a patch; I've sent it to llvm-commits because the Developer Guide mentions this as preferred method:</div><div class=""><br class=""></div><div class=""><blockquote type="cite" class="">Once your patch is ready, submit it by<span class="Apple-converted-space"> </span><b class="">emailing it to the appropriate project’s commit mailing list</b><span class="Apple-converted-space"> </span>(or commit it directly if applicable). Alternatively, some patches get sent to the project’s development list or component of the LLVM bug tracker,<span class="Apple-converted-space"> </span><b class="">but the commit list is the primary place for reviews and should generally be preferred.</b></blockquote><div class=""><br class=""></div>I guess this part should be updated then to mention Phabricator as the primary place for submitting and reviewing patches?</div></div></div></div></blockquote><div class=""><br class=""></div><div class="">Would you mind updating the section and uploading the patch to<span class="Apple-converted-space"> </span><a href="http://reviews.llvm.org/" class="">reviews.llvm.org</a><span class="Apple-converted-space"> </span>:-) ?</div><div class="">-- adrian</div></div></div></blockquote><div><br class=""></div><div>AFAIK, last time we discussed this, the consensus was that the llvm-commits mailing list is the authoritative place for patches and using phabricator (which then produces posts for the mailing list) is considered optional.</div><div><br class=""></div><div>In practice of course there is only a handful of people posting to the mailing list directly without using phabricator, so I guess changing the docu is fine :)</div><div><br class=""></div><div>- Matthias</div></div></body></html>