<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">Hi,</div><div class=""><br class=""></div><div class=""><blockquote type="cite" class="">Date: Sat, 30 Dec 2017 09:59:56 -0600<br class="">From: Krzysztof Parzyszek via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a>><br class="">To: <a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a><br class="">Subject: Re: [llvm-dev] Submitting patches for LLVM -- llvm-commits<br class=""><span class="Apple-tab-span" style="white-space: pre;"> </span>vs. Phabricator?<br class=""><br class="">Hi,<br class="">The current practice is to upload a patch to phabricator and add <br class="">llvm-commits as a subscriber. This will send an email to the mailing <br class="">list. You can (and should) add some reviewers too.<br class=""><br class="">-Krzysztof</blockquote></div><br class=""><div><blockquote type="cite" class=""><div class="">On 31 Dec 2017, at 04:49, Shoaib Meenai wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="WordSection1" style="page: WordSection1; font-variant-caps: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: rgb(255, 255, 255);"><div style="margin: 0in 0in 0.0001pt;" class="">Yup, Phabricator is generally preferred for patches.<o:p class=""></o:p></div><div style="margin: 0in 0in 0.0001pt;" class=""><o:p class=""> </o:p></div><div style="margin: 0in 0in 0.0001pt;" class="">Additionally, are you subscribed to the mailing list? I can't find where I read it now, but I believe your messages are held for moderation if you aren't subscribed. You can subscribe at <a href="http://lists.llvm.org/mailman/listinfo/llvm-commits" style="color: purple; text-decoration: underline;" class="">http://lists.llvm.org/mailman/listinfo/llvm-commits</a><span class="Apple-converted-space"> </span>if needed.</div></div></div></blockquote><div><br class=""></div><div>Thanks guys! This is my first attempt to submit a patch; I've sent it to llvm-commits because the Developer Guide mentions this as preferred method:</div><div><br class=""></div><div><blockquote type="cite" class="">Once your patch is ready, submit it by <b class="">emailing it to the appropriate project’s commit mailing list</b> (or commit it directly if applicable). Alternatively, some patches get sent to the project’s development list or component of the LLVM bug tracker, <b class="">but the commit list is the primary place for reviews and should generally be preferred.</b></blockquote><div><br class=""></div>I guess this part should be updated then to mention Phabricator as the primary place for submitting and reviewing patches?</div><div><br class=""></div><div>I'm subscribed to llvm-commits yes (in digest mode if that should make a difference), but the message was not submitted to the list (it seems to be still in the queue waiting for moderator approval). Anyhow, I will submit my little patch via Phabricator then and refer to the Phabricator docs for procedere and finding reviewers. Thanks!</div><div><br class=""></div><div>BR,</div><div>Chris</div><br class=""><blockquote type="cite" class=""><div class=""><div class="WordSection1" style="page: WordSection1; font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: rgb(255, 255, 255);"><div style="border-style: solid none none; border-top-color: rgb(181, 196, 223); border-top-width: 1pt; padding: 3pt 0in 0in;" class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><b class=""><span style="font-size: 12pt;" class="">From:<span class="Apple-converted-space"> </span></span></b><span style="font-size: 12pt;" class="">llvm-dev <<a href="mailto:llvm-dev-bounces@lists.llvm.org" style="color: purple; text-decoration: underline;" class="">llvm-dev-bounces@lists.llvm.org</a>> on behalf of Christoph Kindl via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" style="color: purple; text-decoration: underline;" class="">llvm-dev@lists.llvm.org</a>><br class=""><b class="">Reply-To:<span class="Apple-converted-space"> </span></b>Christoph Kindl <<a href="mailto:mail@ckristo.net" style="color: purple; text-decoration: underline;" class="">mail@ckristo.net</a>><br class=""><b class="">Date:<span class="Apple-converted-space"> </span></b>Saturday, December 30, 2017 at 7:22 PM<br class=""><b class="">To:<span class="Apple-converted-space"> </span></b>"<a href="mailto:llvm-dev@lists.llvm.org" style="color: purple; text-decoration: underline;" class="">llvm-dev@lists.llvm.org</a>" <<a href="mailto:llvm-dev@lists.llvm.org" style="color: purple; text-decoration: underline;" class="">llvm-dev@lists.llvm.org</a>><br class=""><b class="">Subject:<span class="Apple-converted-space"> </span></b>[llvm-dev] Submitting patches for LLVM -- llvm-commits vs. Phabricator?<o:p class=""></o:p></span></div></div><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><o:p class=""> </o:p></div></div><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">Hi,<o:p class=""></o:p></div></div><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><o:p class=""> </o:p></div></div><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">I've recently submitted a patch to llvm-commits (as requested by<a href="https://llvm.org/docs/DeveloperPolicy.html#making-and-submitting-a-patch" style="color: purple; text-decoration: underline;" class="">https://llvm.org/docs/DeveloperPolicy.html#making-and-submitting-a-patch</a>) and the mailing list answered with a notice that my message is held for moderator approval (with the reason: "Post by non-member to a members-only list"). I'm therefore wondering if I should've submitted my patch via Phabricator instead (looking at the activity in llvm-commits, it seems that most of the patches are submitted and reviewed by Phabricator).<o:p class=""></o:p></div></div><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><o:p class=""> </o:p></div></div><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">Best regards,<o:p class=""></o:p></div></div><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">Chris<o:p class=""></o:p></div></div><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><o:p class=""> </o:p></div></div><div class=""><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><o:p class=""> </o:p></div></div></div></div></blockquote></div><br class=""></body></html>