
<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Unless there are still open issues with your patch, or our internal bots point to problems, I think time has come to flip the switch.<div class=""><br class=""></div><div class="">Thanks</div><div class="">Gerolf<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Dec 18, 2017, at 11:14 AM, Amara Emerson via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html; charset=utf-8" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">FYI all: the patch to enable it is available to review here: <a href="https://reviews.llvm.org/D41362" class="">https://reviews.llvm.org/D41362</a><div class=""><br class=""></div><div class="">Thanks,</div><div class="">Amara<br class=""><div class=""><br class=""><blockquote type="cite" class=""><div class="">On Dec 18, 2017, at 5:44 PM, Amara Emerson via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html; charset=utf-8" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Ok. We’ll look at what we can do to further stress test it in the next two months, additional suggestions from the community is welcome. Patch should be incoming to enable it later today.<div class=""><br class=""></div><div class="">Thanks,</div><div class="">Amara<br class=""><div class=""><br class=""><blockquote type="cite" class=""><div class="">On Dec 18, 2017, at 3:25 PM, Kristof Beyls <<a href="mailto:Kristof.Beyls@arm.com" class="">Kristof.Beyls@arm.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div style="font-family: SFHello-Regular; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><blockquote type="cite" class=""><div class=""><br class="Apple-interchange-newline">On 18 Dec 2017, at 15:11, Amara Emerson <<a href="mailto:aemerson@apple.com" class="">aemerson@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="" style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;"><div class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Dec 18, 2017, at 12:37 PM, Kristof Beyls <<a href="mailto:Kristof.Beyls@arm.com" class="">Kristof.Beyls@arm.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="" style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;"><div dir="auto" class="" style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;"><div dir="auto" class="" style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;">Hi Amara,<div class=""><br class=""></div><div class="">My reasons for preferring the switch to happen after the release branch is based on the following observations:</div><div class=""><ul class=""><li class="">As far as I can see, the projects and products following top-of-trunk tend to test much more extensively than the testing that happens for<span class="Apple-converted-space"> </span><a href="http://llvm.org/" class="">llvm.org</a><span class="Apple-converted-space"> </span>releases. I expect that the<span class="Apple-converted-space"> </span><a href="http://llvm.org/" class="">llvm.org</a><span class="Apple-converted-space"> </span>release testing won’t find potential remaining issues, whereas the projects and products following trunk are far more likely to find remaining issues with GlobalISel. Therefore, I think it’s best to give as much time as possible for these projects/products following top-of-trunk to find issues before there’s an<span class="Apple-converted-space"> </span><a href="http://llvm.org/" class="">llvm.org</a> release with GlobalISel enabled-by-default.</li><li class="">For the projects and products that follow top-of-trunk that I know off, if globalisel-by-default would really break things, it’s possible to disable it within that project/product without end users of it needing to know about this. If for the<span class="Apple-converted-space"> </span><a href="http://llvm.org/" class="">llvm.org</a> release it would turn out that globalisel has a big issue after release, we’d need to somehow let all users of the release know to disable it by adding a convoluted command line option (‘-mllvm -global-isel=0’?)</li></ul></div><div class="">Combining the 2 observations above, I think it’s better to do the switch shortly after a release branch is taken, rather than just before it.</div><div class=""><br class=""></div></div></div></div></div></blockquote>I wasn’t suggesting that we proceed with the full release with GISel enabled by default if there are serious issues, I was more saying that we have additional time during the RC period to test further on trunk, and then merge in fixes into the RC. Worst case is that we back out the change completely but I doubt it’ll get to that stage. I do agree that trunk sees more of the testing coverage. If one month isn’t enough, what would have been the cut off point?<div class=""><br class=""></div><div class="">Thanks,</div><div class="">Amara</div></div></div></div></div></blockquote><br class=""></div><div style="font-family: SFHello-Regular; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">Yeah, I agree that the time needed before the next release happens when switching is debatable.</div><div style="font-family: SFHello-Regular; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; orphans: 2; widows: 2;" class="">After looking it up, I see that the final release tag is planned for no earlier than <span class="" style="orphans: 2; widows: 2; background-color: rgb(255, 255, 255);"><font color="#222222" class="">21 February 2018, so we’d indeed have a bit of time to revert it on the release branch if serious issues were discovered.</font></span></div><div style="font-family: SFHello-Regular; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; orphans: 2; widows: 2;" class=""><span class="" style="color: rgb(34, 34, 34); background-color: rgb(255, 255, 255);">Seeing the actual release date is that far out, I don’t have strong objections to flipping the switch now if others want to press on with it.</span></div><div style="font-family: SFHello-Regular; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; orphans: 2; widows: 2;" class=""><span class="" style="orphans: 2; widows: 2; background-color: rgb(255, 255, 255);"><font color="#222222" class=""><br class=""></font></span></div><div style="font-family: SFHello-Regular; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; orphans: 2; widows: 2;" class=""><span class="" style="orphans: 2; widows: 2; background-color: rgb(255, 255, 255);"><font color="#222222" class="">Thanks,</font></span></div><div style="font-family: SFHello-Regular; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; orphans: 2; widows: 2;" class=""><span class="" style="orphans: 2; widows: 2; background-color: rgb(255, 255, 255);"><font color="#222222" class=""><br class=""></font></span></div><div style="font-family: SFHello-Regular; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; orphans: 2; widows: 2;" class=""><span class="" style="orphans: 2; widows: 2; background-color: rgb(255, 255, 255);"><font color="#222222" class="">Kristof</font></span></div></div></blockquote></div><br class=""></div></div>_______________________________________________<br class="">LLVM Developers mailing list<br class=""><a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a><br class=""><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br class=""></div></blockquote></div><br class=""></div></div>_______________________________________________<br class="">LLVM Developers mailing list<br class=""><a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a><br class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev<br class=""></div></blockquote></div><br class=""></div></body></html>