<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">
<br class="">
<div>
<blockquote type="cite" class="">
<div class="">On 18 Dec 2017, at 15:11, Amara Emerson <<a href="mailto:aemerson@apple.com" class="">aemerson@apple.com</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<div style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">
<div class=""><br class="">
<div class="">
<blockquote type="cite" class="">
<div class="">On Dec 18, 2017, at 12:37 PM, Kristof Beyls <<a href="mailto:Kristof.Beyls@arm.com" class="">Kristof.Beyls@arm.com</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">
<div dir="auto" style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">
<div dir="auto" style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">
Hi Amara,
<div class=""><br class="">
</div>
<div class="">My reasons for preferring the switch to happen after the release branch is based on the following observations:</div>
<div class="">
<ul class="">
<li class="">As far as I can see, the projects and products following top-of-trunk tend to test much more extensively than the testing that happens for
<a href="http://llvm.org/" class="">llvm.org</a> releases. I expect that the <a href="http://llvm.org/" class="">
llvm.org</a> release testing won’t find potential remaining issues, whereas the projects and products following trunk are far more likely to find remaining issues with GlobalISel. Therefore, I think it’s best to give as much time as possible for these projects/products
following top-of-trunk to find issues before there’s an <a href="http://llvm.org/" class="">
llvm.org</a> release with GlobalISel enabled-by-default.</li><li class="">For the projects and products that follow top-of-trunk that I know off, if globalisel-by-default would really break things, it’s possible to disable it within that project/product without end users of it needing to know about this. If for the
<a href="http://llvm.org/" class="">llvm.org</a> release it would turn out that globalisel has a big issue after release, we’d need to somehow let all users of the release know to disable it by adding a convoluted command line option (‘-mllvm -global-isel=0’?)</li></ul>
</div>
<div class="">Combining the 2 observations above, I think it’s better to do the switch shortly after a release branch is taken, rather than just before it.</div>
<div class=""><br class="">
</div>
</div>
</div>
</div>
</div>
</blockquote>
I wasn’t suggesting that we proceed with the full release with GISel enabled by default if there are serious issues, I was more saying that we have additional time during the RC period to test further on trunk, and then merge in fixes into the RC. Worst case
is that we back out the change completely but I doubt it’ll get to that stage. I do agree that trunk sees more of the testing coverage. If one month isn’t enough, what would have been the cut off point?
<div class=""><br class="">
</div>
<div class="">Thanks,</div>
<div class="">Amara</div>
</div>
</div>
</div>
</div>
</blockquote>
<br class="">
</div>
<div>Yeah, I agree that the time needed before the next release happens when switching is debatable.</div>
<div style="orphans: 2; widows: 2;">After looking it up, I see that the final release tag is planned for no earlier than <span style="orphans: 2; widows: 2; background-color: rgb(255, 255, 255);" class=""><font color="#222222" class="">21 February 2018, so
we’d indeed have a bit of time to revert it on the release branch if serious issues were discovered.</font></span></div>
<div style="orphans: 2; widows: 2;"><span style="color: rgb(34, 34, 34); background-color: rgb(255, 255, 255);" class="">Seeing the actual release date is that far out, I don’t have strong objections to flipping the switch now if others want to press on with
it.</span></div>
<div style="orphans: 2; widows: 2;"><span style="orphans: 2; widows: 2; background-color: rgb(255, 255, 255);" class=""><font color="#222222" class=""><br class="">
</font></span></div>
<div style="orphans: 2; widows: 2;"><span style="orphans: 2; widows: 2; background-color: rgb(255, 255, 255);" class=""><font color="#222222" class="">Thanks,</font></span></div>
<div style="orphans: 2; widows: 2;"><span style="orphans: 2; widows: 2; background-color: rgb(255, 255, 255);" class=""><font color="#222222" class=""><br class="">
</font></span></div>
<div style="orphans: 2; widows: 2;"><span style="orphans: 2; widows: 2; background-color: rgb(255, 255, 255);" class=""><font color="#222222" class="">Kristof</font></span></div>
</body>
</html>