<div dir="ltr">By the way, have you tried -fmodules ?<div><br></div><div>Takumi<br><br><div class="gmail_quote"><div dir="ltr">On Wed, Dec 6, 2017 at 1:41 PM Mikhail Zolotukhin via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">Hi,<div><br></div><div>Recently I've done some experiments on the LLVM/Clang code and discovered that many of our source files often include unnecessary header files. I wrote a simple tool that eliminates redundant includes and estimates benefits of doing it, and the results were quite nice: for some files we were able to save 90% of compile time! I think we want to apply some of the cleanups I found, but I'm not sure how to better do it: the total patches are 8k lines of code for LLVM and 3k lines of code for clang (I'll attach them for reference). My suggestion would be that people take a look at the list of changed files and pick the changes for the piece of code they are working on if the changes look sane (the changes do need some checking before committing). Does it sound like a good idea? I'd appreciate any feedback on what can we do here.</div><div><br></div><div>The list of files for which removing redundant headers improved compile time (the numbers are compile time in seconds for a Debug build):</div><div><b><br></b></div><div><b>LLVM top 10</b></div><div><div><font face="Menlo" style="font-size:11px"><b><u>Filename<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>Old<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>New<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>Delta</u></b></font></div><div><font face="Menlo" style="font-size:11px">lib/CodeGen/GlobalISel/GlobalISel.cpp<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>0.26<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>0.02<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>-91.9%</font></div><div><font face="Menlo" style="font-size:11px">lib/MC/MCLabel.cpp<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>0.19<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>0.02<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>-88.2%</font></div><div><font face="Menlo" style="font-size:11px">tools/llvm-readobj/ObjDumper.cpp<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>0.43<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>0.10<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>-76.5%</font></div><div><font face="Menlo" style="font-size:11px">lib/MC/MCWinEH.cpp<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>0.51<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>0.13<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>-74.3%</font></div><div><font face="Menlo" style="font-size:11px">lib/Transforms/Vectorize/Vectorize.cpp<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>0.72<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>0.29<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>-59.7%</font></div><div><font face="Menlo" style="font-size:11px">tools/llvm-diff/DiffLog.cpp<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>0.58<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>0.26<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>-54.6%</font></div><div><font face="Menlo" style="font-size:11px">lib/Target/ARM/MCTargetDesc/ARMMachORelocationInfo.cpp<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>0.46<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>0.26<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>-44.1%</font></div><div><font face="Menlo" style="font-size:11px">lib/DebugInfo/DWARF/DWARFExpression.cpp<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>0.68<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>0.38<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>-43.3%</font></div><div><font face="Menlo" style="font-size:11px">lib/LTO/LTOModule.cpp<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>2.25<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>1.33<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>-41.1%</font></div><div><font face="Menlo" style="font-size:11px">lib/Target/TargetMachine.cpp<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>1.76<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>1.10<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>-37.8%</font></div></div><div><br></div><div>Full list:</div><div></div></div><div style="word-wrap:break-word"><div></div><div><br></div><div><br></div><div><b>Clang top 10</b></div><div><div><font face="Menlo" style="font-size:11px"><b><u>Filename<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>Old<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>New<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>Delta</u></b></font></div><div><span style="font-size:11px;font-family:Menlo">tools/libclang/CXString.cpp<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>1.70<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>0.25<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>-85.2%</span></div></div><div><font face="Menlo" style="font-size:11px"><div>lib/Tooling/CommonOptionsParser.cpp<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>1.69<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>0.55<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>-67.3%</div><div>lib/AST/StmtViz.cpp<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>1.02<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>0.44<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>-57.4%</div><div>tools/driver/cc1_main.cpp<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>2.26<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>0.97<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>-57.1%</div><div>unittests/CodeGen/BufferSourceTest.cpp<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>3.08<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>1.83<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>-40.6%</div><div>lib/CodeGen/CGLoopInfo.cpp<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>1.91<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>1.34<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>-29.9%</div><div>unittests/Tooling/RefactoringActionRulesTest.cpp<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>2.46<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>1.79<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>-27.0%</div><div>unittests/CodeGen/CodeGenExternalTest.cpp<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>3.43<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>2.52<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>-26.5%</div><div>tools/libclang/CXStoredDiagnostic.cpp<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>1.67<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>1.26<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>-24.8%</div><div>tools/clang-func-mapping/ClangFnMapGen.cpp<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>2.48<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>1.89<span class="m_-1946522433137472006Apple-tab-span" style="white-space:pre-wrap"> </span>-23.8%</div><div><div style="font-family:Helvetica;font-size:12px"><br></div><div style="font-family:Helvetica;font-size:12px">Full list:</div></div><div style="font-family:Helvetica;font-size:12px"></div></font></div></div><div style="word-wrap:break-word"><div><font face="Menlo" style="font-size:11px"><div style="font-family:Helvetica;font-size:12px"></div><div style="font-family:Helvetica;font-size:12px"><br></div><div><span style="font-family:Helvetica;font-size:12px">The corresponding patches (careful, they are big):</span></div><div></div></font></div></div>
<div style="word-wrap:break-word"><div><font face="Menlo" style="font-size:11px"><div></div></font></div></div>
<div style="word-wrap:break-word"><div><font face="Menlo" style="font-size:11px"><div></div><div><br></div><div><span style="font-family:Helvetica;font-size:12px"><b>Methodology</b></span></div><div><span style="font-family:Helvetica;font-size:12px">My tool took the compile_commands.json from LLVM build and iterated over files trying to remove redundant headers. To find which header files could be removed it scanned the file for "#include" lines and tried to remove them one by one (checking if the file still compiles after the removal). When there were no more include lines to remove, we verified the change with ninja+ninja check. After it we compared preprocessed file size before and after the change hoping to see that it dropped and then checked the compile time impact.</span></div><div><span style="font-family:Helvetica;font-size:12px">NB: As a side effect of this approach we removed all include-lines from inactive "ifdef" sections, which means that the patches <b>*will*</b> break other configurations if applied as-is.</span></div><div><span style="font-family:Helvetica;font-size:12px"><br></span></div><div><span style="font-family:Helvetica;font-size:12px">Thanks,</span></div><div><span style="font-family:Helvetica;font-size:12px">Michael</span></div></font></div></div>_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
</blockquote></div></div></div>