<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hi,<div class=""><br class=""></div><div class="">I tweaked my scripts to avoid removing includes when it doesn't give any significant benefits, which made the patches significantly smaller. This time the patches should not try to remove includes of header files, which are transitively included from other included header files. The gains mostly remained the same (plus/minus noise), the tables are in the end of the email. I also included size of preprocessed files (measured in 1000 lines of code).</div><div class=""><br class=""></div><div class="">I suggest that from here we go as follows: maintainers/interested people take a look at files related to their components and pick the parts of the patches that they consider correct. I'll also start with some files next week if there is no objections to it. Does it sound reasonable?</div><div class=""><br class=""></div><div class="">The most impacted files (the numbers are for Debug build):</div><div class=""><br class=""></div><div class=""><b class="">LLVM top 10</b></div><div class=""><div class=""><b class="" style="font-family: Menlo; font-size: 11px;"><u class="">Filename<span class="Apple-tab-span" style="white-space: pre;"> </span>TimeOld<span class="Apple-tab-span" style="white-space: pre;"> </span>TimeNew<span class="Apple-tab-span" style="white-space: pre;"> </span>Delta<span class="Apple-tab-span" style="white-space:pre"> </span></u></b><b class="" style="font-family: Menlo; font-size: 11px;"><u class="">SizeOld<span class="Apple-tab-span" style="white-space:pre"> </span>SizeNew<span class="Apple-tab-span" style="white-space:pre"> </span>SizeDelta</u></b></div><div class=""><font face="Menlo" style="font-size: 11px;" class="">lib/CodeGen/GlobalISel/GlobalISel.cpp<span class="Apple-tab-span" style="white-space:pre"> </span>0.26<span class="Apple-tab-span" style="white-space:pre"> </span>0.02<span class="Apple-tab-span" style="white-space:pre"> </span>-91.6%<span class="Apple-tab-span" style="white-space:pre"> </span>35.0<span class="Apple-tab-span" style="white-space:pre"> </span>0.3<span class="Apple-tab-span" style="white-space:pre"> </span>-99.0%</font></div><div class=""><font face="Menlo" style="font-size: 11px;" class="">lib/MC/MCLabel.cpp<span class="Apple-tab-span" style="white-space:pre"> </span>0.20<span class="Apple-tab-span" style="white-space:pre"> </span>0.02<span class="Apple-tab-span" style="white-space:pre"> </span>-88.0%<span class="Apple-tab-span" style="white-space:pre"> </span>25.5<span class="Apple-tab-span" style="white-space:pre"> </span>0.0<span class="Apple-tab-span" style="white-space:pre"> </span>-99.9%</font></div><div class=""><font face="Menlo" style="font-size: 11px;" class="">tools/llvm-readobj/ObjDumper.cpp<span class="Apple-tab-span" style="white-space:pre"> </span>0.44<span class="Apple-tab-span" style="white-space:pre"> </span>0.10<span class="Apple-tab-span" style="white-space:pre"> </span>-76.8%<span class="Apple-tab-span" style="white-space:pre"> </span>41.0<span class="Apple-tab-span" style="white-space:pre"> </span>11.8<span class="Apple-tab-span" style="white-space:pre"> </span>-71.1%</font></div><div class=""><font face="Menlo" style="font-size: 11px;" class="">lib/MC/MCWinEH.cpp<span class="Apple-tab-span" style="white-space:pre"> </span>0.49<span class="Apple-tab-span" style="white-space:pre"> </span>0.15<span class="Apple-tab-span" style="white-space:pre"> </span>-70.4%<span class="Apple-tab-span" style="white-space:pre"> </span>43.9<span class="Apple-tab-span" style="white-space:pre"> </span>21.4<span class="Apple-tab-span" style="white-space:pre"> </span>-51.2%</font></div><div class=""><font face="Menlo" style="font-size: 11px;" class="">lib/Transforms/Vectorize/Vectorize.cpp<span class="Apple-tab-span" style="white-space:pre"> </span>0.73<span class="Apple-tab-span" style="white-space:pre"> </span>0.29<span class="Apple-tab-span" style="white-space:pre"> </span>-60.7%<span class="Apple-tab-span" style="white-space:pre"> </span>52.7<span class="Apple-tab-span" style="white-space:pre"> </span>35.5<span class="Apple-tab-span" style="white-space:pre"> </span>-32.6%</font></div><div class=""><font face="Menlo" style="font-size: 11px;" class="">tools/llvm-diff/DiffLog.cpp<span class="Apple-tab-span" style="white-space:pre"> </span>0.59<span class="Apple-tab-span" style="white-space:pre"> </span>0.27<span class="Apple-tab-span" style="white-space:pre"> </span>-53.8%<span class="Apple-tab-span" style="white-space:pre"> </span>50.7<span class="Apple-tab-span" style="white-space:pre"> </span>33.7<span class="Apple-tab-span" style="white-space:pre"> </span>-33.7%</font></div><div class=""><font face="Menlo" style="font-size: 11px;" class="">lib/Target/ARM/MCTargetDesc/ARMMachORelocationInfo.cpp<span class="Apple-tab-span" style="white-space:pre"> </span>0.47<span class="Apple-tab-span" style="white-space:pre"> </span>0.25<span class="Apple-tab-span" style="white-space:pre"> </span>-46.7%<span class="Apple-tab-span" style="white-space:pre"> </span>46.7<span class="Apple-tab-span" style="white-space:pre"> </span>37.9<span class="Apple-tab-span" style="white-space:pre"> </span>-18.9%</font></div><div class=""><font face="Menlo" style="font-size: 11px;" class="">lib/DebugInfo/DWARF/DWARFExpression.cpp<span class="Apple-tab-span" style="white-space:pre"> </span>0.67<span class="Apple-tab-span" style="white-space:pre"> </span>0.38<span class="Apple-tab-span" style="white-space:pre"> </span>-43.5%<span class="Apple-tab-span" style="white-space:pre"> </span>47.4<span class="Apple-tab-span" style="white-space:pre"> </span>34.8<span class="Apple-tab-span" style="white-space:pre"> </span>-26.7%</font></div><div class=""><font face="Menlo" style="font-size: 11px;" class="">lib/Transforms/Utils/ASanStackFrameLayout.cpp<span class="Apple-tab-span" style="white-space:pre"> </span>0.52<span class="Apple-tab-span" style="white-space:pre"> </span>0.32<span class="Apple-tab-span" style="white-space:pre"> </span>-38.8%<span class="Apple-tab-span" style="white-space:pre"> </span>41.7<span class="Apple-tab-span" style="white-space:pre"> </span>33.7<span class="Apple-tab-span" style="white-space:pre"> </span>-19.2%</font></div><div class=""><font face="Menlo" style="font-size: 11px;" class="">tools/llvm-dwp/llvm-dwp.cpp<span class="Apple-tab-span" style="white-space:pre"> </span>2.48<span class="Apple-tab-span" style="white-space:pre"> </span>1.53<span class="Apple-tab-span" style="white-space:pre"> </span>-38.3%<span class="Apple-tab-span" style="white-space:pre"> </span>92.5<span class="Apple-tab-span" style="white-space:pre"> </span>55.2<span class="Apple-tab-span" style="white-space:pre"> </span>-40.3%</font></div><div class=""><br class=""></div><div class="">Full list:</div><div class=""></div></div></body></html>