<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Thanks everybody for your feedback on the patch! <span style="font-family: 'Segoe UI', 'Segoe UI Emoji', 'Segoe UI Symbol', Lato, 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 13px; background-color: rgb(255, 255, 255);" class="">I think I've addressed all of it now. I'll commit this tomorrow barring any further comments.</span><div class=""><font face="Segoe UI, Segoe UI Emoji, Segoe UI Symbol, Lato, Helvetica Neue, Helvetica, Arial, sans-serif" size="2" class=""><span style="background-color: rgb(255, 255, 255);" class=""><br class=""></span></font></div><div class=""><font face="Segoe UI, Segoe UI Emoji, Segoe UI Symbol, Lato, Helvetica Neue, Helvetica, Arial, sans-serif" size="2" class=""><span style="background-color: rgb(255, 255, 255);" class="">best,</span></font></div><div class=""><font face="Segoe UI, Segoe UI Emoji, Segoe UI Symbol, Lato, Helvetica Neue, Helvetica, Arial, sans-serif" size="2" class=""><span style="background-color: rgb(255, 255, 255);" class="">vedant</span></font><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Dec 4, 2017, at 2:18 PM, Davide Italiano <<a href="mailto:davide@freebsd.org" class="">davide@freebsd.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">On Mon, Dec 4, 2017 at 1:44 PM, Vedant Kumar <<a href="mailto:vsk@apple.com" class="">vsk@apple.com</a>> wrote:<br class=""><blockquote type="cite" class="">Hi,<br class=""><br class="">I've prototyped a pair of passes which 1) add synthetic debug info to a<br class="">Module and 2) determine how much of that info is lost. The idea is to make<br class="">it easier to write targeted test cases for debug info preservation. For<br class="">example, here is a quick way to test that Mem2Reg doesn't drop debug info<br class="">from one test input:<br class=""><br class="">; RUN: opt < %s -debugify -mem2reg -check-debugify -S 2>&1 | FileCheck %s<br class="">; CHECK: CheckDebugify: PASS<br class=""><br class=""><br class="">So far, I've used this utility to identify problems in LSR and instcombine<br class="">(haven't gotten around to filing bugs yet). There's some more discussion<br class="">about this utility on the thread "RFC: [GlobalISel] Towards a generic MI<br class="">combiner framework", where Amara and Daniel suggested trying something<br class="">similar at the MI level.<br class=""><br class="">I've put the passes up for review here <a href="https://reviews.llvm.org/D40512" class="">https://reviews.llvm.org/D40512</a>. I<br class="">just wanted to ping llvm-dev to raise awareness about the proposed passes,<br class="">and to see if anyone in the community has concerns/feedback.<br class=""><br class="">thanks,<br class="">vedant<br class=""></blockquote><br class="">After you addressed all my comments, this is pretty close to me. I'll<br class="">take another look today or tomorrow but I'm confident we can iterate<br class="">in tree.<br class="">In other words, +1 from me (you may want to wait a week or so before<br class="">committing so that people have a chance to take a look).<br class=""><br class=""><br class="">-- <br class="">Davide<br class=""><br class="">"There are no solved problems; there are only problems that are more<br class="">or less solved" -- Henri Poincare<br class=""></div></div></blockquote></div><br class=""></div></div></body></html>