<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Nov 24, 2017, at 6:00 PM, 陳韋任 <<a href="mailto:chenwj.cs97g@g2.nctu.edu.tw" class="">chenwj.cs97g@g2.nctu.edu.tw</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Of course, you want to duplicate as little of the generic scheduling logic as you can. So I think the challenge is how to expose the<br class="">
generic scheduler's functionality as a base class or composition of utilities so that defining your strategy doesn't require too much<br class="">
copy-paste.</blockquote><div class=""><br class=""></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Isn't GCNMaxOccupancySchedStrategy [1] already an example on using GenericScheduler as the base class?</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br class=""></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">[1] <a href="http://llvm.org/doxygen/classllvm_1_1GCNMaxOccupancySchedStrategy.html" class="">http://llvm.org/doxygen/classllvm_1_1GCNMaxOccupancySchedStrategy.html</a></div></div></div></div></div></blockquote><br class=""></div><div>Yes. I think GenericScheduler and related logic should continue to evolve to make that approach easier and more clear. The idea should be “take what you need and build on top". Not “take everything and randomly fiddle with dozens of knobs”.</div><div>-Andy</div><br class=""></body></html>