<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">
<br class="">
<div>
<blockquote type="cite" class="">
<div class="">On 17 Nov 2017, at 22:51, Justin Bogner <<a href="mailto:mail@justinbogner.com" class="">mail@justinbogner.com</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class=""><span style="font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">Justin
Bogner <</span><a href="mailto:mail@justinbogner.com" style="font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">mail@justinbogner.com</a><span style="font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">>
writes:</span><br style="font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">
<blockquote type="cite" style="font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">
Kristof Beyls via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a>> writes:<br class="">
<blockquote type="cite" class="">On 13 Nov 2017, at 18:26, Quentin Colombet <<a href="mailto:qcolombet@apple.com" class="">qcolombet@apple.com</a>> wrote:<br class="">
<blockquote type="cite" class="">Hi Kristof,<br class="">
<br class="">
On Nov 13, 2017, at 9:10 AM, Kristof Beyls <<a href="mailto:Kristof.Beyls@arm.com" class="">Kristof.Beyls@arm.com</a>> wrote:<br class="">
<blockquote type="cite" class="">Hi Quentin,<br class="">
<br class="">
My only remaining concern is around ABI compatibility.<br class="">
The following commit seems to indicate that in the previous round of<br class="">
evaluation, we didn’t find an existing ABI compatibility issue:<br class="">
<a href="http://llvm.org/viewvc/llvm-project?view=revision&revision=311388" class="">http://llvm.org/viewvc/llvm-project?view=revision&revision=311388</a>.<br class="">
I haven’t looked into the details of this issue - so maybe I’m worried<br class="">
over nothing?<br class="">
</blockquote>
<br class="">
No, you’re right. The problem with ABI is if you are consistently wrong,<br class="">
then you won’t notice :).<br class="">
<br class="">
<blockquote type="cite" class="">I’m wondering if since then on your side you did any testing around<br class="">
ABI compatibility?<br class="">
E.g. building software where you semi-randomly build some functions<br class="">
through GlobalISel and some functions through DAGISel?<br class="">
</blockquote>
<br class="">
Justin will look into that. Clang has utility script for that utils/<br class="">
ABITest.<br class="">
<br class="">
Given we will only be able to check iOS ABI, you may want to follow the<br class="">
same kind of validation on your side.<br class="">
</blockquote>
</blockquote>
</blockquote>
<br style="font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">
<span style="font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">Looping
back here, I generated and ran 1000000 test cases with the</span><br style="font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">
<span style="font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">ABITest
utility and hit some fallbacks and an "invalid zero-sized type"</span><br style="font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">
<span style="font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">assert
that need looking at, but it didn't uncover any ABI issues.</span><br style="font-family: Menlo-Regular; font-size: 11px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">
</div>
</blockquote>
</div>
<br class="">
<div class="">Hi Justin,</div>
<div class=""><br class="">
</div>
<div class="">I followed the instructions you provided earlier in the thread to get these tests running on linux.</div>
<div class="">I also had to change the “#!/bin/sh” lines in the script to “#!/bin/bash”, as apparently the shell scripts in there rely on some bash-isms.</div>
<div class=""><br class="">
</div>
<div class="">I ran 10000 test cases and didn’t find ABI issues in those; but also found the same “invalid zero-size type” assert.</div>
<div class="">I’ve file a PR at <a href="https://bugs.llvm.org/show_bug.cgi?id=35358" class="">https://bugs.llvm.org/show_bug.cgi?id=35358</a> for that assert and linked it to the umbrella issue <a href="https://bugs.llvm.org/show_bug.cgi?id=35347" class="">https://bugs.llvm.org/show_bug.cgi?id=35347</a>.</div>
<div class=""><br class="">
</div>
<div class="">Thanks!</div>
<div class=""><br class="">
</div>
<div class="">Kristof</div>
</body>
</html>