<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=koi8-r">
<style type="text/css" style="display:none"><!-- p { margin-top: 0px; margin-bottom: 0px; }--></style>
</head>
<body dir="ltr" style="font-size:12pt;color:#000000;background-color:#FFFFFF;font-family:Calibri,Arial,Helvetica,sans-serif;">
<p>Hi !<br>
</p>
<p><br>
</p>
<p>I have a question about code used for collecting ranges. I was trying to fix PR35199. <br>
</p>
<p>Its issue that it calls unreachable when calls DWARFObject::getFileName().<br>
</p>
<p>We do not implement this method in LLD and it fails.</p>
<p>Issue appears when we start to provide .debug_str</p>
<p>section to DWARF parser. And it is relative to following code (lines 335-339):<br>
</p>
<p><br>
</p>
<p><a href="https://github.com/llvm-mirror/llvm/blob/master/lib/DebugInfo/DWARF/DWARFUnit.cpp#L335">https://github.com/llvm-mirror/llvm/blob/master/lib/DebugInfo/DWARF/DWARFUnit.cpp#L335</a><br>
</p>
<p><br>
</p>
<p>Object I used for debugging parser is following:<br>
</p>
<pre class="bz_comment_text" id="comment_text_4" style="font-size: small; white-space: pre-wrap; width: 50em; background-color: rgb(255, 255, 255);">t.ii:
int a;<br></pre>
<pre class="bz_comment_text" id="comment_text_4" style="font-size: small; white-space: pre-wrap; width: 50em; background-color: rgb(255, 255, 255);">clang++ -gsplit-dwarf -c t.ii -o t.o<br><br></pre>
<pre class="bz_comment_text" id="comment_text_4" style="white-space: pre-wrap; width: 50em; background-color: rgb(255, 255, 255);"><span style="font-family: Calibri, Arial, Helvetica, sans-serif; background-color: rgb(255, 255, 255);"></span><span style="font-family: Calibri, Arial, Helvetica, sans-serif;">When parser tries to read this object it attemps to extract address ranges from dwo. </span></pre>
<pre class="bz_comment_text" id="comment_text_4" style="white-space: pre-wrap; width: 50em; background-color: rgb(255, 255, 255);"><p style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 16px;">When we don't give it .debug_str it fails to extract dwo name, exits early and "works" fine, but with<br></p><p style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 16px;">.debug_str provided it tries to take ranges from there, tries to get DWO name to open it and fails. <br></p><p style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 16px;"><br></p><p style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 16px;">Though I did not find why it tries to scan .dwo. I tried to comment these lines (335-339) and no tests</p><p style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 16px;">were failing for me, at least I tried running tests from \llvm\test\DebugInfo and</p><p style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 16px;">running DebugInfoDWARFTests. It seems to me these lines are either untested or useless (?).<br></p><p style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 16px;"><br></p><p style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 16px;">So my question is probably next: what is the case when we need to scan .dwo for extracting ranges,<br></p><p style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 16px;">should not address data be accessible from main object always ?<br></p><p style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 16px;">I wonder if these lines really do useful job ?<br></p></pre>
<div id="Signature">
<div name="divtagdefaultwrapper" style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:; margin:0">
<div class="BodyFragment"><font size="2">
<div class="PlainText">Best regards,<br>
George | Developer | <span style="background-color:rgb(255,255,255); color:rgb(33,33,33); font-family:Calibri,sans-serif; font-size:13.3333px">Access Softek, Inc</span></div>
</font></div>
</div>
</div>
</body>
</html>