<div dir="ltr">Hi All,<div><br></div><div>I just posted a review with arcanist (which I'm fairly new to) and it included a build status. How it got there is totally opaque to me, but my workflow was: Using git+svn (following the setup in <a href="https://llvm.org/docs/GettingStarted.html#for-developers-to-work-with-git-svn">https://llvm.org/docs/GettingStarted.html#for-developers-to-work-with-git-svn</a>) make a change, commit with 'git commit', create review with 'air diff'.</div><div><br></div><div>It would be cool if arcanist was running some sort of pre-review checks, but I'm executing arc from my source directory and I'm not sure how it would be getting from there to the build directory to actually verify anything about the build.</div><div><br></div><div>Cheers,</div><div>Lang.</div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Nov 9, 2017 at 6:16 AM, Nemanja Ivanovic via llvm-dev <span dir="ltr"><<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I am actually curious about that as well. I took it to mean that some people have some kind of pre-delivery buildbot hooks in Phabricator. But that may just be wishful thinking :).<br></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Nov 8, 2017 at 11:16 PM, Robinson, Paul via llvm-dev <span dir="ltr"><<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I've noticed that some reviews, but not others, show up in Phab<br>
with a "buildable" indication in a "Diff Detail" box, just below<br>
the summary.<br>
<br>
Can somebody describe what that's about?  Most interesting might<br>
be why it's there only sometimes, also what sort of "build" this<br>
indication is reporting.<br>
<br>
Thanks,<br>
--paulr<br>
<br>
______________________________<wbr>_________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-dev</a><br>
</blockquote></div><br></div>
</div></div><br>______________________________<wbr>_________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-dev</a><br>
<br></blockquote></div><br></div>