<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto">Hi Henrique,<div><br></div><div>I’m really sorry, I lost track of this. I just committed your patch as r316142.</div><div><br></div><div>Thank you for your contribution!</div><div><br></div><div>-Chris<br><div><br>On Oct 18, 2017, at 4:47 PM, Henrique Jung <<a href="mailto:henriquenj@gmail.com">henriquenj@gmail.com</a>> wrote:<br><br></div><blockquote type="cite"><div><div dir="ltr">Hi all. Is there anything else to be done for the patch to be merged?<div><br></div><div>Best regards</div><div>Henrique Jung</div><div class="gmail_extra"><br><div class="gmail_quote">On 9 October 2017 at 19:56, NAKAMURA Takumi <span dir="ltr"><<a href="mailto:geek4civic@gmail.com" target="_blank">geek4civic@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Note, I guess it may work for "Unix Makefiles", since we discarded autoconf support.</div><div class="HOEnZb"><div class="h5"><br><div class="gmail_quote"><div dir="ltr">On Tue, Oct 10, 2017 at 7:54 AM Henrique Jung via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><span style="font-size:12.8px">Hi Chris</span><div style="font-size:12.8px"><br></div><div style="font-size:12.8px">Thanks for reviewing. I do not have commit access, this is my first contribution to LLVM. So I ask you to commit for me.</div><div style="font-size:12.8px"><br></div><div style="font-size:12.8px">Thanks</div></div><div class="gmail_extra"><br><div class="gmail_quote">On 9 October 2017 at 14:25, Chris Bieneman <span dir="ltr"><<a href="mailto:beanz@apple.com" target="_blank">beanz@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">This patch looks reasonable to me. Thank you for submitting it.<div><br></div><div>Is it correct to assume you don't have commit access? If you don't I can commit it for you later today.</div><div><br></div><div>-Chris</div><div><br><div><blockquote type="cite"><div><div class="m_4519370444232684236m_-4878704452814960745h5"><div>On Oct 8, 2017, at 9:36 PM, Henrique Jung via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>> wrote:</div><br class="m_4519370444232684236m_-4878704452814960745m_1175752258297046165Apple-interchange-newline"></div></div><div><div><div class="m_4519370444232684236m_-4878704452814960745h5"><div dir="ltr">Hi<div><br></div><div>Would the maintainers please consider merging the attached patch? Detailed description of my problem is on the commit log.</div><div><br></div><div>I tracked down this build-time check back to a commit by Oscar Fuentes in 2008 (<a href="https://github.com/llvm-mirror/llvm/commit/6326a0d5090110c334a3a554bfb10b37a6fe4709" target="_blank">https://github.com/llvm-<wbr>mirror/llvm/commit/<wbr>6326a0d5090110c334a3a554bfb10b<wbr>37a6fe4709</a>) and hasn't been changed since. It seems to be unnecessary to prevent a parent project from doing in-source builds.</div><div><br></div><div>I ran my project with `make` and it seems to have solved my problem. LLVM now builds out-of-tree while my project can be built in-tree. </div><div><br></div><div>I ran 'make check-llvm' to test it, which gave me this result.</div><div><br></div><div><div>Testing Time: 121.05s</div><div> Expected Passes : 21278</div><div> Expected Failures : 220</div><div> Unsupported Tests : 788</div><div>[100%] Built target check-llvm</div></div><div><br></div><div>However I couldn't build `make check-llvm` using in-tree builds, I had to fall back to out-of-tree builds. So to summarize: now LLVM can be part of a parent project that uses in-source builds, but the tests must still be built out-of-tree. If the maintainers are OK with this limitation, the patch is ready. Otherwise I'd have to track down what changes are necessary on the test targets.<br></div><div><br></div><div>Best regards</div><div>Henrique Jung</div><div><br></div></div>
</div></div><span id="m_4519370444232684236m_-4878704452814960745m_1175752258297046165cid:594E5350-15AF-4AE7-996F-1C903A656AB0"><0001-CMake-Allow-parent-<wbr>projects-to-use-in-source-<wbr>builds.patch></span>_________________<wbr>______________________________<br>LLVM Developers mailing list<br><a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-dev</a><br></div></blockquote></div><br></div></div></blockquote></div><br></div>
______________________________<wbr>_________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-dev</a><br>
</blockquote></div>
</div></div></blockquote></div><br></div></div>
</div></blockquote></div></body></html>