<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">This patch looks reasonable to me. Thank you for submitting it.<div class=""><br class=""></div><div class="">Is it correct to assume you don't have commit access? If you don't I can commit it for you later today.</div><div class=""><br class=""></div><div class="">-Chris</div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Oct 8, 2017, at 9:36 PM, Henrique Jung via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Hi<div class=""><br class=""></div><div class="">Would the maintainers please consider merging the attached patch? Detailed description of my problem is on the commit log.</div><div class=""><br class=""></div><div class="">I tracked down this build-time check back to a commit by Oscar Fuentes in 2008 (<a href="https://github.com/llvm-mirror/llvm/commit/6326a0d5090110c334a3a554bfb10b37a6fe4709" target="_blank" class="">https://github.com/llvm-<wbr class="">mirror/llvm/commit/<wbr class="">6326a0d5090110c334a3a554bfb10b<wbr class="">37a6fe4709</a>) and hasn't been changed since. It seems to be unnecessary to prevent a parent project from doing in-source builds.</div><div class=""><br class=""></div><div class="">I ran my project with `make` and it seems to have solved my problem. LLVM now builds out-of-tree while my project can be built in-tree. </div><div class=""><br class=""></div><div class="">I ran 'make check-llvm' to test it, which gave me this result.</div><div class=""><br class=""></div><div class=""><div class="">Testing Time: 121.05s</div><div class=""> Expected Passes : 21278</div><div class=""> Expected Failures : 220</div><div class=""> Unsupported Tests : 788</div><div class="">[100%] Built target check-llvm</div></div><div class=""><br class=""></div><div class="">However I couldn't build `make check-llvm` using in-tree builds, I had to fall back to out-of-tree builds. So to summarize: now LLVM can be part of a parent project that uses in-source builds, but the tests must still be built out-of-tree. If the maintainers are OK with this limitation, the patch is ready. Otherwise I'd have to track down what changes are necessary on the test targets.<br class=""></div><div class=""><br class=""></div><div class="">Best regards</div><div class="">Henrique Jung</div><div class=""><br class=""></div></div>
<span id="cid:594E5350-15AF-4AE7-996F-1C903A656AB0"><0001-CMake-Allow-parent-projects-to-use-in-source-builds.patch></span>_______________________________________________<br class="">LLVM Developers mailing list<br class=""><a href="mailto:llvm-dev@lists.llvm.org" class="">llvm-dev@lists.llvm.org</a><br class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev<br class=""></div></blockquote></div><br class=""></div></body></html>