<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
span.EmailStyle18
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle19
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle20
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal">Ignore the suggested fix in my earlier post. How about this?<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="font-family:Consolas">diff --git a/lib/Target/X86/X86ISelLowering.cpp b/lib/Target/X86/X86ISelLowering.cpp<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas">index 20c81c3..b8ebf42 100644<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas">--- a/lib/Target/X86/X86ISelLowering.cpp<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas">+++ b/lib/Target/X86/X86ISelLowering.cpp<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas">@@ -1632,10 +1632,11 @@ X86TargetLowering::X86TargetLowering(const X86TargetMachine &TM,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas"> if (!Subtarget.is64Bit()) {<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas"> // These libcalls are not available in 32-bit.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas"> setLibcallName(RTLIB::SHL_I128, nullptr);<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas"> setLibcallName(RTLIB::SRL_I128, nullptr);<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas"> setLibcallName(RTLIB::SRA_I128, nullptr);<o:p></o:p></span></p>
<p class="MsoNormal"><b><span style="font-family:Consolas;color:#00B050">+ setLibcallName(RTLIB::MUL_I128, nullptr);<o:p></o:p></span></b></p>
<p class="MsoNormal"><span style="font-family:Consolas"> }<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas"> // Combine sin / cos into one node or libcall if possible.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas"> if (Subtarget.hasSinCos()) {<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas"> setLibcallName(RTLIB::SINCOS_F32, "sincosf");<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas"><o:p> </o:p></span></p>
<p class="MsoNormal"><i><span style="font-family:Consolas">This will make the Legalizer choose the brute force approach below:<o:p></o:p></span></i></p>
<p class="MsoNormal"><span style="font-family:Consolas"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas">void DAGTypeLegalizer::ExpandIntRes_MUL(SDNode *N,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas"> SDValue &Lo, SDValue &Hi) {<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas">...<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas"> <b>if (LC == RTLIB::UNKNOWN_LIBCALL || !TLI.getLibcallName(LC)) {<o:p></o:p></b></span></p>
<p class="MsoNormal"><span style="font-family:Consolas"> // We'll expand the multiplication by brute force because we have no other<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas"> // options. This is a trivially-generalized version of the code from<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas"> // Hacker's Delight (itself derived from Knuth's Algorithm M from section<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:Consolas"> // 4.3.1).<o:p></o:p></span></p>
</div>
</body>
</html>