<html>
<head>
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>+ Rui, the patch author<br>
</p>
<p>Do we know what the oldest glibc which works with this patch is?<br>
</p>
<p>For context, the most recent REHL 5 ships with glibc 2.5. REHL 6
ships with 2.12 and REHL ships with 2.17. I have evidence that
this breaks at least on Centos 6.4 which is derived from REHL 6.
<br>
</p>
<p>This appears to break on anything REHL 6 (or earlier) derived. I
think this patch needs to be reverted. Thoughts?<br>
</p>
<p>Philip<br>
</p>
<br>
<div class="moz-cite-prefix">On 10/04/2017 12:08 AM, Serguei Katkov
via llvm-dev wrote:<br>
</div>
<blockquote type="cite"
cite="mid:4f189faa64164124b282569a64b2f943@azul.com">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0in;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:"Courier New";}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:56.7pt 42.5pt 56.7pt 85.05pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal">Hi All,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">The landed patch <a
href="https://reviews.llvm.org/D38481"
moz-do-not-send="true">https://reviews.llvm.org/D38481</a>
introduced the usage of CPU_COUNT defined in glibc sched.h
header.<o:p></o:p></p>
<p class="MsoNormal">I failed to find this symbol in sched.h of
glibc version 2.5-24, so compilation just fails.<o:p></o:p></p>
<p class="MsoNormal"><span
style="font-size:10.0pt;font-family:"Courier
New";color:black">/home/dolphin/merge-from-upstream-area/ws/pristine/lib/Support/Threading.cpp:
In function ‘unsigned int llvm::hardware_concurrency()’:<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:10.0pt;font-family:"Courier
New";color:black">/home/dolphin/merge-from-upstream-area/ws/pristine/lib/Support/Threading.cpp:80:26:
error: ‘CPU_COUNT’ was not declared in this scope<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:10.0pt;font-family:"Courier
New";color:black"> return CPU_COUNT(&Set);<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:10.0pt;font-family:"Courier
New";color:black"> ^<o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">It is buildable with newest version of
glibc. <o:p></o:p></p>
<p class="MsoNormal">I tried to find a requirements for glibc
version in LLVM documentation but failed.<o:p></o:p></p>
<p class="MsoNormal">So I wonder whether there is such
requirement or not.<o:p></o:p></p>
<p class="MsoNormal">Could anyone point me to this
documentation?<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">I'm trying to understand whether patch is
wrong which relies on availability of library but does not
check the symbol itself or this version of glibc is not
supported.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thank you,<o:p></o:p></p>
<p class="MsoNormal">Serguei.<o:p></o:p></p>
<p class="MsoNormal"><span lang="RU"><o:p> </o:p></span></p>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
LLVM Developers mailing list
<a class="moz-txt-link-abbreviated" href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a>
<a class="moz-txt-link-freetext" href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a>
</pre>
</blockquote>
<br>
</body>
</html>