<div dir="ltr">This works for me.  Can you run "which clang-func-mapping" and also add a line to clang/test/<a href="http://lit.cfg.py">lit.cfg.py</a> to print the value of config.environment['PATH']?</div><br><div class="gmail_quote"><div dir="ltr">On Fri, Sep 22, 2017 at 11:27 AM Zachary Turner <<a href="mailto:zturner@google.com">zturner@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Looking, thanks for the report.</div><br><div class="gmail_quote"><div dir="ltr">On Fri, Sep 22, 2017 at 11:22 AM Vedant Kumar <<a href="mailto:vsk@apple.com" target="_blank">vsk@apple.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><span></span><span>As of r</span><span>313998, </span>this workflow no longer works:<div><br></div><div>  cd <build-dir></div><div>  ./bin/llvm-lit <src>/llvm/tools/clang/test/CoverageMapping</div><div><br></div><div>I get:</div><div><br></div><div><div style="margin:0px;line-height:normal;font-family:Menlo;color:rgb(244,244,244);background-color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">llvm-lit: /Users/vk/src/<a href="http://llvm.org" target="_blank">llvm.org</a>-coverage-braces/llvm/tools/clang/test/<a href="http://lit.cfg.py:97" target="_blank">lit.cfg.py:97</a>: note: using clang: '/Volumes/Builds/<a href="http://llvm.org" target="_blank">llvm.org</a>-coverage-braces-RA/bin/clang'</span></div><div style="margin:0px;line-height:normal;font-family:Menlo;color:rgb(244,244,244);background-color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">llvm-lit: /Users/vk/src/<a href="http://llvm.org" target="_blank">llvm.org</a>-coverage-braces/llvm/utils/lit/lit/TestingConfig.py:101: fatal: unable to parse config file '/Users/vk/src/<a href="http://llvm.org" target="_blank">llvm.org</a>-coverage-braces/llvm/tools/clang/test/<a href="http://lit.cfg.py" target="_blank">lit.cfg.py</a>', traceback: Traceback (most recent call last):</span></div><div style="margin:0px;line-height:normal;font-family:Menlo;color:rgb(244,244,244);background-color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">  File "/Users/vk/src/<a href="http://llvm.org" target="_blank">llvm.org</a>-coverage-braces/llvm/utils/lit/lit/TestingConfig.py", line 88, in load_from_path</span></div><div style="margin:0px;line-height:normal;font-family:Menlo;color:rgb(244,244,244);background-color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">    exec(compile(data, path, 'exec'), cfg_globals, None)</span></div><div style="margin:0px;line-height:normal;font-family:Menlo;color:rgb(244,244,244);background-color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">  File "/Users/vk/src/<a href="http://llvm.org" target="_blank">llvm.org</a>-coverage-braces/llvm/tools/clang/test/<a href="http://lit.cfg.py" target="_blank">lit.cfg.py</a>", line 128, in <module></span></div><div style="margin:0px;line-height:normal;font-family:Menlo;color:rgb(244,244,244);background-color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">    config.substitutions.append( ('%clang_func_map', ' ' + lit.util.which('clang-func-mapping', config.environment['PATH']) + ' ') )</span></div><div style="margin:0px;line-height:normal;font-family:Menlo;color:rgb(244,244,244);background-color:rgb(0,0,0)"><span style="font-variant-ligatures:no-common-ligatures">TypeError: cannot concatenate 'str' and 'NoneType' objects</span></div></div><span><br></span>However, this still works when running tests within llvm:<div><br></div><div>  ./bin/llvm-lit <src>/llvm/test/tools/llvm-cov</div><div><br></div><div>I'd appreciate any help in getting this working again.</div><div><br></div><div>thanks,</div><div>vedant</div><div><br></div></div></blockquote></div></blockquote></div>