<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Ah, the problem goes away once I build clang-func-mapping.<div class=""><br class=""></div><div class="">I stripped some stuff out, but here's pretty much what clang/test/lit.cfg.py says my PATH is:<br class=""><div class=""><br class=""></div><div class=""><span style="color: rgb(244, 244, 244); font-family: Menlo; background-color: rgb(0, 0, 0);" class="">** PATH **:</span><span style="color: rgb(244, 244, 244); font-family: Menlo; background-color: rgb(0, 0, 0);" class=""> </span><span style="color: rgb(244, 244, 244); font-family: Menlo; background-color: rgb(0, 0, 0);" class="">/Volumes/Builds/<a href="http://llvm.org" class="">llvm.org</a>-coverage-braces-RA/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin</span></div><div class=""><br class=""></div><div class="">I wonder how this ever worked before, when I didn't have clang-func-mapping built.</div><div class=""><br class=""></div><div class="">Anyway, thanks for your help!</div><div class=""><br class=""></div><div class="">vedant</div><div class=""> <br class=""><div><blockquote type="cite" class=""><div class="">On Sep 22, 2017, at 11:31 AM, Zachary Turner <<a href="mailto:zturner@google.com" class="">zturner@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">This works for me. Can you run "which clang-func-mapping" and also add a line to clang/test/<a href="http://lit.cfg.py/" class="">lit.cfg.py</a> to print the value of config.environment['PATH']?</div><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Fri, Sep 22, 2017 at 11:27 AM Zachary Turner <<a href="mailto:zturner@google.com" class="">zturner@google.com</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="">Looking, thanks for the report.</div><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Fri, Sep 22, 2017 at 11:22 AM Vedant Kumar <<a href="mailto:vsk@apple.com" target="_blank" class="">vsk@apple.com</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word" class=""><span class=""></span><span class="">As of r</span><span class="">313998, </span>this workflow no longer works:<div class=""><br class=""></div><div class=""> cd <build-dir></div><div class=""> ./bin/llvm-lit <src>/llvm/tools/clang/test/CoverageMapping</div><div class=""><br class=""></div><div class="">I get:</div><div class=""><br class=""></div><div class=""><div style="margin:0px;line-height:normal;font-family:Menlo;color:rgb(244,244,244);background-color:rgb(0,0,0)" class=""><span style="font-variant-ligatures:no-common-ligatures" class="">llvm-lit: /Users/vk/src/<a href="http://llvm.org/" target="_blank" class="">llvm.org</a>-coverage-braces/llvm/tools/clang/test/<a href="http://lit.cfg.py:97/" target="_blank" class="">lit.cfg.py:97</a>: note: using clang: '/Volumes/Builds/<a href="http://llvm.org/" target="_blank" class="">llvm.org</a>-coverage-braces-RA/bin/clang'</span></div><div style="margin:0px;line-height:normal;font-family:Menlo;color:rgb(244,244,244);background-color:rgb(0,0,0)" class=""><span style="font-variant-ligatures:no-common-ligatures" class="">llvm-lit: /Users/vk/src/<a href="http://llvm.org/" target="_blank" class="">llvm.org</a>-coverage-braces/llvm/utils/lit/lit/TestingConfig.py:101: fatal: unable to parse config file '/Users/vk/src/<a href="http://llvm.org/" target="_blank" class="">llvm.org</a>-coverage-braces/llvm/tools/clang/test/<a href="http://lit.cfg.py/" target="_blank" class="">lit.cfg.py</a>', traceback: Traceback (most recent call last):</span></div><div style="margin:0px;line-height:normal;font-family:Menlo;color:rgb(244,244,244);background-color:rgb(0,0,0)" class=""><span style="font-variant-ligatures:no-common-ligatures" class=""> File "/Users/vk/src/<a href="http://llvm.org/" target="_blank" class="">llvm.org</a>-coverage-braces/llvm/utils/lit/lit/TestingConfig.py", line 88, in load_from_path</span></div><div style="margin:0px;line-height:normal;font-family:Menlo;color:rgb(244,244,244);background-color:rgb(0,0,0)" class=""><span style="font-variant-ligatures:no-common-ligatures" class=""> exec(compile(data, path, 'exec'), cfg_globals, None)</span></div><div style="margin:0px;line-height:normal;font-family:Menlo;color:rgb(244,244,244);background-color:rgb(0,0,0)" class=""><span style="font-variant-ligatures:no-common-ligatures" class=""> File "/Users/vk/src/<a href="http://llvm.org/" target="_blank" class="">llvm.org</a>-coverage-braces/llvm/tools/clang/test/<a href="http://lit.cfg.py/" target="_blank" class="">lit.cfg.py</a>", line 128, in <module></span></div><div style="margin:0px;line-height:normal;font-family:Menlo;color:rgb(244,244,244);background-color:rgb(0,0,0)" class=""><span style="font-variant-ligatures:no-common-ligatures" class=""> config.substitutions.append( ('%clang_func_map', ' ' + lit.util.which('clang-func-mapping', config.environment['PATH']) + ' ') )</span></div><div style="margin:0px;line-height:normal;font-family:Menlo;color:rgb(244,244,244);background-color:rgb(0,0,0)" class=""><span style="font-variant-ligatures:no-common-ligatures" class="">TypeError: cannot concatenate 'str' and 'NoneType' objects</span></div></div><span class=""><br class=""></span>However, this still works when running tests within llvm:<div class=""><br class=""></div><div class=""> ./bin/llvm-lit <src>/llvm/test/tools/llvm-cov</div><div class=""><br class=""></div><div class="">I'd appreciate any help in getting this working again.</div><div class=""><br class=""></div><div class="">thanks,</div><div class="">vedant</div><div class=""><br class=""></div></div></blockquote></div></blockquote></div>
</div></blockquote></div><br class=""></div></div></body></html>