<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Hi llvm-dev,<div class=""><br class=""></div><div class="">In <<a href="https://reviews.llvm.org/D35396" class="">https://reviews.llvm.org/D35396</a>>, several folks agreed that %T is a generally bad idea and should be removed, because it causes randomly flaky tests due to name collisions. This is a heads-up that I have patches to remove uses of %T throughout LLVM, Clang and compiler-rt ready to commit. Unless someone objects, I'll land them in a few days.</div><div class=""><br class=""></div><div class="">Kuba<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On 8 Aug 2017, at 16:57, Justin Bogner <<a href="mailto:mail@justinbogner.com" class="">mail@justinbogner.com</a>> wrote:</div><div class=""><div class=""><blockquote type="cite" class="">kubamracek created this revision.<br class="">Herald added subscribers: kbarton, eraman, javed.absar, nemanjai,<br class="">sdardis, mehdi_amini.<br class=""><br class="">The `%T` lit expansion expands to a common directory shared between<br class="">all the tests in the same directory, which is unexpected and<br class="">unintuitive, and more importantly, it's been a source of subtle race<br class="">conditions and flaky tests. In <a href="https://reviews.llvm.org/D35396" class="">https://reviews.llvm.org/D35396</a>, it<br class="">was agreed that it would be best to simply ban `%T` and only keep<br class="">`%t`, which is unique to each test. When a test needs a temporary<br class="">directory, it can just create one using `mkdir %t`.<br class=""><br class="">This patch removes `%T` in llvm.<br class=""></blockquote><br class="">The patch itself (and the equivalent ones for the other repos) is<br class="">obvious enough to commit without review if we're all agreed to get rid<br class="">of %T.<br class=""><br class="">Please send a note to llvm-dev about getting rid of %T though, just in<br class="">case someone opposes for some reason and to avoid surprising out-of-tree<br class="">folks.<br class=""><br class=""><blockquote type="cite" class=""><br class="">Repository:<br class=""> rL LLVM<br class=""><br class=""><a href="https://reviews.llvm.org/D36495" class="">https://reviews.llvm.org/D36495</a><br class=""></blockquote></div></div></blockquote></div><br class=""></div></body></html>