<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jun 30, 2017 at 5:54 PM, via llvm-dev <span dir="ltr"><<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Problem<br>
-------<br>
<br>
Instrumentation for PGO and frontend-based coverage places a large amount of<br>
data in object files, even though the majority of this data is not needed at<br>
run-time. All the data is needlessly duplicated while generating archives, and<br>
again while linking. PGO name data is written out into raw profiles by<br>
instrumented programs, slowing down the training and code coverage workflows.<br>
<br>
Here are some numbers from a coverage + RA build of ToT clang:<br>
<br>
* Size of the build directory: 4.3 GB<br>
<br>
* Wall time needed to run "clang -help" with an SSD: 0.5 seconds<br>
<br>
* Size of the clang binary: 725.24 MB<br>
<br>
* Space wasted on duplicate name/coverage data (*.o + *.a): 923.49 MB<br>
- Size contributed by __llvm_covmap sections: 1.02 GB<br>
\_ Just within clang: 340.48 MB<br></blockquote><div><br></div><div>We live with this duplication for debug info. In some sense, if the overhead is small compared to debug info, should we even bother (i.e., we assume that users accommodate debug builds, so that is a reasonable bound on the tolerable build directory size). (I don't know the numbers; this seems pretty large so maybe it is significant compared to debug info; just saying that looking at absolute numbers is misleading here; numbers compared to debug info are a closer measure to the user's perceptions)</div><div><br></div><div>In fact, one overall architectural observation I have is that the most complicated part of all this is simply establishing the workflow to plumb together data emitted per-TU to a tool that needs that information to do some post-processing step on the results of running the binary. That sounds a lot like the role of debug info. In fact, having a debugger open a core file is precisely equivalent to what llvm-profdata needs to do in this regard AFAICT.</div><div><br></div><div>So it would be best if possible to piggyback on all the effort that has gone into plumbing that data to make debug info work. For example, I know that on Darwin there's a fair amount of system-level integration to make split dwarf "just work" while keeping debug info out of final binaries.</div><div><br></div><div>If there is a not-too-hacky way to piggyback on debug info, that's likely to be a really slick solution. For example, debug info could in principle (if it doesn't already) contain information about the name of each counter in the counter array, so in principle it would be a complete enough description to identify each counter.</div><div><br></div><div>I'm not very familiar with DWARF, but I'm imagining something like reserving an LLVM vendor-specific DWARF opcode/attribute/whatever and then stick a blob of data in there. Presumably we have code somewhere in LLDB that is "here's a binary, find debug info for it", and in principle we could factor out that code and lift it into an LLVM library (libFindDebugInfo) that llvm-profdata could use.</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
- Size contributed by __llvm_prf_names sections: 327.46 MB<br>
\_ Just within clang: 106.76 MB<br>
<br>
=> Space wasted within the clang binary: 447.24 MB<br>
<br>
Running an instrumented clang binary triggers a 143MB raw profile write which<br>
is slow even with an SSD. This problem is particularly bad for frontend-based<br>
coverage because it generates a lot of extra name data: however, the situation<br>
can also be improved for PGO instrumentation.<br>
<br>
Proposal<br>
--------<br>
<br>
Place PGO name data and coverage data outside of object files. This would<br>
eliminate data duplication in *.a/*.o files, shrink binaries, shrink raw<br>
profiles, and speed up instrumented programs.<br>
<br>
In more detail:<br>
<br>
1. The frontends get a new `-fprofile-metadata-dir=<path><wbr>` option. This lets<br>
users specify where llvm will store profile metadata. If the metadata starts to<br>
take up too much space, there's just one directory to clean.<br>
<br>
2. The frontends continue emitting PGO name data and coverage data in the same<br>
llvm::Module. So does LLVM's IR-based PGO implementation. No change here.<br>
<br>
3. If the InstrProf lowering pass sees that a metadata directory is available,<br>
it constructs a new module, copies the name/coverage data into it, hashes the<br>
module, and attempts to write that module to:<br>
<br>
<metadata-dir>/<module-hash>.<wbr>bc (the metadata module)<br>
<br>
If this write operation fails, it scraps the new module: it keeps all the<br>
metadata in the original module, and there are no changes from the current<br>
process. I.e with this proposal we preserve backwards compatibility.<br></blockquote><div><br></div><div>Based at my experience with Clang's implicit modules, I'm *extremely* wary of anything that might cause the compiler to emit a file that the build system cannot guess the name of. In fact, having the compiler emit a file that is not explicitly listed on the command line is basically just as bad in practice (in terms of feasibility of informing the build system about it).</div><div><br></div><div>As a simple example, ninja simply cannot represent a dependency of this type, so if you delete a <metadata-dir>/<module-hash>.bc it won't know things need to be rebuilt (and it won't know how to clean it, etc.).<br></div><div><br></div><div>So I would really strongly recommend against doing this.</div><div><br></div><div>Again, these problems of system integration (in particular build system integration) are nasty, and if you can bypass this and piggyback on debug info then everything will "just work" because the folks that care about making sure that debugging "just works" already did the work for you.</div><div>It might be more work in the short term to do the debug info approach (if it is feasible at all), but I can tell you based on the experience with implicit modules (and I'm sure you have some experience of your own) that there's just going to be a neverending tail of hitches and ways that things don't work (or work poorly) due to not having the build system / overall system integration right, so it will be worth it in the long run. <br></div><div><br></div><div>-- Sean Silva</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
4. Once the metadata module is written, the name/coverage data are entirely<br>
stripped out of the original module. They are replaced by a path to the<br>
metadata module:<br>
<br>
@__llvm_profiling_metadata = "<metadata-dir>/<module-hash>.<wbr>bc",<br>
section "__llvm_prf_link"<br>
<br>
This allows incremental builds to work properly, which is an important use case<br>
for code coverage users. When an object is rebuilt, it gets a fresh link to a<br>
fresh profiling metadata file. Although stale files can accumulate in the<br>
metadata directory, the stale files cannot ever be used.<br>
<br>
In an IDE like Xcode, since there's just one target binary per scheme, it's<br>
possible to clean the metadata directory by removing the modules which aren't<br>
referenced by the target binary.<br>
<br>
5. The raw profile format is updated so that links to metadata files are written<br>
out in each profile. This makes it possible for all existing llvm-profdata and<br>
llvm-cov commands to work, seamlessly.<br>
<br>
The indexed profile format will *not* be updated: i.e, it will contain a full<br>
symbol table, and no links. This simplifies the coverage mapping reader, because<br>
a full symbol table is guaranteed to exist before any function records are<br>
parsed. It also reduces the amount of coding, and makes it easier to preserve<br>
backwards compatibility :).<br>
<br>
6. The raw profile reader will learn how to read links, open up the metadata<br>
modules it finds links to, and collect name data from those modules.<br>
<br>
7. The coverage reader will learn how to read the __llvm_prf_link section, open<br>
up metadata modules, and lazily read coverage mapping data.<br>
<br>
Alternate Solutions<br>
-------------------<br>
<br>
1. Instead of copying name data into an external metadata module, just copy the<br>
coverage mapping data.<br>
<br>
I've actually prototyped this. This might be a good way to split up patches,<br>
although I don't see why we wouldn't want to tackle the name data problem<br>
eventually.<br>
<br>
2. Instead of emitting links to external metadata modules, modify llvm-cov and<br>
llvm-profdata so that they require a path to the metadata directory.<br>
<br>
The issue with this is that it's way too easy to read stale metadata. It's also<br>
less user-friendly, which hurts adoption.<br>
<br>
3. Use something other than llvm bitcode for the metadata module format.<br>
<br>
Since we're mostly writing large binary blobs (compressed name data or<br>
pre-encoded source range mapping info), using bitcode shouldn't be too slow, and<br>
we're not likely to get better compression with a different format.<br>
<br>
Bitcode is also convenient, and is nice for backwards compatibility.<br>
<br>
------------------------------<wbr>------------------------------<wbr>--------------------<br>
<br>
If you've made it this far, thanks for taking a look! I'd appreciate any<br>
feedback.<br>
<br>
vedant<br>
<br>
______________________________<wbr>_________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-dev</a><br>
</blockquote></div><br></div></div>