<div dir="ltr">The patch is committed in r305960. Please let me know if there is unexpected perf impact after this change.<div><br></div><div>Cheers,</div><div>Dehao</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jun 12, 2017 at 5:43 PM, Dehao Chen <span dir="ltr"><<a href="mailto:dehao@google.com" target="_blank">dehao@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Thanks for the update. I think overall consensus is supportive for this change. If no one objects by then end of tomorrow (Tuesday), I will submit the patch to make vectorizer-maximize-bandwidth on by default.<div><br></div><div>Thanks,</div><div>Dehao<div><div class="h5"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jun 12, 2017 at 3:41 AM, Agabaria, Mohammed <span dir="ltr"><<a href="mailto:mohammed.agabaria@intel.com" target="_blank">mohammed.agabaria@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-US" link="blue" vlink="purple">
<div class="m_-3478010045585332451m_5213807564887609629WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d">Guys, Just to clarify that with the current fix in SLM there is no need to wait for other issues to be fixed (minor issue).<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d">So you can move on with your patch.
<u></u><u></u></span></p>
<p class="MsoNormal"><a name="m_-3478010045585332451_m_5213807564887609629__MailEndCompose"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d"><u></u> <u></u></span></a></p>
<div>
<div style="border:none;border-top:solid #e1e1e1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> Agabaria, Mohammed
<br>
<b>Sent:</b> Wednesday, June 07, 2017 15:24<br>
<b>To:</b> Zaks, Ayal <<a href="mailto:ayal.zaks@intel.com" target="_blank">ayal.zaks@intel.com</a>>; Chandler Carruth <<a href="mailto:chandlerc@gmail.com" target="_blank">chandlerc@gmail.com</a>>; Flamedoge <<a href="mailto:code.kchoi@gmail.com" target="_blank">code.kchoi@gmail.com</a>>; Dehao Chen <<a href="mailto:dehao@google.com" target="_blank">dehao@google.com</a>><br>
<b>Cc:</b> llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>><br>
<b>Subject:</b> RE: [llvm-dev] Enable vectorizer-maximize-bandwidth by default?<u></u><u></u></span></p>
</div>
</div><span>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d">Guys I have uploaded a fix on phabricator which fix the issue in SLM:
<a href="https://reviews.llvm.org/D33983" target="_blank">https://reviews.llvm.org/D3398<wbr>3</a> <u></u>
<u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d"><u></u> <u></u></span></p>
</span><div>
<div style="border:none;border-top:solid #e1e1e1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> Zaks, Ayal
<br><span>
<b>Sent:</b> Tuesday, June 06, 2017 22:32<br>
</span><b>To:</b> Chandler Carruth <<a href="mailto:chandlerc@gmail.com" target="_blank">chandlerc@gmail.com</a>>; Agabaria, Mohammed <<a href="mailto:mohammed.agabaria@intel.com" target="_blank">mohammed.agabaria@intel.com</a>>; Flamedoge <<a href="mailto:code.kchoi@gmail.com" target="_blank">code.kchoi@gmail.com</a>>;
Dehao Chen <<a href="mailto:dehao@google.com" target="_blank">dehao@google.com</a>><br>
<b>Cc:</b> llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>><br>
<b>Subject:</b> RE: [llvm-dev] Enable vectorizer-maximize-bandwidth by default?<u></u><u></u></span></p>
</div>
</div><div><div class="m_-3478010045585332451h5">
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">Chandler<span style="color:#1f497d">>
</span></span>Have you considered contributing these benchmarks to the LLVM test suite?<u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d">These benchmarks are not ours to contribute; they’re from the EEMBC standard, whose availability is similar in nature to that of SPEC.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d"><u></u> <u></u></span></p>
<div>
<div style="border:none;border-top:solid #e1e1e1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><a name="m_-3478010045585332451_m_5213807564887609629______replyseparator"></a><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> llvm-dev [<a href="mailto:llvm-dev-bounces@lists.llvm.org" target="_blank">mailto:llvm-dev-bounces@lists<wbr>.llvm.org</a>]
<b>On Behalf Of </b>Chandler Carruth via llvm-dev<br>
<b>Sent:</b> Tuesday, May 30, 2017 23:07<br>
<b>To:</b> Agabaria, Mohammed <<a href="mailto:mohammed.agabaria@intel.com" target="_blank">mohammed.agabaria@intel.com</a>>; Flamedoge <<a href="mailto:code.kchoi@gmail.com" target="_blank">code.kchoi@gmail.com</a>>; Dehao Chen <<a href="mailto:dehao@google.com" target="_blank">dehao@google.com</a>><br>
<b>Cc:</b> llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>><br>
<b>Subject:</b> Re: [llvm-dev] Enable vectorizer-maximize-bandwidth by default?<u></u><u></u></span></p>
</div>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">On Tue, May 30, 2017 at 1:40 AM Agabaria, Mohammed via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>> wrote:<u></u><u></u></p>
</div>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-top:5.0pt;margin-right:0in;margin-bottom:5.0pt">
<div>
<div>
<p class="MsoNormal" style="text-autospace:none">
<span style="font-size:10.0pt;font-family:"Segoe UI",sans-serif;color:black">We’re seeing nice improvements but also significant degradations on IA, which we would like to investigate before the patch is committed.</span><u></u><u></u></p>
<p class="MsoNormal" style="text-autospace:none">
<span style="font-size:10.0pt;font-family:"Segoe UI",sans-serif;color:black"> </span><u></u><u></u></p>
<p class="MsoNormal" style="text-autospace:none">
<span style="font-size:10.0pt;font-family:"Segoe UI",sans-serif;color:black">Major degradations we see:</span><u></u><u></u></p>
<p class="MsoNormal" style="text-autospace:none">
<span style="font-size:10.0pt;font-family:"Segoe UI",sans-serif;color:black"> </span><u></u><u></u></p>
<p class="MsoNormal" style="margin-bottom:2.0pt;text-autospace:none">
networking<u></u><u></u></p>
<p class="MsoNormal" style="margin-bottom:2.0pt;text-autospace:none">
ip_pktcheckb1m -6.80 %<u></u><u></u></p>
<p class="MsoNormal" style="margin-bottom:2.0pt;text-autospace:none">
ip_pktcheckb2m -6.74 %<u></u><u></u></p>
<p class="MsoNormal" style="margin-bottom:2.0pt;text-autospace:none">
ip_pktcheckb4m -7.57 % <u></u><u></u></p>
<p class="MsoNormal" style="margin-bottom:2.0pt;text-autospace:none">
ip_pktcheckb512k -6.58 %<u></u><u></u></p>
<p class="MsoNormal" style="margin-bottom:2.0pt;text-autospace:none">
Telecom<u></u><u></u></p>
<p class="MsoNormal" style="margin-bottom:2.0pt;text-autospace:none">
autcor00data_1 -78.02 %<u></u><u></u></p>
<p class="MsoNormal" style="margin-bottom:2.0pt;text-autospace:none">
autcor00data_2 -76.80 %<u></u><u></u></p>
<p class="MsoNormal" style="margin-bottom:2.0pt;text-autospace:none">
autcor00data_3 -77.00 %<span style="font-size:10.0pt;font-family:"Segoe UI",sans-serif;color:black">
</span><u></u><u></u></p>
<p class="MsoNormal" style="margin-bottom:2.0pt;text-autospace:none">
<span style="font-size:10.0pt;font-family:"Segoe UI",sans-serif;color:black">(on Atom)</span><u></u><u></u></p>
<p class="MsoNormal" style="text-autospace:none">
<span style="font-size:10.0pt;font-family:"Segoe UI",sans-serif;color:black"> </span><u></u><u></u></p>
<p class="MsoNormal" style="text-autospace:none">
<span style="font-size:10.0pt;font-family:"Segoe UI",sans-serif;color:black">We still working on creating reproducers.
</span><u></u><u></u></p>
<p class="MsoNormal" style="text-autospace:none">
<span style="font-size:10.0pt;font-family:"Segoe UI",sans-serif;color:black">In general we support this patch, just want to have a chance to investigate the issues. We need a few days for that.</span><u></u><u></u></p>
</div>
</div>
</blockquote>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">I mean, OK... but keep in mind that Dehao's original email went out over a week ago, so this patch has already been held up a while. As these benchmarks aren't readily available, we also can't do anything to help until a test case is posted.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Have you considered contributing these benchmarks to the LLVM test suite?<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
<div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d"> </span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d"> </span><u></u><u></u></p>
<p class="MsoNormal"><a name="m_-3478010045585332451_m_5213807564887609629_m_-1727573473381385812______replyseparat"></a><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">
llvm-dev [<a href="mailto:llvm-dev-bounces@lists.llvm.org" target="_blank">mailto:llvm-dev-bounces@lists<wbr>.llvm.org</a>]
<b>On Behalf Of </b>Chandler Carruth via llvm-dev<br>
<b>Sent:</b> Tuesday, May 30, 2017 11:27<br>
<b>To:</b> Flamedoge <<a href="mailto:code.kchoi@gmail.com" target="_blank">code.kchoi@gmail.com</a>>; Dehao Chen <<a href="mailto:dehao@google.com" target="_blank">dehao@google.com</a>><br>
<b>Cc:</b> llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>><br>
<b>Subject:</b> Re: [llvm-dev] Enable vectorizer-maximize-bandwidth by default?</span><u></u><u></u></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
<div>
<p class="MsoNormal">If you care about such hardware, please run benchmarks with the flag?<u></u><u></u></p>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">Dehao has made this flag available. It is important that those who care about particular hardware provid ebenchmark results. Not everyone in the community will have access to particular
hardware variants.<u></u><u></u></p>
</div>
</div>
<p class="MsoNormal"> <u></u><u></u></p>
<div>
<div>
<p class="MsoNormal">On Tue, May 30, 2017 at 1:14 AM Flamedoge <<a href="mailto:code.kchoi@gmail.com" target="_blank">code.kchoi@gmail.com</a>> wrote:<u></u><u></u></p>
</div>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-top:5.0pt;margin-right:0in;margin-bottom:5.0pt">
<div>
<p class="MsoNormal">Thank you for running these.<u></u><u></u></p>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">May I suggest testing on AVX2 capable hardware? That would be Intel Haswell, AMD Carrizo and up.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">I'm not sure what "<span style="font-size:9.5pt">vectorizer-maximize-bandwidth<wbr>" implies, but doubling the vector lanes may help light up parallel regions.</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><span style="font-size:9.5pt">Kevin</span><u></u><u></u></p>
</div>
</div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
<div>
<div>
<p class="MsoNormal">On Tue, May 30, 2017 at 12:58 AM, Chandler Carruth via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>> wrote:<u></u><u></u></p>
</div>
</div>
<div>
<div>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-top:5.0pt;margin-right:0in;margin-bottom:5.0pt">
<div>
<div>
<div>
<p class="MsoNormal">On Fri, May 19, 2017 at 4:01 PM Adam Nemet via llvm-dev <<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>> wrote:<u></u><u></u></p>
</div>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-top:5.0pt;margin-right:0in;margin-bottom:5.0pt">
<div>
<div>
<div>
<p class="MsoNormal">I will run it on Cyclone/AArch64 next week.<u></u><u></u></p>
</div>
</div>
</div>
</blockquote>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">FYI, we're still waiting on these Adam...<u></u><u></u></p>
</div>
</div>
</div>
<p class="MsoNormal"> <u></u><u></u></p>
</blockquote>
</div>
</div>
<div>
<div>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-top:5.0pt;margin-right:0in;margin-bottom:5.0pt">
<p class="MsoNormal" style="margin-bottom:12.0pt">______________________________<wbr>_________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-dev</a><u></u><u></u></p>
</blockquote>
</div>
</div>
</blockquote>
</div>
</div>
</div>
<div>
<p>------------------------------<wbr>------------------------------<wbr>---------<br>
Intel Israel (74) Limited<u></u><u></u></p>
<p>This e-mail and any attachments may contain confidential material for<br>
the sole use of the intended recipient(s). Any review or distribution<br>
by others is strictly prohibited. If you are not the intended<br>
recipient, please contact the sender and delete all copies.<u></u><u></u></p>
</div>
<p class="MsoNormal">______________________________<wbr>_________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-dev</a><u></u><u></u></p>
</div></div></div><div><div class="m_-3478010045585332451h5">
<p>------------------------------<wbr>------------------------------<wbr>---------<br>
Intel Israel (74) Limited</p>
<p>This e-mail and any attachments may contain confidential material for<br>
the sole use of the intended recipient(s). Any review or distribution<br>
by others is strictly prohibited. If you are not the intended<br>
recipient, please contact the sender and delete all copies.</p></div></div></div>
</blockquote></div><br></div></div></div></div></div>
</blockquote></div><br></div>